Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Tue, 24 Oct 2023 11:28:28 +0200
From:   Maciej =?utf-8?Q?Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
To:     James Morse <james.morse@arm.com>
CC:     <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "Borislav Petkov" <bp@alien8.de>, H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        "D Scott Phillips OS" <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
Subject: Re: [PATCH v6 06/24] x86/resctrl: Access per-rmid structures by index
Message-ID: <p35a7jfcezamdtn7euaqlo7sshgjse4iksa6nbo4rvwubyqazf@6pxfzflz5ucb>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-7-james.morse@arm.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230914172138.11977-7-james.morse@arm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?6MKZd4htTb4G2AlyT4Pr5w/Zk/uZIcpXVGQm2TDbvZ28QMxniXDorKoDOn?=
 =?iso-8859-1?Q?b5WE0SaKzqmW/AsNARuoeLx54Ni6sFH9pLjc4Obd29nzTXBC6sVkTfZPTs?=
 =?iso-8859-1?Q?q4/D8ALp7ilyelwgDqhQ0jvkQeTmBqDr3Skx7yP80InqDhvySWWCHxEEx3?=
 =?iso-8859-1?Q?7Qk7c9DXCNktMwgFskEM3CtgTb5/ydw8Q3lDTyPQNI/nSFANakAqugRNZe?=
 =?iso-8859-1?Q?DtI4VYzPLvKSZU1gRjedFnUDk3UjHjadJ4As1zJKMsAfyLEkxaEOoYjaoU?=
 =?iso-8859-1?Q?ITxg/bp/mPQd7grrvlZUnOcU1lh2BFTKHs2xUe7mZyi/2yyh7za470wKHw?=
 =?iso-8859-1?Q?lZj2ikhjRmpqkQzhI7rexpclBPXPNSYUGGF3gg43jqd/o/54WWC8kBgJC4?=
 =?iso-8859-1?Q?nwroTmJnPFqNVOgspqJBw+Yjzlea0wTrw1NMoFMBC/2tjbRdb1OGjit1EC?=
 =?iso-8859-1?Q?ppJ3OpxJ7UGFPalJuupRfm7pzurhfdu+dk1rniQY8AFO8E17Zgzl8AdUnn?=
 =?iso-8859-1?Q?whCcWaZla6+Z/NiuxvctBtCqN3xenv2WKPNRpl9zx7FEct9dTLDN1sxctK?=
 =?iso-8859-1?Q?87zPrHUG9k6xG8o+a7KgYaBX8AYi4nEvrOSKWwG1o9Vq57Z2B5CMGRFScb?=
 =?iso-8859-1?Q?Js27RV78NmDVNM34VTdEEiUygREtJ73DcpFWcISuLJ2KNm0lpkibrTwnjT?=
 =?iso-8859-1?Q?10mhjBE9sIhBLMEEaGmxNd8zVzsj38HgDw/PeIQ4t2LNTtmOBBMpnCXY/w?=
 =?iso-8859-1?Q?E79AElO7xxsBFFBAyFDTr+cCsEBNG+2AkWefmQMTwpBCv221CRXW7sE5hb?=
 =?iso-8859-1?Q?Z5+syKkBSk09Aok1QiPBqXXShqq+oRZcaHF5TgKQFz2D3bsKE3LWn0ImUs?=
 =?iso-8859-1?Q?yj3i9OhRaKuN7j8GNjiM/cyHkyJsCyVF1PIIXgK7CAKxMWO8fpzeQxg3c9?=
 =?iso-8859-1?Q?Wy1amexTbvLDVD6hvkKf+u/7Qc5at048E4/dP13FPpISnRqAD3Kcgj5Dq+?=
 =?iso-8859-1?Q?2ypzIWWqm0rGHrR3wyz8hd71e+ALxQtPFbWuvV8K+naKgw5CdBUmUy3zpA?=
 =?iso-8859-1?Q?xgiWoERh8SsMjCPxs7RG/63xpMKKeguRUGKNWEjMmoldRa5n1NUW/Hj/xn?=
 =?iso-8859-1?Q?ILRydtOZeZwFhuGT0z6yRvdnJBpNpyOE2c9t+WosI1/scyZHSCJnX+0XLj?=
 =?iso-8859-1?Q?tQySElP2yheDDRHrTVAjb6aYzCxQQjUFHwQHosQ5yjOjzi+YuFc27UgJH+?=
 =?iso-8859-1?Q?cru6OaPjes0yuLTQ8jqqrvFERGI25UmKXlYDIVNHkWXkDjyHADoN2iykQ0?=
 =?iso-8859-1?Q?aaOAOJ4h5s0nnRTfAuRtFuXfcaGOnVakF5uVXeZuWnwrBIk7RzKOsuBQQm?=
 =?iso-8859-1?Q?DNYQrl+4MHp5y8QNMwyQ9u3A1h+tvJl4pEfsByDXQEiwhNvPxClTRJKOX5?=
 =?iso-8859-1?Q?Qvhi63x8HBo1cAO/yMqzJFLmRozq3WAR7JPxzwQC8T6GBsA1xAitBohsPw?=
 =?iso-8859-1?Q?MHh1A52Izp50V+RcAlYHRGuoSZvr/vdzodj9XJ4fWcz6sG2CYQ/FJ08FgP?=
 =?iso-8859-1?Q?sdPYwp+0Zus5IUPyS+f310ptssHyFh19lg4o7ogqwPKGNmezxqCATG3Y1S?=
 =?iso-8859-1?Q?Qjg0ABJoX/J5TGghXJjZHvTlL+5uTFyGYjpc1mB9yycrZCPXxgcg5U+0+x?=
 =?iso-8859-1?Q?spmTk0cGKW/YP0rJwOM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b4bcce72-7e1a-4d12-7e3e-08dbd4739895
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 09:28:35.2197
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fwxgddNRO8Vklecefk2liXpsj2E/TkuVAwIlykwKgdPNwYIMEHBE6LFV5v1iik/2OejFJvCs5i4l6agdp+GrlUt4VlHYK39AeiWK3Ratjr4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5162
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 24 Oct 2023 02:30:10 -0700 (PDT)

On 2023-09-14 at 17:21:20 +0000, James Morse wrote:
>diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
>index 42b9a694fe2f..be0b7cb6e1f5 100644
>--- a/arch/x86/kernel/cpu/resctrl/monitor.c
>+++ b/arch/x86/kernel/cpu/resctrl/monitor.c
>@@ -150,12 +150,29 @@ static inline u64 get_corrected_mbm_count(u32 rmid, unsigned long val)
> 	return val;
> }
> 
>-static inline struct rmid_entry *__rmid_entry(u32 closid, u32 rmid)
>+/*
>+ * x86 and arm64 differ in their handling of monitoring.
>+ * x86's RMID are an independent number, there is only one source of traffic

"are an independent number" -> "is an independent number"
or
"are an independent number" -> "are independent numbers"?

>+ * with an RMID value of '1'.
>+ * arm64's PMG extend the PARTID/CLOSID space, there are multiple sources of

"extend" -> "extends"?

>+ * traffic with a PMG value of '1', one for each CLOSID, meaning the RMID
>+ * value is no longer unique.
>+ * To account for this, resctrl uses an index. On x86 this is just the RMID,
>+ * on arm64 it encodes the CLOSID and RMID. This gives a unique number.
>+ *
>+ * The domain's rmid_busy_llc and rmid_ptrs[] are sized by index. The arch code
>+ * must accept an attempt to read every index.
>+ */
>+static inline struct rmid_entry *__rmid_entry(u32 idx)
> {
> 	struct rmid_entry *entry;

-- 
Kind regards
Maciej Wiecz?r-Retman