Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
References: <20231023103852.28743-1-m.muzzammilashraf@gmail.com>
In-Reply-To: <20231023103852.28743-1-m.muzzammilashraf@gmail.com>
From:   Muhammad Muzammil <m.muzzammilashraf@gmail.com>
Date:   Tue, 24 Oct 2023 14:48:28 +0500
Message-ID: <CAJHePoZzMagaTLdRqmisgKx5arvm_YujyefzeCku1=ETPHWLVw@mail.gmail.com>
Subject: Re: [PATCH] include: uapi: linux: iommufd.h: fixed kernel-doc warnings
To:     jgg@ziepe.ca, kevin.tian@intel.com
Cc:     iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi all,

Can anyone review and approve this patch?

On Mon, Oct 23, 2023 at 3:39=E2=80=AFPM Muhammad Muzammil
<m.muzzammilashraf@gmail.com> wrote:
>
> Fixed multiple kernel-docs warnings
>
> Signed-off-by: Muhammad Muzammil <m.muzzammilashraf@gmail.com>
> ---
>  include/uapi/linux/iommufd.h | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/include/uapi/linux/iommufd.h b/include/uapi/linux/iommufd.h
> index 50f98f01fe10..2211f1b53d6e 100644
> --- a/include/uapi/linux/iommufd.h
> +++ b/include/uapi/linux/iommufd.h
> @@ -419,7 +419,7 @@ enum iommu_hw_info_type {
>  };
>
>  /**
> - * enum iommufd_hw_info_capabilities
> + * enum iommufd_hw_capabilities
>   * @IOMMU_HW_CAP_DIRTY_TRACKING: IOMMU hardware support for dirty tracki=
ng
>   *                               If available, it means the following AP=
Is
>   *                               are supported:
> @@ -486,6 +486,7 @@ enum iommufd_hwpt_set_dirty_tracking_flags {
>   * @size: sizeof(struct iommu_hwpt_set_dirty_tracking)
>   * @flags: Combination of enum iommufd_hwpt_set_dirty_tracking_flags
>   * @hwpt_id: HW pagetable ID that represents the IOMMU domain
> + * @__reserved: Must be 0
>   *
>   * Toggle dirty tracking on an HW pagetable.
>   */
> @@ -499,12 +500,12 @@ struct iommu_hwpt_set_dirty_tracking {
>                                           IOMMUFD_CMD_HWPT_SET_DIRTY_TRAC=
KING)
>
>  /**
> - * enum iommufd_get_dirty_bitmap_flags - Flags for getting dirty bits
> - * @IOMMU_GET_DIRTY_BITMAP_NO_CLEAR: Just read the PTEs without clearing=
 any
> - *                                   dirty bits metadata. This flag can =
be
> - *                                   passed in the expectation where the=
 next
> - *                                   operation is an unmap of the same I=
OVA
> - *                                   range.
> + * enum iommufd_hwpt_get_dirty_bitmap_flags - Flags for getting dirty bi=
ts
> + * @IOMMU_HWPT_GET_DIRTY_BITMAP_NO_CLEAR: Just read the PTEs without cle=
aring any
> + *                                        dirty bits metadata. This flag=
 can be
> + *                                        passed in the expectation wher=
e the next
> + *                                        operation is an unmap of the s=
ame IOVA
> + *                                        range.
>   *
>   */
>  enum iommufd_hwpt_get_dirty_bitmap_flags {
> @@ -521,6 +522,7 @@ enum iommufd_hwpt_get_dirty_bitmap_flags {
>   * @page_size: page size granularity of each bit in the bitmap
>   * @data: bitmap where to set the dirty bits. The bitmap bits each
>   *        represent a page_size which you deviate from an arbitrary iova=
.
> + * @__reserved: Must be 0
>   *
>   * Checking a given IOVA is dirty:
>   *
> --
> 2.27.0
>