Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1787294rda; Tue, 24 Oct 2023 03:22:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHqGSYRd0ZQoA5kkz2cagWRswPDzVpGcdlxj6yOdZo8Dc1XEjGHaIF3H566M4HOvG8uBEdv X-Received: by 2002:a05:6a00:cd5:b0:6bc:62d0:fff6 with SMTP id b21-20020a056a000cd500b006bc62d0fff6mr12881348pfv.32.1698142947912; Tue, 24 Oct 2023 03:22:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698142947; cv=none; d=google.com; s=arc-20160816; b=b2Xe98giIVtt+ZO/7xhItZtNMT64iST/oN9nGh0RUD6K13IoMELGNCpXmiTBIaTyg8 OQ+oM710808BCMFnH8BpOWoX4VhejlgToki2Uwe1rYiFVJe/mxByZir1cSHr4DUgETb1 JnSuicGn5Zkj1w3d+nzZej4eQZxHzxzEvFw+OcsuO+aG2dcF2BZrIpLLT7Vr0kIha5/e GCjN51mXxWbIM2Qsbox+xWyMVU4p/lh0tR+ayi/XM+W+Ywj5wCne0x6YRR2zqupx6Uxs zhrTt+zxDNBtyFhFgvnY6wjpU7E+Pg4MdsceEohAhy3cBIjf0eewJ+zBi85giUvquQJN Oi0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Uqc8OXXXeNecYleL3qBvPMduF+02uLZ5OhZHFSN9S2U=; fh=Q9pt1CsLvc3BJ9EhBT6sPzp1Y8GoQAWBgLgLDDtlJMo=; b=AvUWsOWfE2Zrypayn3YehOIOmKLIrW9EYxY4PKJDmBp4pqNQAQPArYkHE/LvPPtmZ6 vP6Jv8tylJB11umyQBnJ+eCY5mU6jf2Q4cP4gNa1ZfvrKvB7yTp81VE7+KmbvBvukaUR MxQzxIoDn8gGBEHJYKN3IPNzQahYPmMSgRz39G3OCAg9Mf0K5ejEVqeOoluwnxMq2d4Q A6jnjTaIXC8hUCH5dX4ko1npg7Cpxe1NTbvCPCfznps0xzmm4yPbajh+WaCqRxyYa3WE uhFTqui9krw4St8ggwYsTKWWJLAIRdDiF+AKc0Kt+Mv5cxfBruZb82Vr2xVvUQzw7plE 8B8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id u13-20020a056a00124d00b0068e256c6366si8413992pfi.352.2023.10.24.03.22.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 03:22:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id A3650804C64D; Tue, 24 Oct 2023 03:22:25 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234316AbjJXKWR (ORCPT + 99 others); Tue, 24 Oct 2023 06:22:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234186AbjJXKWR (ORCPT ); Tue, 24 Oct 2023 06:22:17 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C60BCAC; Tue, 24 Oct 2023 03:22:14 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qvEXx-0007XI-Co; Tue, 24 Oct 2023 12:22:01 +0200 Date: Tue, 24 Oct 2023 12:22:01 +0200 From: Florian Westphal To: Yan Zhai Cc: netdev@vger.kernel.org, "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Aya Levin , Tariq Toukan , linux-kernel@vger.kernel.org, kernel-team@cloudflare.com, Florian Westphal , Willem de Bruijn , Alexander H Duyck Subject: Re: [PATCH v4 net-next 1/3] ipv6: drop feature RTAX_FEATURE_ALLFRAG Message-ID: <20231024102201.GB2255@breakpoint.cc> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 24 Oct 2023 03:22:25 -0700 (PDT) Yan Zhai wrote: > #define IPCORK_OPT 1 /* ip-options has been held in ipcork.opt */ > -#define IPCORK_ALLFRAG 2 /* always fragment (for ipv6 for now) */ > +#define IPCORK_ALLFRAG 2 /* (unused) always fragment (for ipv6 for now) */ Nit: Why not remove the ALLFRAG define as well? Otherwise the series looks good to me, thanks! Reviewed-by: Florian Westphal