Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1803545rda; Tue, 24 Oct 2023 04:01:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHnAeSXLzMFWxDWO01Hm0FYRmWNq23dHh2lqO6UVzX1WUfX4kXyxDkXgeZrEsdVShZ2x5QR X-Received: by 2002:a05:6358:c30f:b0:168:dfe8:5bcf with SMTP id fk15-20020a056358c30f00b00168dfe85bcfmr5281113rwb.27.1698145288726; Tue, 24 Oct 2023 04:01:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698145288; cv=none; d=google.com; s=arc-20160816; b=fAtdtrTmLTU+5AGZgBl37mzCYYwd9dLhwtv9EtK6AVMR3GBy5VpWTQKKqtDhN5hO+j pTax7lZRMCRRElafy0D1gZEYUtV4HhS/R0kXDVUekDzIn+bA8Iy+dAYlITwpFmdCQl+2 fDk05GqUj7/FL6Mzugp2vcf/jHfz5WsEGxClhQK2xwYPbybnZVQP3F5FNe+U8LHlpC+Z toF48snvGlXIH1t6gMWvMJ40H9DjI410ce96QJ2EhSvAJMfAnLfAxYLaq/6eDN+VtiBs FLpeXUx4QdtkfPkSUbw3jLZZwvaw6BEM5YBpQtuhofNl+OZS1InagUV4WhkrVyhK8vLl Pe3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=jFGyAVlDVVGoiAlGbLmARWYgXdNddG/kge0e8dk2uuk=; fh=PPX3xnFdeDk0qnPwsINjDtNNnyKyBK2DD5QP/IAYhRQ=; b=wlmXW+K4hy7toXL6pZysKgzeglJsGpLdoTQ/NkRQStPNBNMSsxA+S3exZU/wsUtose i2HEU6HIzebi6+w/DFDYN8WERGWlzYKw75Inhkh4D6EKhBTZE7TX3ZF/qE20L+slg7Pf R1AMT0o8cJkt31c+KmypfaE32AHJb71dcRIZ+LpXraK+31jj9kKPETc97MEM5zauMdXV 7H/yrXtz9mtaLNij3ELJvMtNEMClYsRM3vHDYI3Wkgim0ebPEtAK4Q0DgIwnYCCDOqxw wjuWK1ZqWdW8v9dObr9jXOqjKYGvRSsXKFbuH6MzFJGFn6+2EPTL9sCX/RaARDtix/Vg Perg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=OVTqXZ9p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id r11-20020a63204b000000b005aa46216af6si8018454pgm.719.2023.10.24.04.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 04:01:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=OVTqXZ9p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 668888041C2A; Tue, 24 Oct 2023 04:01:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229629AbjJXLBL (ORCPT + 99 others); Tue, 24 Oct 2023 07:01:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229795AbjJXLBJ (ORCPT ); Tue, 24 Oct 2023 07:01:09 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AD8712C; Tue, 24 Oct 2023 04:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698145267; x=1729681267; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=75KjUTqZS/fnnT7oRhWogkQjn6g67+ZS64Oru9+MmVU=; b=OVTqXZ9pp95xjiBXRzhrbaV7HNWBCvOGuY24b7tfKXFGm1sCQWg9bzb7 2aooeQKN3o3ImrclTd9wZ5UT80sLLYDtWENwfFscV70fbyFSlNLI4HAbT nG3D21rVAlmfLhx364LaluN8VtE9NE3kNT+2jSZvwmWzjMkSJAJYUkyEf trwLe6qbVUBLpCUiu0be35wq5gN2Cd8WwQgKMgaOwvDEjFzBOpgb8mSkE REW8B7YLG8o/J17L/DOLfsuz9j1+erfv7Logx0vqXWGmiyiHkHa7kYHTB 56lykVIcR3Uud24GvGj/422LDaYNLTqSRv1X0BAb2Sq1sy6d5f/v9zp4O A==; X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="453491329" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="453491329" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 04:01:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="875034670" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="875034670" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 04:01:02 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC2) (envelope-from ) id 1qvF9f-00000008Bp9-0sdU; Tue, 24 Oct 2023 14:00:59 +0300 Date: Tue, 24 Oct 2023 14:00:58 +0300 From: Andy Shevchenko To: Mika Westerberg Cc: Raag Jadav , rafael@kernel.org, len.brown@intel.com, robert.moore@intel.com, mark.rutland@arm.com, will@kernel.org, linux@roeck-us.net, Jonathan.Cameron@huawei.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com Subject: Re: [PATCH v3 0/6] Refine _UID references across kernel Message-ID: References: <20231024062018.23839-1-raag.jadav@intel.com> <20231024093010.GF3208943@black.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231024093010.GF3208943@black.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 24 Oct 2023 04:01:25 -0700 (PDT) On Tue, Oct 24, 2023 at 12:30:10PM +0300, Mika Westerberg wrote: > On Tue, Oct 24, 2023 at 11:50:12AM +0530, Raag Jadav wrote: > > This series refines _UID references across kernel by: ... > > drivers/pinctrl/intel/pinctrl-intel.c | 2 +- > > This pinctrl one is also fine by me so if Andy does not have objections, > feel free to add my, TL;DR: I had, but Rafael seems wanted your opinion. Whatever, I'm not preventing this from happening, but I still consider that the uid check for NULL in the helper should mimic the same logic as in acpi_dev_hid_uid_match(). That's why I asked to drop my tags from this series. -- With Best Regards, Andy Shevchenko