Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Tue, 24 Oct 2023 14:17:35 +0300
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     Christopher Obbard <chris.obbard@collabora.com>
Cc:     Sebastian Reichel <sebastian.reichel@collabora.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com,
        stable@vger.kernel.org
Subject: Re: [PATCH v1 1/2] clk: composite: Fix handling of high clock rates
Message-ID: <ZTenz66dqsdUfz1t@smile.fi.intel.com>
References: <20230519190522.194729-1-sebastian.reichel@collabora.com>
 <20230519190522.194729-2-sebastian.reichel@collabora.com>
 <c8befb46085c43e1d09f27709b90e92dbce52c82.camel@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c8befb46085c43e1d09f27709b90e92dbce52c82.camel@collabora.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Sat, May 20, 2023 at 08:57:16AM +0100, Christopher Obbard wrote:
> On Fri, 2023-05-19 at 21:05 +0200, Sebastian Reichel wrote:

...

> > -???????????????????????rate_diff = abs(req->rate - tmp_req.rate);
> > +???????????????????????if (req->rate >= tmp_req.rate)
> > +???????????????????????????????rate_diff = req->rate - tmp_req.rate;
> > +???????????????????????else
> > +???????????????????????????????rate_diff = tmp_req.rate - req->rate;

Btw, we have abs_diff() helper for this kind of cases.

-- 
With Best Regards,
Andy Shevchenko