Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <20be5bf2-13ad-df49-174a-b9c0e68b8efe@oracle.com>
Date:   Tue, 24 Oct 2023 12:51:47 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 4/4] io_submit.2: Document RWF_ATOMIC
To:     "Darrick J. Wong" <djwong@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
        martin.petersen@oracle.com, david@fromorbit.com,
        himanshu.madhani@oracle.com
References: <20230929093717.2972367-1-john.g.garry@oracle.com>
 <20230929093717.2972367-5-john.g.garry@oracle.com>
 <20231009174551.GF21283@frogsfrogsfrogs>
Content-Language: en-US
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20231009174551.GF21283@frogsfrogsfrogs>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkVWc2NkZ09nUk1FK1FPaHFzQXpGcFE3c3BWWUNRWkt2dkxlbXcyZmNWMTFr?=
 =?utf-8?B?M21UUkV2SXd1Tk1kSlhPYVdhcEQ0bjd0M0ZrdkdnUFpvQUlER21pNmFPL0Rq?=
 =?utf-8?B?UFZKNGZYRjRmTFdZdlZBQ0dLOWZNSnR2UGlQdTMwSStZWU1meUtxUlRqNmpv?=
 =?utf-8?B?SE9XM3YydTFXUitiekh3Y0oyS2k1UWxncDkwa1A5UUdETlF4ZXRiKytQKzk3?=
 =?utf-8?B?UWJkR2ZpK0FpcE9NRCtGTlZuRXVrSDdCcmtJeTBETXYzTWhKM0cxaGM3eUd1?=
 =?utf-8?B?V2hYOGhNazBvS0Y1aUhYR09hYml1QlBrNGRBWDRJT1cwRzY1R1JsOUFXRFR2?=
 =?utf-8?B?b25zQnU2VnNEQjhJc1dOVjRjdWx3TDRkUmY3bFFPNGlQSVlJbU1DODFTNkV0?=
 =?utf-8?B?R04vVDRwaVdhVzhRNVZpUWJlUFQ2Z0tsMEZOT0ljdU4rb3Y4QkF2eTZnVm5T?=
 =?utf-8?B?Y2t3SDY5MVd4N1c0d085eTFWTlpHRWYzQkFUa0hQY05iK3locU95Rzl4dUhJ?=
 =?utf-8?B?djlHOGZaLzhKTFFsaC9qdlg4YXF3N2lMSzNEbjdYMElKU1ptWDhIelh6QlJl?=
 =?utf-8?B?dDFQbWxuL2RsaU82SUk0MUYrSEY5TTBDV1UxeTNlVnVsWHBSS3F2dVJMM2tq?=
 =?utf-8?B?cld0QTJQa0xXZUtjUk5jeE10bU9XdWp3ZEFxMEM2UTlySHNjSTh0Q2VFbHQx?=
 =?utf-8?B?RHhrM3FVektXNUZEclNCUlVFalhYc2loUWlldnY1ajFMYVdqT0RYNWhRSmVK?=
 =?utf-8?B?NnRCM0RsRTN6S3BNTHIrR25PcUZPL2lxRzRFNEVkOUZzR2JSazhjRmV4QS9h?=
 =?utf-8?B?eXJFSk9YZ2haR3RsYVBYQzZ3Mmk0dDRWSS9lNnl6SmZ3NzNaVU1DOWlabEtZ?=
 =?utf-8?B?V1NNek9BbGlaQ2Jvb3lMSDZDOWFjOURSMEhERDdhY2pNSlQ3TXczcldzQXow?=
 =?utf-8?B?U3VHVHc5ZnYrY25mSno3STh1Skt1ZlNGanhJUVFjWTlOM09HK3NpK21pdXdL?=
 =?utf-8?B?Vk9OOWJRcXdPRENOb29temhGVDdVRTg2ZVBzTHljNGZmc3YzTWJBd2hEbjI4?=
 =?utf-8?B?WUZJN0thNjZwZ0d6eG5FQWlac3U4c2hwS2NMU1NxNm1nRkNpdERVQ3RydytR?=
 =?utf-8?B?eDhzVUNLMUJKNkVaeGVFNGF1eGhVdWVENE1qZWFGNkdCR0lzcERWMUsraEdq?=
 =?utf-8?B?cHA0QVprYzYzaVQ2dFY2WmF3ck5JOEFma1JCMnhTYlJhalF2WFo0cEJKTDJB?=
 =?utf-8?B?N0NDZVFYQzdSN3BnMForZVl5MmxQSlVBNmZZQnN4a052Q25mSXhxMW1XN2tM?=
 =?utf-8?B?aTNnQTkrTVQ2NENiUmtTU1NhaVFHa3lLUnBKWmhWZWY5RC9PVnVjWlhnOFZD?=
 =?utf-8?B?WjNxQjRjSUJFSVpoSzlHemhkajlUcEpScVB4S0llVklpV3BEQ3o1MW5FRFFq?=
 =?utf-8?B?QXgybU54dG5MM3doTzBlNFVUSktuRC9KdC8zZC9ZQU5KMEhvc2FLME8yWHVw?=
 =?utf-8?B?TW54TW9NV2JaR3BMamN0cHUrRzZIZS9nd0QycEFzdTNzZWFMeTdJVmhaVTBj?=
 =?utf-8?B?aGtvOGNNb1B6UmVxT3RsZUNURGZFeCtZRkgrQ1JjWTFDa1RxNUU4enpIeEYr?=
 =?utf-8?B?QnBNSWowazF5c1E5TE94Q1h0U0dXUEpmODRlK3RtZzZnVDV0Q3UydWo5MEIz?=
 =?utf-8?B?S3p5ZDZFa1hxbHg5Mjl3eGkyWmx5RkJFZHJkMEZVNEVDWjRvTnZZTmcva2d1?=
 =?utf-8?B?N0prR2libDVQMlNNeTJ2MXUxL1NkNzNTQ2FtWFkra3JVVWtiMkQwZk56K3hp?=
 =?utf-8?B?cjROcTVKRkx1VkhvcHNkcjF0SWdSUlVmMmsvUVVTZTh4a3JUMXNPQk5wR3JT?=
 =?utf-8?B?WGhaWlZ1eEtkSkhJTVpGUVArU1dDWTFqcnVJVVgyMzF0aExXeUx5QlpYY1ZI?=
 =?utf-8?B?a1BwcG8wd3VteEt5S05KNWhnN3pJd3E5MDZpVFFDaDR3SDM4K1VVLzNZc2ZB?=
 =?utf-8?B?RzNjYm9TcG04cTNIRjZxOWc3aEExR2N0WXJ6SHpkYWNKYXdWL1dwalFSbXNM?=
 =?utf-8?B?UVg0dXFYdXc2Vm44SWV6Rkx2cUlkUyswTU9iR2FzSkZ5WjRYN1F4MG5BUllv?=
 =?utf-8?Q?QXZIVWLRaRYa5/EeRxyK8jpKk?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: HMlK0TCzyL60TGoZeX9fCCtfC81RbxZbEAenUXd0z73WuYzXPxVBEhGaxqL7i1ndbbQtoUPUq1Rt8iu6O6DE+u+fqEqp2KSoa+G6SKVWXxjDJs03Egqc64NYuiMyVN8ysZwsQBvMFGjhC2rOFanuIMxAv7GdXISyi6vjrIklfdc4ZSkgmapJIBH1xCG7U3hvlFkhESpP4dsCmN8N9gontl/K7SOhWT0f9/BUNEGVAcMjt4IRI2PbgRS0ihd95p0YFo7z1tMq9yLcOJcqCuSdDEugJ9Lg85QhrME46L/NUbVaFxVOvzGHZrmmmq2C+dE+umA2aZGwl5JGOB/5Tl+k/b9hC3BuLtQXED6YaEcSyoC6srUWpc925V2h2m0aZtTumRSKtk2zVRlm58SNNpQN5ZebS8O0RmCD659onCAcOQEOrSoMkKgQ5jExeXhrJzTBzKOw3faDq+PKPPlbRvK1nH7fm49YlF50bmsOtIaK0VREyKNak0SkiPaPaeVzkvZIMgsodCFT5jIHIpCcC3VId7eFiCAI2kijlTvSDdhCcQniNBAV1yKPwUKjM+9PWUcKuRROKN2tbMZjVFI2R3nGXXV7SCRZsMBEPA/rhKRy7elbJoQKEQyW2v51vkcOdtNNWJaI1IavjE8QT0xZNraEsjJHJrom3badlPovLEPzBXT+FAc5v2cIPUv8UZcX8jEsDgQexwUHU9Z9TwiMcWnXT4xwNxYEdzjpHk4RZRsceld7IT43W5EeF6OygGbMo2wecWeP9U3H2PzwE6nOfVwcsW06sPpRb7Df0S4KzkRI5KdMCr7B/Gm+Jk3tSB0s863N3vVjkaIMtovaumrju8nGXg==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1573557e-3b02-4e3b-2bd4-08dbd4879c28
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 11:51:51.1251
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S6Mu6jPyFljDjd+GofIhiiR5lRwnK7ICG7ckUKJ+53pdfkRwsno9rNkf6tmXJjIpExV12WaMCSGxk4f9Z5+dXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB6819
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-24_11,2023-10-24_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 phishscore=0
 mlxlogscore=999 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310170001
 definitions=main-2310240100
X-Proofpoint-GUID: dLNw0F7kPWEs1NCvv29MUSoad08o4L0s
X-Proofpoint-ORIG-GUID: dLNw0F7kPWEs1NCvv29MUSoad08o4L0s
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 24 Oct 2023 04:52:10 -0700 (PDT)

On 09/10/2023 18:45, Darrick J. Wong wrote:
> On Fri, Sep 29, 2023 at 09:37:17AM +0000, John Garry wrote:
>> Document RWF_ATOMIC for asynchronous I/O.
>>
>> Signed-off-by: John Garry<john.g.garry@oracle.com>
>> ---
>>   man2/io_submit.2 | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/man2/io_submit.2 b/man2/io_submit.2
>> index 1030bb6cd965..beba8865ac2a 100644
>> --- a/man2/io_submit.2
>> +++ b/man2/io_submit.2
>> @@ -140,6 +140,11 @@ as well the description of
>>   .B O_SYNC
>>   in
>>   .BR open (2).
>> +.TP
>> +.BR RWF_ATOMIC " (since Linux 6.7)"
>> +Write a block of data such that a write will never be
>> +torn from power fail or similar. See See the description
> Nit: Double 'See' here.

A bit more than a nit, it's something that needs fixing :)

Thanks,
John