Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1835550rda; Tue, 24 Oct 2023 05:03:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+lwe9nUrGRfpqu/XbuEHcq547kPYitPpE8x6frfovd/opAPv+DdnGFRrlhLAftOC3Fsbf X-Received: by 2002:a17:902:e5c1:b0:1c6:ec8:4c67 with SMTP id u1-20020a170902e5c100b001c60ec84c67mr9094146plf.18.1698149037071; Tue, 24 Oct 2023 05:03:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698149037; cv=none; d=google.com; s=arc-20160816; b=HHeyZnO+jhyreGg0H+CPzeumCYV784OOleU/I/kXjf6shqKJrm89E65RhlT8Z9sysV ZpSPGCKvXrJvEnImzIcpuGVdcRNcZ6dz2PdJgDR1DvKwAnA3hZ4/1ZOtbDpnhJptT1z6 SXjh85BKkYg6KECoRaarodkBrQdvJs3UG0m9mqdUUWNkrLQddLzub1JGxYNDIMGZL9k2 vzFoDjF7wXzrsipEjkIP8zagvJKMmXz5+IEn48ULZ1aX4ge1dKw1r83WbQKPfAkAMEaY QYsoaBEqZZr1D8iLN2bkPUZryoe5F2hyvwjHKVPw4bCpUEP0E5NAefvaBR7jzWTP71a0 xmVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zRIi9/LubZwPopqf6kr3BLpCYi15YnR3163PaROLkPc=; fh=XUDcLP3fA0mJDBycD9oZ96275xVLGq/zjMAiYmRla8k=; b=sXJH0+1Wljvnz21wfcEHL8dDnuQn+jjEivkt2XV8mNC9dOUxKWBhoRj2v7ceE+JndI NiPusrFkDJIDGT4mkuzek/nvT0S7oo+obOjkx095vwyXx+rR42m0FeqMLm+zRDjEBFYt zJn0qiHwPStP+QEBVBQrtArOz1r+C54b/3xydMjklc5BfMlsiNLJmZKA+fwEn3wl/Jn8 lLFj5m6Uz+Q2qTyNSyGX5EVL7QkFjSmdXlfxNfTelRYHUalmegKT9zbl3h4JuSB+Aqu9 Gg7blNR+6CWQ+R+4Wvl1N1AZKk7zXNeVxIbFdGTPPrQNlV0iLcj2kOJQPy7NxsJzd59b kong== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernkonzept.com header.s=mx1 header.b=mTYVwfkd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernkonzept.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id b7-20020a170902a9c700b001ca85b89407si8038875plr.106.2023.10.24.05.03.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 05:03:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernkonzept.com header.s=mx1 header.b=mTYVwfkd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernkonzept.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 82C11802FA6E; Tue, 24 Oct 2023 05:03:36 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233700AbjJXMDd (ORCPT + 99 others); Tue, 24 Oct 2023 08:03:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232469AbjJXMDc (ORCPT ); Tue, 24 Oct 2023 08:03:32 -0400 Received: from mx.kernkonzept.com (serv1.kernkonzept.com [IPv6:2a01:4f8:1c1c:b490::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 352D3F9; Tue, 24 Oct 2023 05:03:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kernkonzept.com; s=mx1; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:Reply-To: Content-ID:Content-Description; bh=zRIi9/LubZwPopqf6kr3BLpCYi15YnR3163PaROLkPc=; b=mTYVwfkdKLTHhanJB6iXTcGdRN B4MGvwjKxtEHB9ISxJYLjUPkavsTwTRNUl+/dYaX8yIOwuQxB7l9Np7qR13iLSaKKHdBO0cJGkzd1 z6+PwxU6TURDYTmHgLz9xsIBJxXlfBQgwSXCjAnQCaj8RjJi041unbBCCgvcs1T7TkzE9Wz6bzxHq 5A9yH8mOT1hmHimnZy+WkCoU6cMmRgZ7sQtnjBzlPfMGk/4pXLyTnc+pcMVGqBAVPL2M/8TqlOFup z99GPSxcLYXAtUlrlJtsa3F9kVjgZilmYOJEo5yezpZXCs/tExSS3HRS4iPEy1l70zpPHHtUetTZu SMl1I8Mg==; Received: from [10.22.3.24] (helo=kernkonzept.com) by mx.kernkonzept.com with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) id 1qvG83-000jUo-0O; Tue, 24 Oct 2023 14:03:22 +0200 Date: Tue, 24 Oct 2023 14:03:17 +0200 From: Stephan Gerhold To: Ulf Hansson Cc: Viresh Kumar , Andy Gross , Bjorn Andersson , Konrad Dybcio , Ilia Lin , "Rafael J. Wysocki" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Stephan Gerhold , stable@vger.kernel.org Subject: Re: [PATCH v2 2/3] cpufreq: qcom-nvmem: Enable virtual power domain devices Message-ID: References: <20231018-msm8909-cpufreq-v2-0-0962df95f654@kernkonzept.com> <20231018-msm8909-cpufreq-v2-2-0962df95f654@kernkonzept.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 24 Oct 2023 05:03:36 -0700 (PDT) On Thu, Oct 19, 2023 at 01:26:19PM +0200, Ulf Hansson wrote: > On Thu, 19 Oct 2023 at 12:24, Ulf Hansson wrote: > > > > On Wed, 18 Oct 2023 at 10:06, Stephan Gerhold > > wrote: > > > > > > The genpd core caches performance state votes from devices that are > > > runtime suspended as of commit 3c5a272202c2 ("PM: domains: Improve > > > runtime PM performance state handling"). They get applied once the > > > device becomes active again. > > > > > > To attach the power domains needed by qcom-cpufreq-nvmem the OPP core > > > calls genpd_dev_pm_attach_by_id(). This results in "virtual" dummy > > > devices that use runtime PM only to control the enable and performance > > > state for the attached power domain. > > > > > > However, at the moment nothing ever resumes the virtual devices created > > > for qcom-cpufreq-nvmem. They remain permanently runtime suspended. This > > > means that performance state votes made during cpufreq scaling get > > > always cached and never applied to the hardware. > > > > > > Fix this by enabling the devices after attaching them and use > > > dev_pm_syscore_device() to ensure the power domains also stay on when > > > going to suspend. Since it supplies the CPU we can never turn it off > > > from Linux. There are other mechanisms to turn it off when needed, > > > usually in the RPM firmware (RPMPD) or the cpuidle path (CPR genpd). > > > > I believe we discussed using dev_pm_syscore_device() for the previous > > version. It's not intended to be used for things like the above. > > > > Moreover, I was under the impression that it wasn't really needed. In > > fact, I would think that this actually breaks things for system > > suspend/resume, as in this case the cpr driver's genpd > > ->power_on|off() callbacks are no longer getting called due this, > > which means that the cpr state machine isn't going to be restored > > properly. Or did I get this wrong? > > BTW, if you really need something like the above, the proper way to do > it would instead be to call device_set_awake_path() for the device. > Unfortunately this does not work correctly. When I use device_set_awake_path() it does set dev->power.wakeup_path = true. However, this flag is cleared again in device_prepare() when entering suspend. To me it looks a bit like wakeup_path is not supposed to be set directly by drivers? Before and after your commit 8512220c5782 ("PM / core: Assign the wakeup_path status flag in __device_prepare()") it seems to be internally bound to device_may_wakeup(). It works if I make device_may_wakeup() return true, with device_set_wakeup_capable(dev, true); device_wakeup_enable(dev); but that also allows *disabling* the wakeup from sysfs which doesn't really make sense for the CPU. Any ideas? Thanks! -- Stephan Gerhold Kernkonzept GmbH at Dresden, Germany, HRB 31129, CEO Dr.-Ing. Michael Hohmuth