Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1838268rda; Tue, 24 Oct 2023 05:07:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGYMuKr4ZVQqp48NlJtoFALjJ5OrNCaqVRzbnX5HM3k5CX/fvmZghjGlXkQZLO4r7jCgwZ8 X-Received: by 2002:a17:903:1c1:b0:1c3:bc7b:8805 with SMTP id e1-20020a17090301c100b001c3bc7b8805mr10916977plh.52.1698149268379; Tue, 24 Oct 2023 05:07:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698149268; cv=none; d=google.com; s=arc-20160816; b=Vt69gNmkt9xQ2FGxSzt1B5u8si1naMxSUZZji5B8MwRTS32gdvUUDxn9d5xgXpa83m SM0F+n6FqBW+VTJrV7kJ1hMZqiEWVN93J8Xtc72K6uM6TrlNO5RJAveap9Np3v9IwMeV 8h3Q2bHEFBzWTUJCeqsxvSaCEHh6BI3wf6tM8B2vyjQlMs87b9Zv3P1Z657n6/zf13pb qkO1iaJUrYDH7dbnWh4G/w8hwvrL3NHCLm+qRoV9VmXwokwrSh47W1JIqkQfumvTZ4gF nhotFtahb/Q8eadQ9WXxRHT4t5BS3gRRzh7T4oyeRifW6eO+itOHwanwK6rxIitROnDV hDog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=fnbQ6Q2EDEmeDrsBAt+FskdauroAd8IioN5ZwkR9W1E=; fh=0IdDkdWGAAyBV3hpsFakHjjOl2KkJ4A5Vw30Maf9xCI=; b=xQJFtCSh9FoN6bC16ub3qELeuxyf7lI3dm+PVlNc6DJm73D0tWN5ypKH/DtPpC4kj2 ev74ZOZBTNbiJGswq2u5befbT2wzom/tRIF9xqgrHP8cLTj5wea07KOXo8jPU9ZFRW8c dpKFS0+93tYfPcFTm0L5eoEDRbv/6/6F3q70sEpQlA5ehxjlOdk2+mxhOgVpxfIH8Cb0 wZVrvLpiANNw+UnMQ2Y+yrSrBNOAXLGxVSlXQbtT/zK9doGS1ZAZo93NCGVY811qdG4x nJkrKmOtOw4o/VUSSRC1xXjyD/SgkrcUDMElFn19rIGbY166wvTxPI1sYhV5r4Imyqcv 4m5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=Z8ToVP4Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id e10-20020a17090301ca00b001c9bc844534si8685612plh.430.2023.10.24.05.07.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 05:07:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=Z8ToVP4Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 421368034635; Tue, 24 Oct 2023 05:07:44 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233874AbjJXMHd (ORCPT + 99 others); Tue, 24 Oct 2023 08:07:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233866AbjJXMHa (ORCPT ); Tue, 24 Oct 2023 08:07:30 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B85ABD79 for ; Tue, 24 Oct 2023 05:07:28 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-6b9af7d41d2so3662255b3a.0 for ; Tue, 24 Oct 2023 05:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1698149248; x=1698754048; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fnbQ6Q2EDEmeDrsBAt+FskdauroAd8IioN5ZwkR9W1E=; b=Z8ToVP4YdGc/2ZIa7dKHtDbq3o5iYB93FcJ955m/jR+4ZFG9BZ2pDVZOWevPLLIxLR 72Q00xewF8LcZybXSDwEK12lSPK7Z6UHFZFsCJsjtMOwuqN7MfnN7CphIVPa8P3BrHaP kakWlChh7qkQVb4Ak0+Rm6zAMHBjaXcLRg7X0prRxG9dGGvcInGW+Dg6RaAB+xRWygRq hgTqbaVLLI1nzUjBUNtoOgbkMV48SU3I4vkwAifvErV/HuRHG5NJOAm1kOuDMzzIVHOK gUyVWBQVVr5ZN51Fy2JYNJXYmzi6GCIB+DyBVXhMJ4gqDfOXfd0bBglXOeFkVaHM1Zyi 5v/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698149248; x=1698754048; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fnbQ6Q2EDEmeDrsBAt+FskdauroAd8IioN5ZwkR9W1E=; b=IzbG9rN1cjL3m/cIWbxIueAxBRI6ux8xDA6yOhJ7Bhdry0U8GWh2DJkhLgZpq2nSs5 PCso/BsTuWojLVcGorYzgnq0w9tndJXn679oQh3wpUiPlbdPe6bbUDRzT7fnnkpR/oJ1 KCeymnaOK4TvpQOkJCxySpGUdUTOvclMSRhcSk9LS6gL2+ZK4ztelxGbec5gVqV2xSNV oN+ykg9HVdTxpIT71AHWk5yRtQRqgMdGLNWkFgiTWur/Z9as4XbFFPXOOtF67RRlOx8R IGYGmyZdALgq6xTAiQFpFnbffUBUta+y1rhvfJwJOaUXZ+ZVYOoLtUX6vQ4/X9c7j7T3 JbnQ== X-Gm-Message-State: AOJu0YxUNAizEfBF8tXmzK3St7G3Fl6Ye/Z1LGbw4GhoP2+0PSk7W4ul oe4u7sXYKRAU8+Ot8zEUmV1LFdGLISfBKsZl75KHIg== X-Received: by 2002:a05:6a20:e109:b0:163:2da1:387f with SMTP id kr9-20020a056a20e10900b001632da1387fmr3054954pzb.50.1698149247695; Tue, 24 Oct 2023 05:07:27 -0700 (PDT) MIME-Version: 1.0 References: <20231023172800.315343-1-apatel@ventanamicro.com> <20231023172800.315343-2-apatel@ventanamicro.com> <87h6mgs09f.fsf@all.your.base.are.belong.to.us> In-Reply-To: <87h6mgs09f.fsf@all.your.base.are.belong.to.us> From: Anup Patel Date: Tue, 24 Oct 2023 17:37:16 +0530 Message-ID: Subject: Re: [PATCH v11 01/14] RISC-V: Don't fail in riscv_of_parent_hartid() for disabled HARTs To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Cc: Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Conor Dooley , Marc Zyngier , Atish Patra , Andrew Jones , Sunil V L , Saravana Kannan , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Atish Patra Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 24 Oct 2023 05:07:44 -0700 (PDT) On Tue, Oct 24, 2023 at 5:25=E2=80=AFPM Bj=C3=B6rn T=C3=B6pel wrote: > > Anup Patel writes: > > > The riscv_of_processor_hartid() used by riscv_of_parent_hartid() fails > > for HARTs disabled in the DT. This results in the following warning > > thrown by the RISC-V INTC driver for the E-core on SiFive boards: > > > > [ 0.000000] riscv-intc: unable to find hart id for /cpus/cpu@0/inter= rupt-controller > > > > The riscv_of_parent_hartid() is only expected to read the hartid from > > the DT so we should directly call of_get_cpu_hwid() instead of calling > > riscv_of_processor_hartid(). > > > > Fixes: ad635e723e17 ("riscv: cpu: Add 64bit hartid support on RV64") > > Patch 1 and 3: These fixes are stand alone, and doesn't have to be part > of the series. > > Wouldn't it be better to pull these out of the long-going series, and > try to get in the fixes ASAP? Yes, that is correct. In fact, PATCH2 can also be taken for Linux-6.7. I suggest PATCH1 to PATCH3 (3 patches) be taken for Linux-6.7 since the merge window is pretty close. Regards, Anup