Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1849330rda; Tue, 24 Oct 2023 05:27:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEvokP5a5VDkOVTbSjqmsSB/mejO61eodm2oBwDdZy2OOhPTA24i5Ul0rSnqty4bmKqH7H6 X-Received: by 2002:a17:902:f689:b0:1ca:4e1a:a47d with SMTP id l9-20020a170902f68900b001ca4e1aa47dmr14103945plg.42.1698150441645; Tue, 24 Oct 2023 05:27:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698150441; cv=none; d=google.com; s=arc-20160816; b=LvGNcNMjw6IAuGWyIJqhmR8a1gDJEaYv/t+cYedTfGurv2ZvmiNHp/ODePVS3Thl6K 9gKezhu7nW7PTDcB9El23f3HmHZ5pF9cumwF7u/yf8cBY16nzzEtHdUs5l9RhawqGgyr zH+xc4YXkfCw5FKfyQUVBg9wwWCkDcSPN90kRLdjiIrB1QrU/9H28/JQwFM7D29oYgto jL5jQL3GFe7pgerwwajcKrjCvQl9T7O5SXYheUWhLfknm8z/5We+RrqIHocFgpxNqiGK HqhsUhs3SKskfAkARxCSbpyygAp9j42tUI5N2biJoZxGDKJbkREhFzTdJ9t17Gd26mTE nxEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=B+Wa1ANo/dCC7Wkmm5U1BwIOwK/NkqVlAoV47F0Pyo8=; fh=Jp0xLgQDmcYeuNaALdIo6Yli6RGnCMF15gmwsEbIn2g=; b=VI0PzkLGjw4zeJupcl6r+L6Lij9xRyUn4zpMCrmaBnBH9qPk/G5h5hKwm7MrUw0szO D3mKpEq/CG5grE4moGlEfeQWux3/Pwl8AeT2lN4cZdz0rBLlrtaEzuKvA7i2PyVuxJQt P1Jo60Uf2urW1wf3fW5hLfU0QjTUL162exRnkDS2K8YSZKOK2c3flkwdhSagqESEX6/c P8mEVIFUaFLkEN5no7M0OQxGWueAqReb5pEbPEujA9R13pQdg4LtTnIUgYluK8NWRdI6 LlZJJiFDsT1my/+G7ue/uZFmrQBEH03v7OOK2MxuTsz3/5hqwUTjn/1sZd+WgSO7UdLX rG5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id 21-20020a170902c15500b001bf1005924csi8016904plj.321.2023.10.24.05.27.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 05:27:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 891908034638; Tue, 24 Oct 2023 05:27:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231849AbjJXM1M (ORCPT + 99 others); Tue, 24 Oct 2023 08:27:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231794AbjJXM1L (ORCPT ); Tue, 24 Oct 2023 08:27:11 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26731129; Tue, 24 Oct 2023 05:27:09 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4SFB7s0hkbz6K6Gt; Tue, 24 Oct 2023 20:24:25 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 24 Oct 2023 13:27:06 +0100 Date: Tue, 24 Oct 2023 13:27:05 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski CC: Ramona Gradinariu , , , , , , , , Subject: Re: [PATCH 3/3] dt-bindings: adis16460: Add 'spi-cs-inactive-delay-ns' property Message-ID: <20231024132705.00003cf4@Huawei.com> In-Reply-To: References: <20231023123542.582392-1-ramona.gradinariu@analog.com> <20231023123542.582392-4-ramona.gradinariu@analog.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500005.china.huawei.com (7.191.163.240) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 24 Oct 2023 05:27:19 -0700 (PDT) On Mon, 23 Oct 2023 15:22:30 +0200 Krzysztof Kozlowski wrote: > On 23/10/2023 14:35, Ramona Gradinariu wrote: > > Add 'spi-cs-inactive-delay-ns' property. > > This we see from the diff. Commit should explain: Why? > > > > > Signed-off-by: Ramona Gradinariu > > --- > > Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml > > index 4e43c80e5119..3691c0be4f9d 100644 > > --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml > > +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml > > @@ -25,6 +25,11 @@ properties: > > > > spi-cpol: true > > > > + spi-cs-inactive-delay-ns: > > + minimum: 16000 > > + description: > > + If not explicitly set in the device tree, the driver will set it to 16us. > > Why do you even need it here? Along side that, if you have a default default: xxxx rather than in the description. > > Best regards, > Krzysztof > >