Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Tue, 24 Oct 2023 14:33:57 +0200
Message-ID: <87ttqgurm2.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
Cc:     anton.yakovlev@opensynergy.com, mst@redhat.com, perex@perex.cz,
        tiwai@suse.com, virtualization@lists.linux-foundation.org,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        pbonzini@redhat.com, stefanha@redhat.com, sgarzare@redhat.com,
        manos.pitsidianakis@linaro.org, mripard@redhat.com
Subject: Re: [PATCH v3] ALSA: virtio: use ack callback
In-Reply-To: <ZTemo0P/kEcceK/O@fedora>
References: <ZTaMEUZUTrRRUD6y@fedora>
        <87edhlwd7b.wl-tiwai@suse.de>
        <ZTemo0P/kEcceK/O@fedora>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 24 Oct 2023 13:12:35 +0200,
Matias Ezequiel Vara Larsen wrote:
> 
> On Mon, Oct 23, 2023 at 05:50:00PM +0200, Takashi Iwai wrote:
> > On Mon, 23 Oct 2023 17:06:57 +0200,
> > Matias Ezequiel Vara Larsen wrote:
> > > 
> > > +static int virtsnd_pcm_ack(struct snd_pcm_substream *substream)
> > > +{
> > > +	struct virtio_pcm_substream *vss = snd_pcm_substream_chip(substream);
> > > +	struct virtio_snd_queue *queue = virtsnd_pcm_queue(vss);
> > > +	unsigned long flags;
> > > +	struct snd_pcm_runtime *runtime = vss->substream->runtime;
> > > +	ssize_t appl_pos = frames_to_bytes(runtime, runtime->control->appl_ptr);
> > > +	ssize_t buf_size = frames_to_bytes(runtime, runtime->buffer_size);
> > > +	int rc;
> > > +
> > > +	spin_lock_irqsave(&queue->lock, flags);
> > > +	spin_lock(&vss->lock);
> > > +
> > > +	ssize_t bytes = (appl_pos - vss->appl_ptr) % buf_size;
> > 
> > The variable declaration should be moved to the beginning of the
> > function.
> > 
> > Also, there can be a overlap beyond runtime->boundary (which easily
> > happens for 32bit apps), so the calculation can be a bit more complex
> > with conditional.
> > 
> 
> Should I use as an example `cs46xx_playback/capture_transfer()` which relies on
> the `snd_pcm_indirect_playback/capture_transfer()`? It looks like it
> does already that calculation.

Yes, using the existing helper is a good idea.
The only problem is that this helper isn't well documented ;-<


thanks,

Takashi