Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Tue, 24 Oct 2023 15:43:33 +0300
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     Tony Lindgren <tony@atomide.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Rob Herring <robh@kernel.org>, Dhruva Gole <d-gole@ti.com>,
        Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        John Ogness <john.ogness@linutronix.de>,
        Johan Hovold <johan@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        Maximilian Luz <luzmaximilian@gmail.com>
Subject: Re: [RFC PATCH 1/2] serial: core: Move tty and serdev to be children
 of serial core port device
Message-ID: <ZTe79akvB0OYwG3a@smile.fi.intel.com>
References: <20231024113624.54364-1-tony@atomide.com>
 <ZTe11rbKgcusPRD/@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZTe11rbKgcusPRD/@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Oct 24, 2023 at 03:17:26PM +0300, Andy Shevchenko wrote:
> On Tue, Oct 24, 2023 at 02:36:18PM +0300, Tony Lindgren wrote:

...

> > -	ctrl->dev.of_node = parent->of_node;
> > +	ctrl->dev.of_node = host->of_node;
> 
> Even above should have been using device_set_node(&ctrl->dev, dev_fwnode(host)).

...

> >  	/* Make sure controller and ResourceSource handle match */
> > -	if (ACPI_HANDLE(ctrl->dev.parent) != lookup.controller_handle)
> > +	if (ACPI_HANDLE(ctrl->host) != lookup.controller_handle)
> 
> This can be changed to use device_match_acpi_handle().
> 
> >  		return -ENODEV;

...

> > -	if (!has_acpi_companion(ctrl->dev.parent))
> > +	if (!has_acpi_companion(ctrl->host))
> 
> I prefer is_acpi_device_node(dev_fwnode(...)) check, but here seems no other
> use for fwnode (haven't checked the full context, though).
> 
> >  		return -ENODEV;

...

I have just sent a little series based on these comments.

-- 
With Best Regards,
Andy Shevchenko