Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1867452rda; Tue, 24 Oct 2023 06:01:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtOBr8MB3uJcqzlYVjNt/SHBExyEDJcFnQCkKuRYyGBNAiIuFkojH4w4NpJYgciQfNhloV X-Received: by 2002:a05:6a21:7983:b0:171:a2df:4e68 with SMTP id bh3-20020a056a21798300b00171a2df4e68mr1960854pzc.36.1698152495971; Tue, 24 Oct 2023 06:01:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698152495; cv=none; d=google.com; s=arc-20160816; b=GrUKzxiU69+U7MIAfOQ3FN/pcogyxYAN614anFrAdxX+6akWpgd3u0kfiXSUQfO/YC G2pYXLCbhMq19KeMixlWuLC4UpMeBVq0tR6hHsUv7M7apRUeRAAd9KB9mqRnWGDoBoTo Ds15vebvFy550rGGn41K4R+TpeLx3wCTdsHJ0lFYe1Oepts743D1ZMkuf8s76Rt4PF1A UETCG8xh2kYshA7mXbONYIMJ76TYR8vJLzKOY7Kx4ZIdmhUXdrhDNsHiNnwFyiNQ/8gN UBElFnVQuc/7gz1MX87T0nZ1F2kIdEdZej/OnB2S02U04gKQFUnsWbMWUjNRgcx4/W4v 0/sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=K9mkSvzL5AlqEqCk4gL6PQxVO/Ut1Am/gjPnbui/hZY=; fh=H1NS+mzJ7O0gT6jRTdGv4H9lWPMNAUjAD05e5Y2gScU=; b=VNCW2Zd5Qc/gFvDTLMMvQPXnRmfFbXIBPGYLVyCVMoBB4b/wM6+AyfSz5VdaNp+cPB SYMCDhW+b73AALJr7RrNYs3bJSehqcPqYgdEDtR960JzB9kJldUlgqIi4sxdQ6faDB6L zX0DEriGxCY5+Fy44QMLQWmxyDnOzf0mP7e5bT4+qfTareIOzyFKtklil4I7H6sxe1xo ljFvHlwQPYplRPCB4Ibnev8x+e9ihsvd5FJdA1KCoxuSikME4XCH/JKe8HJ7flDWcYXA sHlxFyS0ZmkimV4MMOUp3NSMMEs/jdkUJiCIdok8ndNbpUB0TdW2wbf7QW5N6wdvY8q/ 78Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20230601.gappssmtp.com header.s=20230601 header.b=iqQEM5+D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id k14-20020a62840e000000b0068e3f3c6250si8313253pfd.343.2023.10.24.06.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 06:01:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20230601.gappssmtp.com header.s=20230601 header.b=iqQEM5+D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 6B71A80401FA; Tue, 24 Oct 2023 06:01:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234503AbjJXNAy (ORCPT + 99 others); Tue, 24 Oct 2023 09:00:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234520AbjJXNAu (ORCPT ); Tue, 24 Oct 2023 09:00:50 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E336DD for ; Tue, 24 Oct 2023 06:00:48 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-507a55302e0so6017242e87.0 for ; Tue, 24 Oct 2023 06:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1698152446; x=1698757246; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=K9mkSvzL5AlqEqCk4gL6PQxVO/Ut1Am/gjPnbui/hZY=; b=iqQEM5+DZq6rYuXpysfHPdOjEbXqRzY492KBz3FbKcY1PZAHYtnqFDhri13UbyGkLt 9qMt8/4VtBKaoeFifAclx68R7mjIWG0ld1kf+xLkiZAoUiyeVTehC3qbBVIe+ZI5HN6g 6GSuRNHMsTLoD6kaEJOkjGKq20YO0PVEEqF9SNILOpslZ2FUZDSnIW1AQnXFbxVizKA7 HRPSFC7+/BOhKTA4rOe3CtH3OzY8OqZFhOQmW295bLsbrbqeqce0v6qYAfdS/tI7RIrM M06vk2cnSV7Ix3BNsXvryD6c/anf9JacFFn+zLyv8oS2zxKQuwh0qubEgj7ABIkFXQlf w3uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698152446; x=1698757246; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K9mkSvzL5AlqEqCk4gL6PQxVO/Ut1Am/gjPnbui/hZY=; b=uweDJGEO/2j18iHJo+m8irybMwD68V60T+HA9VBdZ7SGFBVXtuAgXMvU0y8lwnNIvH Y8EQgmZrHtR12VMqptHWhxT8o0PB9azkcOR4qJbThsINt//Ikjg+z7xqhMAXVpL3eqrk tqtnb7QICZbe6Qoc451BB7YyBIyyvJuydiDdl1Lt7+eolNbJ9Etj4KPv03lbkNXTJ7xh 4195jkDxwZL2gEfPy1YFtN+ZxKQHb7E+R1hUfrg2c+zh10CtUZonzz/CS3SIqyzjLk1x Oxg5ShgemmY4zO+wrGQft/ocTs7psR3AFlXUQZk6EjjTmmXQ1exTdQi/adDOeLuGnGp/ AjYw== X-Gm-Message-State: AOJu0YyH8b2J4vEHKN1Jeao/0YYH4FEY4JHkFDPYSY/w8nNkK3PSrl4J y2aqxOzedY5RP8GTqs4ziu0skA== X-Received: by 2002:ac2:532a:0:b0:507:9777:7a7 with SMTP id f10-20020ac2532a000000b00507977707a7mr8516878lfh.17.1698152446332; Tue, 24 Oct 2023 06:00:46 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id gy5-20020a0564025bc500b0053d9cb67248sm7728993edb.18.2023.10.24.06.00.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 06:00:45 -0700 (PDT) Date: Tue, 24 Oct 2023 15:00:44 +0200 From: Jiri Pirko To: Ivan Vecera Cc: netdev@vger.kernel.org, Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, Jacob Keller Subject: Re: [PATCH net-next 2/2] i40e: Fix devlink port unregistering Message-ID: References: <20231024125109.844045-1-ivecera@redhat.com> <20231024125109.844045-2-ivecera@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231024125109.844045-2-ivecera@redhat.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 24 Oct 2023 06:01:25 -0700 (PDT) Tue, Oct 24, 2023 at 02:51:09PM CEST, ivecera@redhat.com wrote: >Ensure that devlink port is unregistered after unregistering >of net device. > >Reproducer: >[root@host ~]# rmmod i40e >[ 4742.939386] i40e 0000:02:00.1: i40e_ptp_stop: removed PHC on enp2s0f1np1 >[ 4743.059269] ------------[ cut here ]------------ >[ 4743.063900] WARNING: CPU: 21 PID: 10766 at net/devlink/port.c:1078 devl_port_unregister+0x69/0x80 >... > >Fixes: 9e479d64dc58 ("i40e: Add initial devlink support") >Signed-off-by: Ivan Vecera Reviewed-by: Jiri Pirko