Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <b50b7972-4990-9bc7-2f5f-4475011272d5@oracle.com>
Date:   Tue, 24 Oct 2023 13:59:41 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 16/21] fs: iomap: Atomic write support
Content-Language: en-US
To:     Dave Chinner <david@fromorbit.com>
Cc:     axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
        jejb@linux.ibm.com, martin.petersen@oracle.com, djwong@kernel.org,
        viro@zeniv.linux.org.uk, brauner@kernel.org,
        chandan.babu@oracle.com, dchinner@redhat.com,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        linux-api@vger.kernel.org
References: <20230929102726.2985188-1-john.g.garry@oracle.com>
 <20230929102726.2985188-17-john.g.garry@oracle.com>
 <ZRuXd/iG1kyeFQDh@dread.disaster.area>
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <ZRuXd/iG1kyeFQDh@dread.disaster.area>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c1crU3M0bFpvR0RrZTMvRTBpbTZZNkpIckdqWGVaTkc3V0daRGdUUVg4K3M1?=
 =?utf-8?B?YzZrZGlXQVlENHE1S0xaTFJHekVNZktpTm9YOFlpYmQwL2NNVjNRd3VZY29J?=
 =?utf-8?B?cjUwcWt5dkhnckwzUS9vcXZIZDZHc2I3MTBrMnJmcmZ3WTFlNWdxNWdaeE4r?=
 =?utf-8?B?ckxoaWFSMGRsWS8zbUtLekVHNkJwOG9zY282UkpaM0NXeVpGRmZTaTFZRWZw?=
 =?utf-8?B?NjBJdC9nR1VXamhlKzhVV2ozNVB2YXlyL2FzSlVKNXpGcThVeC9SSUxVeDUr?=
 =?utf-8?B?KzRoaTdhUS9uTGFUNUF2dGtkRUlBRk5XY2ZlZTRNOS8rRGE0dVpFazJuLyt2?=
 =?utf-8?B?cEVUc25EZmJuUWFGZTVLRWtLZlp1NHJPQ05rdCtKWDVLeHYvRTZJZVBEUFVx?=
 =?utf-8?B?aGxndk9OWG9SWGdKVFIrNnltVjJsQ3A5cW11MzRWWGV4MzFHS2hCS3h0c1NR?=
 =?utf-8?B?dlN5NkswRTRlWVVEV1hNSWFFTTdpdmg0S2tYK1A0aDhpNW1Da1RkRElieFVY?=
 =?utf-8?B?dzVNZnl4RGk5bzh4c3Z0cUd4T1RoVjNjOEg0ZDZwdHpoV1dySmVVNEdvVjQz?=
 =?utf-8?B?MWIyV2F0MVNMUjBpNlU3WFdCVWFIekpIZVhSQVYvNDQxOTZGeVlSZHArNCt3?=
 =?utf-8?B?UXBQeHRCaEgwbVpGbHk4alNibGFOYUVJOXdTRlJZUmRNYlNXTE1jVjg4MnFo?=
 =?utf-8?B?bjY3b2diYVF5cEFGU3FhUnBSeXpzU21UWXZMNFdlZ1cweFkvRlpwVHRpSVFo?=
 =?utf-8?B?cWZmZDFPV3g5OFlxSEU5MmllTVNBblgvNUFoRzNuckNzUzF1SjFQYnlyS1Y4?=
 =?utf-8?B?Zi9XbEVIRWFwa2g3QWJvSUFvS1BCVU5sem1sUVk2Tk51Y0UwMlFaQVNYaXpW?=
 =?utf-8?B?ejdBNmJ1WTV1dFJxVUw0R3lsWGIrVExYSWtmSTY5VzdxOHBSUHNCcmVZeTRs?=
 =?utf-8?B?NHQybmQ1aWthQ0RieHNuVGpsWE9lMSt2QWJGenNKMXN4b1NaQzE5MWZkenor?=
 =?utf-8?B?R0cyVUtGY0NINTdiUzA5WkowOVQwd0R3MG9BMHgzUUdFQ3RQbUxQeG5Ua2Fv?=
 =?utf-8?B?VGxNUEVySjROZURHcEhqc0phTStnRFhWWCs4bXJnNmtlNmMxVDVOVE1uMFJL?=
 =?utf-8?B?eVpWYUdJYzBsVGxXUGRoakZoVzRscWRWTGgvekdPaW1jdDFjM2VNcCs0VTZW?=
 =?utf-8?B?Vms5Qm9EcCtnUU9FNGhjQnNmTTZ5bzJ4R2lvK1cyTk1MQ0JxRWVOL1A3K01H?=
 =?utf-8?B?L3lQdGk2NDhsK0VXQUkzR0JieExEUjBSbEJBMDFoRzEyek45bEdHUTdMN1Nt?=
 =?utf-8?B?NkkyWW14MWpzR3Njc0l4RDc4UWZ1UDdBWGhGb3A1SFVwV21CNHNpU09FbXQ1?=
 =?utf-8?B?S2YvWTVSaXo1blNXU1BkUmovVzh0czU2YXowOS9jZGZtSUpUMjIvWmFlS3N0?=
 =?utf-8?B?TXdPTFhUcUpCZ1pFT2xyeEdwd1pZYzBQejBnQTFCQWI1MlByb2FxQ2VGdk8z?=
 =?utf-8?B?UHV0Y1RDem5DNXFhZFIybk90UGsrWDZGaWpzeVgwRXpmOXJXQU1MN25DSjJW?=
 =?utf-8?B?N1pHblJFRDgzK1ltdnVXN0hqeTVJTXpDQzVZU1VZV2Zub3NjNVZqVVd3UnJI?=
 =?utf-8?B?Y2VnY1lFdGlRdFpsSGY3Vm9GdWZteitNbER1SWtkWVp2cG0rNXRrK1Z1TmdF?=
 =?utf-8?B?MXVZdjB2NGg2RE5HdGo5d3U2RWNWT3JSclRPL1I4SWVNN0ZqaGdadk1LVTF5?=
 =?utf-8?B?cHZIbUs1VXkzV3d1UThDQktjUHFaWXZhR3hWeE5TMXBTaWtNRkJ6NzBQa1pn?=
 =?utf-8?B?MDFJRVZqb1lHTldRTHJwdVVkQW5oeW9lRUNoenJaS3pQNnVkb3AxN1l3STc0?=
 =?utf-8?B?L2RCQ3BBandhcytxckRNYVREZWR0elp3TGZZY25RVFJXKzNuWjNlcHA3Rkxt?=
 =?utf-8?B?aVkwV0JsM2hGS25hN2ZOaVZLd3ZWMmV0TWlkTHlsamdNUFRZa0pDYUdUbW1H?=
 =?utf-8?B?Rk81SzRoanV5MEJUOEE4TGZQYWJXdnk0c3lkbVlnN2RzN1B3a01YZVlzQWtw?=
 =?utf-8?B?a0NLSDFrbXlWZGpPcUlmd1NFTmZLbmdFa1NsN3BHZUtZd2V4RzRobVB3Nmlh?=
 =?utf-8?B?RXdWK1BYWmNXV0lGSFdWU1E4a2JrWDBzOEZDdEpYbzVRVlR0bGw2YjAvN3Ns?=
 =?utf-8?B?NlE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?SEg4SGpDM29JbHBSdll5TCtEVXZSWERmWVpMNlI4MkJGQmQ0Qzg5b1psVTho?=
 =?utf-8?B?MXdJbVVMaXV2eU1adXkwZjVxT0RDV2tCeEhZdnhIekFYajRJVUFzSGRkUzk0?=
 =?utf-8?B?VngvZnp6cnRscU0zS2pRcTg3TmRhbVVCUm5iTFFWT0RHQmFHTWpmZkJhejJH?=
 =?utf-8?B?RzgxczJOcFhMNHplY3dQV2N3TVVLMGJvR2t2VEhoY055YUU0Zk9IaFVSc2Fx?=
 =?utf-8?B?cm1JcFowdDNzU3N0eTl6VXV0RmZzc3ZuZUNXMnNva2VZOWorbkJuemZXaWhV?=
 =?utf-8?B?ODdiS2VTTTNaOWlFQTNoVmVCUnkrQlZHbW5EMWxNU1V0cG9Ya3VaRUMyaEp5?=
 =?utf-8?B?YVNSbVFVcUNPdXI1YW0xZ2prR0hxUlZCWlpXZCtwMG0xeVBYNmZVcXNYOU5u?=
 =?utf-8?B?RFVlQ3E0alFNUmpsellkQjAyaDIwZjhzVWhNcTcwRVBuUGUyL1dMcHFScTZT?=
 =?utf-8?B?NXlCVzJvVFFTZWEwWk5OTXJleGM5VFZZbGN1TjBDWjVtSGR2UDF5enB5Tzl4?=
 =?utf-8?B?UTNCMXhpdHJ2TWJ3b0hOcFdzUkt3NFRxNWdNdm5sTXJBQ0VGYTBVTFB1RFBN?=
 =?utf-8?B?TDdENkMzejl2N3NZU1M0MjhnUE0yMjA4UmNuOVJjdDNJa2M3ai80UUpXUmcw?=
 =?utf-8?B?T2hSS0xmV2hwK1hONUI4TENoOUFoTkd4MFJkUEZUZi9XTmQ5TmM0QVRlT0tL?=
 =?utf-8?B?aUo3bHdZTDZVYythYURtL2hneHlpajdXYUNCdG8xTW9RNkNxb1JiSVVYRGxx?=
 =?utf-8?B?SUN5QjRtNFBtMzFqRzNsU3FVTmgvVmpTTWJ3amNXSnN4OEZzVUs0NnRhNVp2?=
 =?utf-8?B?ejdpaEwzRWJobHFvelhJYXNGRUVrT3E2elZ3dU9LOGUrTnNucXNtcDdsejN4?=
 =?utf-8?B?SXY3bXhzekNMQ2lyRUxRRWoxRm9iWm9aZFV4NW12UmticjJVbHp1NXZxU1VK?=
 =?utf-8?B?QjRwZ28zRi9uY2gzMGtQNFZlWFE2OFFUaXhYd2VVVEhEVmVZU3VrekVpVEs1?=
 =?utf-8?B?ZjUrQmxVM2pyK09Gc2ZLb0QrNGp4bFRYZjJuMUNKems1N1hod2ZZQ2NDT2N1?=
 =?utf-8?B?SHVzbnQrYk9jUERTak9MajNJbys1REJjQmM3bnZHWWRWcHNlYWdHbG52WmNT?=
 =?utf-8?B?dFN1bUZvbVBCMjhOSWhyYTVQUFZYaSt0dCs1S3BwdVg3eUxSWVVBL2YzTEZT?=
 =?utf-8?B?ck5kSDB6b2kxemZIdzdpUkVzRUlxb2dEcE9zdXpORmhSL2FmSHRwWHRXKy9y?=
 =?utf-8?B?bzVuYjA2aG1UV2REMThaT29HZ21WODRuQVBHN254OVhoMnVDNytVRkM1RVMz?=
 =?utf-8?B?OWtDemFZenU0dDBvQ1BSQ2RNVnJDUGlGTUlEUDlZTW0rdGdhOG1PbUxuVGNG?=
 =?utf-8?B?dC9nZ3FJSXIrSEhaQy9ycWtldkNBYkVmRDBENEdxNFUyMGNDWjY1anF6eG9E?=
 =?utf-8?B?YklhQzNmT0pOTDJ4MHlyZXkyUEtKcGVDSmNYLzgrbUpPYXdqVUlUSE5CMzdC?=
 =?utf-8?Q?IQovb50adD7wHDv/az8p8kWQNTo?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29d5d8e9-f407-4368-2a09-08dbd4911971
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 12:59:46.7222
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZLlX1OxzaZdRExeoimQR4/L8ZJWiFvFr97QLTsSt/ytKQqjHsZzKIkJhjDHHdqyEvB7zzCL440aiQiHe5yws8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4794
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-24_13,2023-10-24_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 suspectscore=0
 phishscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310170001
 definitions=main-2310240111
X-Proofpoint-ORIG-GUID: 2WbGwI1wS6xt-XVE8a6-U0RV5DQ8uRBi
X-Proofpoint-GUID: 2WbGwI1wS6xt-XVE8a6-U0RV5DQ8uRBi
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 24 Oct 2023 06:01:38 -0700 (PDT)

On 03/10/2023 05:24, Dave Chinner wrote:

I don't think that this was ever responded to - apologies for that.

>> 		n = bio->bi_iter.bi_size;
>> +		if (atomic_write && n != length) {
>> +			/* This bio should have covered the complete length */
>> +			ret = -EINVAL;
>> +			bio_put(bio);
>> +			goto out;
> Why? The actual bio can be any length that meets the aligned
> criteria between min and max, yes?
> So it's valid to split a
> RWF_ATOMIC write request up into multiple min unit sized bios, is it
> not?

It is not.

> I mean, that's the whole point of the min/max unit setup, isn't
> it?

atomic write unit min/max are lower and upper limits for the atomic 
write length only.

> That the max sized write only guarantees that it will tear at
> min unit boundaries, not within those min unit boundaries?

We will never split an atomic write nor create multiple bios for an 
atomic write. unit min is the minimum size supported for an atomic write 
length. It is not also a boundary size which we may split a write. An 
atomic write will only ever produce a maximum for a single IO operation. 
We do support merging of atomic writes in the block layer, but this is 
transparent to the user.

Please let me know if 
https://lore.kernel.org/linux-api/20230929093717.2972367-1-john.g.garry@oracle.com/T/#mb48328cf84b1643b651b5f1293f443e26f18fbb5 
needs to be improved to make this clear.

> If
> I've understood this correctly, then why does this "single bio for
> large atomic write" constraint need to exist?
> 
> 

Thanks,
John