Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1874571rda; Tue, 24 Oct 2023 06:10:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZun9ErykyD/j4k4dap4I18T56vkJRVSnKclIvbK/2HOZJp2nHEq22S+ibRVqzCIi7WfjJ X-Received: by 2002:aa7:988c:0:b0:6b2:5b5:4f12 with SMTP id r12-20020aa7988c000000b006b205b54f12mr7993556pfl.14.1698152999944; Tue, 24 Oct 2023 06:09:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698152999; cv=none; d=google.com; s=arc-20160816; b=KhWrR/maduo1pDWYxPRUm1skh+5oHU4g7GyI7NW+1MXTxaz7cX248TQtr3TJdfvNiB nyvxx4x+VShCJ4r54TLNfcCD3YdBR2VhqB9QC+leREDa5Ycj3aDrUcnqBjoFDDwTBvlr ww2aas6DaZL5/o5BwVzMxMvaCUc7SrZm3mZvqFE2CAPUFHa/AJGPy388h6fq00JIigTC nGlIJnb2Qk9lSOyPVyYBO9qzflT6hhV257agiIiSQSFFPnAOAPHzX2A0TdYOKmTU6J4u TdvKNiM0fGVHAH/rmtdNX5S1M3FpSkQrJfHLTQejaSy/9+e6oy5/fW749TwVR8nYYKWW EBSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=PxMMeaZ0tgXCL4krKTsekJNkyOJHOtF/YgX+FC5eMDk=; fh=pnKFhVJHpcYXxGo6cho6GX20EBCyIYrfQF3LRtZKnKM=; b=eXwwoCtBiBvfuNfwDuOcrKDTUVfbZsOLtMd0f1ZK8HxNefk6l84A9AYJNzlPcNhgp9 vWy9D+PYFfDCnEU5AWmvxkKp0YqxWUTanpJ46uISRWNpQJ3KnWKJUZKaZnP4XL4jPvCP r8lGUY9Q5PzKIqJeBO5v7lU5JMKz1KYkODC3eGxmpILjBN9d5bo9c8vJI9MzrJYy0BvW q68WcdI+zYv8qWKWsvOuV3PAr9ZUrg/ym/e/2pgOF0iGZPimEG7QI8rDzbqNLFVYn1PF kqlgI45PWDHuETT5evab/EOY0SGMGg5i4NxhgfP30pPaETijaMq62WvFi4ywXeVTloDB H4YA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="SUcqiR/M"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id u14-20020a056a00158e00b0068e0fcf8c28si8689461pfk.336.2023.10.24.06.09.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 06:09:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="SUcqiR/M"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id BD7EB80C6531; Tue, 24 Oct 2023 06:09:47 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234766AbjJXNJi (ORCPT + 99 others); Tue, 24 Oct 2023 09:09:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234760AbjJXNJh (ORCPT ); Tue, 24 Oct 2023 09:09:37 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E2F48F for ; Tue, 24 Oct 2023 06:09:35 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D214C433C7; Tue, 24 Oct 2023 13:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698152975; bh=dwCTjMWxulfmok8hvVUhl0To2h8rmkpi55JvtMmovYM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=SUcqiR/MI1naRN0Gf16J8VSkRwGc1fRy1LwHqQzo0IIgu3y0WmI7KmjkfOAo67NzT LwrQB8py9L3UQLA//IghgTRsMT+id4QvBwMox4NZgylu6BD1q/qIdEoKMefvTR/xbc IuPzmcEGzvRBGJUNDzwTVoy14dHfTyoSwRjHK/f+hrJl3zmo9kkCr/rIRPtCLJE6eS 76LIuehEj36TIfTp9XMnxBGJEGT5E3ka6j6oeWXataIOPl8YjUX6t4r+bwhAGXjkD6 WpzuhZCQf0O6wDwsm49vru4nTubMY41AZLQzQps5bhsRIljmCc8LrrxuFbVgNFarN4 RNInazFe2N9gA== From: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= To: Anup Patel , Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Conor Dooley Cc: Marc Zyngier , Atish Patra , Andrew Jones , Sunil V L , Saravana Kannan , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Anup Patel Subject: Re: [PATCH v11 09/14] irqchip/riscv-imsic: Add support for PCI MSI irqdomain In-Reply-To: <20231023172800.315343-10-apatel@ventanamicro.com> References: <20231023172800.315343-1-apatel@ventanamicro.com> <20231023172800.315343-10-apatel@ventanamicro.com> Date: Tue, 24 Oct 2023 15:09:31 +0200 Message-ID: <8734y0rwtw.fsf@all.your.base.are.belong.to.us> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 24 Oct 2023 06:09:47 -0700 (PDT) Anup Patel writes: > The Linux PCI framework requires it's own dedicated MSI irqdomain so > let us create PCI MSI irqdomain as child of the IMSIC base irqdomain. > > Signed-off-by: Anup Patel > --- > drivers/irqchip/Kconfig | 7 +++ > drivers/irqchip/irq-riscv-imsic-platform.c | 51 ++++++++++++++++++++++ > drivers/irqchip/irq-riscv-imsic-state.h | 1 + > 3 files changed, 59 insertions(+) > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index bdd80716114d..c1d69b418dfb 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -552,6 +552,13 @@ config RISCV_IMSIC > select IRQ_DOMAIN_HIERARCHY > select GENERIC_MSI_IRQ >=20=20 > +config RISCV_IMSIC_PCI > + bool > + depends on RISCV_IMSIC > + depends on PCI > + depends on PCI_MSI > + default RISCV_IMSIC > + > config EXYNOS_IRQ_COMBINER > bool "Samsung Exynos IRQ combiner support" if COMPILE_TEST > depends on (ARCH_EXYNOS && ARM) || COMPILE_TEST > diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip= /irq-riscv-imsic-platform.c > index 23d286cb017e..cdb659401199 100644 > --- a/drivers/irqchip/irq-riscv-imsic-platform.c > +++ b/drivers/irqchip/irq-riscv-imsic-platform.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -215,6 +216,42 @@ static const struct irq_domain_ops imsic_base_domain= _ops =3D { > #endif > }; >=20=20 > +#ifdef CONFIG_RISCV_IMSIC_PCI > + > +static void imsic_pci_mask_irq(struct irq_data *d) > +{ > + pci_msi_mask_irq(d); > + irq_chip_mask_parent(d); I've asked this before, but I still don't get why you need to propagate to the parent? Why isn't masking on PCI enough? Bj=C3=B6rn