Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Tue, 24 Oct 2023 08:10:32 -0500
From:   Lucas De Marchi <lucas.demarchi@intel.com>
To:     =?utf-8?Q?Micha=C5=82?= Winiarski <michal.winiarski@intel.com>
CC:     <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
        "Thomas Zimmermann" <tzimmermann@suse.de>
Subject: Re: [PATCH] iosys-map: Rename locals used inside macros
Message-ID: <g7y5ivgobnrccjjtdczrj5gcksc5bftutkz4zeeynn6os3rkac@e44pxi6wng43>
References: <20231024110710.3039807-1-michal.winiarski@intel.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231024110710.3039807-1-michal.winiarski@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWtjL1IzR1VvRzBwaUxFdVNtL01sTUhxOHM2MDZWa0R0cWgvdUNWZjQxVHFQ?=
 =?utf-8?B?YUFENUEvb2JsaHE1YnhxaWF3TVhmTWx0ZW41ckVCMWVoU3MvMXhJMkl4KzNF?=
 =?utf-8?B?R3BnNE1vKy8vcWhGY05YcGlDSVJ4MUtzaWxkS1lzendlRGlkdkRSZnhSVk9y?=
 =?utf-8?B?bFlhQm8vYUZTMFI0Uk9hNUFNSUY0WHpucnFJeWxQdHJ3b1AraWdhdVZRdFBq?=
 =?utf-8?B?aFRtb3ZHRlptMVJ4cFYzMmhNenZxdUJFQURNY05CSGVyMjV3WDBCNitCR21m?=
 =?utf-8?B?WmdibWtlOUh2OG52K3hGUmRKTHg4bFM4SHZzVnMwdDVzWGk0SVRGVDBlT1lz?=
 =?utf-8?B?OVZSYmlKM2UzTzgvRmJSMUNrR2owNVoySk9XN3UzNmFHMm51NFdodUFHSGZV?=
 =?utf-8?B?bjdTMWNSNzRXYjRWTVlsQytPSFRseUJwMGt5Z0tCcW9vcS9SSk5IU0ZIejgx?=
 =?utf-8?B?eko5YmlKdW5pUzU5cDdXT25LYUZSL0kwMnBKaTFyWFhqNnUvSnhIWVM5QVJz?=
 =?utf-8?B?b1kzV2VXdHNVbEtVcXZkRjNVb0dmWWp2WkVwbVJnSVJqRkVGbkFQNVV3TFRm?=
 =?utf-8?B?UFpDWStTZVlRR1lhOWtZemhZb3FRZEhZbXh1V0VpY0hRU2FZN3FqZFVaUnRy?=
 =?utf-8?B?aC93RDdhRkc0OUw5R2g0bGwrUGVkd2Y0TDFIcW9pU3pIVXpBV3MrdnlFalBM?=
 =?utf-8?B?T1JTdnF6dVVOY2Zwek1aRzhsL0VUWTlQY1NQWjFub0hTckl6WHppdTNvaFRu?=
 =?utf-8?B?empMMU1qcmxPK3BaYmFoV25rZWpqSEVKdi8zRWpxcEpaZkgvcFNrejQxZ2tO?=
 =?utf-8?B?WGRMK2czaTVNWUprcC96anNIV0RBMkJkR0lkZjlUYzg2VjZDSHdCeXZNTjd2?=
 =?utf-8?B?TWRNbUlqUmNsT0EyT1N4ZzlZcnZlZUt3OERmUDJucVpJR0lwOW5HNERaVitE?=
 =?utf-8?B?aGpYSmVxSGVJOVI1bHQxNmFscTJvY3NPeXI5S3k1Q0FNZDZ5QUJMWjd1MWZL?=
 =?utf-8?B?cEIrTmRRVW1DRThIYzVmbStyVmp0MkFoOHI4SnF0b3dSWVBrMWpkRmxCbitm?=
 =?utf-8?B?WU8vM3Rjc3lqTnROSjFTN0FRYkNXNENBQlFuc0FjckZPNFJkdjNnbTZFRUpm?=
 =?utf-8?B?VEJ1OWZPa1RGSUdBb3FVS1RHQWkxZ3k4R2JqSEphQVlBWEsyMFNZYUl3MExw?=
 =?utf-8?B?TTNuV0J6dTh0Z3FlZ2FDazl5c2laTEVRVHVqb2hoUFl2TFUzVG13c3BRbThG?=
 =?utf-8?B?WGw5SjVmeTFiejF4WVFwWk1XeUNnOERCd1NFbEdWRjd4ZStnYmFvRnpzWVdt?=
 =?utf-8?B?THllV3BSdUc4QXdtUWhwSjNVTXpXa3ZFanRYdUE3UDdJOG52dktQY2lJMGQ4?=
 =?utf-8?B?Qm5mZStURkl2bGdyMGtvd3ZldHE2a0xPVkNSSU1kejlobTlFWllZSDhqT2ZX?=
 =?utf-8?B?dVF5Q2oyY1ZyekxwWFUvakRlMzFDTGRFaEtmVWUxencza1I4TXF4MURrL2ZR?=
 =?utf-8?B?NjdlQU1lSUU1cXdzV014dXJKUmJiS3BQRTg2VmlOckVUYnhMTHVIQ0g0R1lO?=
 =?utf-8?B?VVppSkIxWE1IZ0FFZEdNTTdRR3k3RHdpckx0NnVXMXk4MzhvS2xab3NHYzJL?=
 =?utf-8?B?VXZkSTV1Ym5mOGMycUVRSXVyNmIycTllT3VlSURZTXVod2xmSGNkcERWRURa?=
 =?utf-8?B?RTdFakVQYk1ia3VKQ1F1UXB0S2tpcFludjJEeFplRUx2UHFwaWVkQi9QaW92?=
 =?utf-8?B?TWV4bXUyaDZFaHlVN3RTRVBuaDN1ZmFOVVV1WWJMQUp3blBGRjQzSURXb0RC?=
 =?utf-8?B?eGdrMjMveDY3S3picWJjQkxzRmFqb0xWaTJZamxwL3RKcWxRdXJIanRWb0hh?=
 =?utf-8?B?Sks4SFBuZnBxbDlZMVRyb3huZXpHY2MraTNwNkYrcG1zbDFmTHFERGNGanBx?=
 =?utf-8?B?K1dCQlhOMWRYVjA3LzNwZ2x4cHA3bnFxY2JMbkwvb0s3WTlqRlJzWGZtaWls?=
 =?utf-8?B?blY0Z3NLZzlJdjY3Qm00MkIzaFhLZ3huWW5EUmxpVTdHZmUxU2NlRUdocisr?=
 =?utf-8?B?YS9HMmEyTldpTEpIcVpLRTVnQUVoZis0eGs4cVVRNlVHZm5vV21xeU9nOXR0?=
 =?utf-8?B?TlcrejhmOXVZSDVxMmllNnZLRmhqMkF4QnA3U1VVTlI2YTVCZmFMRm5ORmdL?=
 =?utf-8?B?Z0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c830b6dc-2902-4df5-5433-08dbd4929c29
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 13:10:35.4645
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rMCUacyrCl8cKQJW+lxsdkdkznNzGm7qFaZJGiI0j5L3m1Cb/GbGWtgy599b4/L8d+wT5mSHnZNpITUTNa0s1xE6O03FBqSb8IOXD/ltsYY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5130
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 24 Oct 2023 06:11:14 -0700 (PDT)

On Tue, Oct 24, 2023 at 01:07:10PM +0200, Michał Winiarski wrote:
>Widely used variable names can be used by macro users, potentially
>leading to name collisions.
>Suffix locals used inside the macros with an underscore, to reduce the
>collision potential.
>
>Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
>Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>

`git show --color-words` shows this is doing exactly what it should.

Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

Maybe note in the commit message the compilation error we get with
clang? Although that's in the xe driver that is still not merged
upstream... so not really required.

thanks
Lucas De Marchi