Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <cdcd6b97-1138-4cd7-854f-b3faa1f475f8@intel.com>
Date:   Tue, 24 Oct 2023 15:11:05 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [Intel-wired-lan] [PATCH iwl-next 2/3] i40e: Add other helpers to
 check version of running firmware and AQ API
Content-Language: en-US
To:     Ivan Vecera <ivecera@redhat.com>, <netdev@vger.kernel.org>
CC:     <intel-wired-lan@lists.osuosl.org>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        <linux-kernel@vger.kernel.org>, Eric Dumazet <edumazet@google.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Jacob Keller <jacob.e.keller@intel.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
References: <20231023162928.245583-1-ivecera@redhat.com>
 <20231023162928.245583-3-ivecera@redhat.com>
 <2aba9a2d-9dfd-49f2-bfec-1ff563a5f017@intel.com>
 <d71f2fa2-e5b7-4221-bbd0-86285b6c1c33@redhat.com>
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <d71f2fa2-e5b7-4221-bbd0-86285b6c1c33@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anZEb2ZaSGNIbGZhVUNpMnJ3aC93ckthSHIxM2JBUDBLNnpHYklnb0EzUm90?=
 =?utf-8?B?aDZHcm1Tc1JwZ25WUEVUT1VlSzdyZE1nTkpUT3RXMldmY3JRK3ZUMnk3VjEx?=
 =?utf-8?B?VHdyUTdGOVAvdy9aQUtUY3FnanBJRHQ3YTNGU2pGdkh3dlhuaGhsQU9odTdx?=
 =?utf-8?B?NCthRzJXQ1BpM3FBVlBBWm03TmVtVmNMSmZ2d09wL1llNE9FaGF2bUlNTHRx?=
 =?utf-8?B?ejNQMGhEWHNuTGpab2pLa0JNSU1WcDFLVUtFNWVhbGN6NHBZWlU0WmVzNXhz?=
 =?utf-8?B?WEhXaUZMdDZsZ2FDUys1VnpROWYvT2Y0cGsyL1grd3pJYUx0ajNuSytOYS93?=
 =?utf-8?B?L1RBSmlZZThuY1NETWp4RXlvdk9VRFBsb25kZ21QWVgyR2ozY2hxdjY1TVVZ?=
 =?utf-8?B?R1VYVUdCT3o5cHp4NG8yb040UHRmUG4xNkdkNS9xcnRYSzNad1pNdTk0VERS?=
 =?utf-8?B?Q1pIUWh0Wm0vM0ZaZ0w3WDFrb01zRXp2L1ZxaWl2VGltZnM3b1hucmVIS0Zi?=
 =?utf-8?B?TGh1cXg4cVIrQnZLaDBwQzZhaVZsZXVrcitLdzlmZFBvOS9QaWVDWVp2S0NL?=
 =?utf-8?B?WjdTcmhPUkZYdm1qeitxNHNtSU12YUlUVkxka3R1emJJaDB1L1kwRElXcHBR?=
 =?utf-8?B?b29NaUg0VEtlMDQxQVVUODJjeFlQRTRsUEFRZkFBajZTeDNnMFVJdFNEZHF3?=
 =?utf-8?B?WWxmMm1YM1QxNldrQVFJTktYWFdZYU8wNTBDM1o5ZDhFa0Q0clVJUkR3SFpv?=
 =?utf-8?B?Zk43L3ljQkNkT2t0Y3NiTmZhL1RIN2FoTmErZVowNGhGQWlhSHZpMDN2T2FX?=
 =?utf-8?B?Z1lxUkUyekNGdjVidkp0a3ZsNGVjMlcxWHFPRk5SZS94QXcxenM5dGJtOHd6?=
 =?utf-8?B?NFZOalRyTE8rM1AyRTAvMzV6T2lWd0JkUlkwMGcrbEw1SDdNV2lOU0grcEdo?=
 =?utf-8?B?ZVh5NkF0MjJNZ1VPWVpTQkNEa0o0TzUvZnk1aWk2SE04dEdWOTlEWi8yS2RZ?=
 =?utf-8?B?RXE0YTZrQjN2eERlSFRHOFplTDd3TE9SdkN1c3ZocGFFeExRM1RlaCtUYXFu?=
 =?utf-8?B?a3hBSzNWeGFiamk1c0U5VWlDZ2hzUlZYdnN6TFhIelhNV3JQYzNCaHh4QUZu?=
 =?utf-8?B?bUdlNEhhOFZVMm4yczloTENhWldKUXNjZFVBWWhtM0N1aEFVM0lrMC9VeXpl?=
 =?utf-8?B?Tmtid1JMdzM2VjdpenppMXRKNjkvVngreHk0NjFxM0FjNnVsbU5zbSsrT29r?=
 =?utf-8?B?L3BFQStsMi9xckkxVkpNSnBoSEZ6d1hOTFp4QjRTbjNpWVFPYjh4eFFiSnJm?=
 =?utf-8?B?dlpqZWVIckNZWUw1Q0pva3hrUU94K05Fd1ZDNXlOQ0NWUEkrUTFrWG1iUWJj?=
 =?utf-8?B?QVZnQ3ZHOUxOQW10WlZFcFZ1Y2VPdnpaZHFFcVRnTnJobWZERkh3VnVpK0tJ?=
 =?utf-8?B?bEJQdGxBWW9Idkw0TnpJSTJaOUdPY3czUDZPT002OUNsUmhZT1AvUFNXR1Rt?=
 =?utf-8?B?emhyRlRjTHFiQXA2Nm5ENzBaREw5SzlzQW5oVko2L0xoeS9YUU9VVVN5R1cz?=
 =?utf-8?B?aTFSRHJ3WUJpcytpUWErdnRIbDRCeUNYR013RzYvcUNFVzM2TkY5eCsrSXoy?=
 =?utf-8?B?K1FXQVJqZUd6aHpzemhueFYyd0xsY1BzYXF1S3hGQVpaM2RyRVE1RjVRUmha?=
 =?utf-8?B?YXdJY2ptODFVNGxTUk0ySkxnMVBNcG1vU0xOcnlSbm9iMDRxdktoK2dTZ1BT?=
 =?utf-8?B?T1BLYVh2cmxER3dtMFpHbm1RMU1KeFpieXNIamt5c3QrSXliM2JyWHp5cDlu?=
 =?utf-8?B?RDI4bjlEbWlnQURtUkN0R3pkTXVXMElTZmFMWUxFOGFnSExsYU5jQ2lCbi80?=
 =?utf-8?B?MklwMHA4d0JxQUxEdU54RHpiTTNURlBESFIrWVpQd2RKMVlnMkMrM3l4b0g2?=
 =?utf-8?B?cnQ0aVZKc21yYU5QdU1FUG1ySGJiNWxkZWlwMkVKa1ZuYzd5YWtxZTBTNFZQ?=
 =?utf-8?B?OWFLWUZqMTlmUXdRNlZLWnVHRlNGb1pHcmFPWlc3Y2NnM2dHRmI0cWVWSGFL?=
 =?utf-8?B?NXo2R3kvQk5WY1JNeTdDbEN0bkF3M1Bvc3pCRWUxNWU3ZmRMTFNwVDBGYTl3?=
 =?utf-8?B?Qzk1SnllR0w2T05OS1VIUmNubG1OQXUrM2dQUlk3MWtoVmNPUUZrcVJ6a0Zi?=
 =?utf-8?B?cWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 731349e1-1e09-4689-edcc-08dbd492b1b2
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 13:11:11.7375
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PIs85IcYeCkvXp5ATfK1r23Dw+Kw911M9wEHY9BqoLhV7eAqIsCPQ5E2s92yR5gLUPnkPpCbVUSgxBzK1IB6SVfJoG4PDIAYD23pL+FMzJk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7562
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 24 Oct 2023 06:12:03 -0700 (PDT)


On 24.10.2023 15:01, Ivan Vecera wrote:
> 
> 
> On 24. 10. 23 12:24, Wojciech Drewek wrote:
>> On 23.10.2023 18:29, Ivan Vecera wrote:
>>> Add another helper functions that will be used by subsequent
>>> patch to refactor existing open-coded checks whether the version
>>> of running firmware and AdminQ API is recent enough to provide
>>> certain capabilities.
>>>
>>> Signed-off-by: Ivan Vecera<ivecera@redhat.com>
>>> ---
>>>   drivers/net/ethernet/intel/i40e/i40e_type.h | 54 +++++++++++++++++++++
>>>   1 file changed, 54 insertions(+)
>>>
>>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
>>> index 050d479aeed3..bb62c14aa3d4 100644
>>> --- a/drivers/net/ethernet/intel/i40e/i40e_type.h
>>> +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
>>> @@ -608,6 +608,60 @@ static inline bool i40e_is_aq_api_ver_ge(struct i40e_hw *hw, u16 maj, u16 min)
>>>           (hw->aq.api_maj_ver == maj && hw->aq.api_min_ver >= min));
>>>   }
>>>   +/**
>>> + * i40e_is_aq_api_ver_lt
>>> + * @hw: pointer to i40e_hw structure
>>> + * @maj: API major value to compare
>>> + * @min: API minor value to compare
>>> + *
>>> + * Assert whether current HW API version is less than provided.
>>> + **/
>>> +static inline bool i40e_is_aq_api_ver_lt(struct i40e_hw *hw, u16 maj, u16 min)
>>> +{
>>> +    return !i40e_is_aq_api_ver_ge(hw, maj, min);
>>> +}
>> It feels a bit off to have those helpers in i40e_type.h.
>> We don't have i40e_common.h though so I'd move them to i40e_prototype.h or i40e.h.
>> Same comment regarding 1st patch (I know I gave it my tag but I spotted the issue
>> while reading the 2nd patch).
> 
> I'm sorry I already submitted v2 and helpers are present i40e_type.h.
> I would submit v3 but there is also i40e_is_vf() inline function already present in i40e_type. Would you be OK with a follow-up that would move all these inlines into i40e_prototype.h?

Sounds good

> 
> Btw i40e.h is not a good idea as this would bring a dependency on i40e.h into i40e_adminq.c, i40e_common.c and i40e_dcb.c.

Got it

> 
> Regards,
> Ivan
> 
>