Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760627AbXKTQzG (ORCPT ); Tue, 20 Nov 2007 11:55:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756975AbXKTQyz (ORCPT ); Tue, 20 Nov 2007 11:54:55 -0500 Received: from mx1.redhat.com ([66.187.233.31]:53606 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755198AbXKTQyy (ORCPT ); Tue, 20 Nov 2007 11:54:54 -0500 Subject: Re: [PATCH 3/3] security: allow capable check to permit mmap or low vm space From: Eric Paris To: James Morris Cc: linux-kernel@vger.kernel.org, sds@tycho.nsa.gov, selinux@tycho.nsa.gov, alan@redhat.com, chrisw@redhat.com, hpa@zytor.com, akpm@linux-foundation.org In-Reply-To: References: <1195246545.2924.88.camel@localhost.localdomain> <1195250009.2924.103.camel@localhost.localdomain> <1195250840.2924.113.camel@localhost.localdomain> Content-Type: text/plain Date: Tue, 20 Nov 2007 11:54:41 -0500 Message-Id: <1195577681.2912.4.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 (2.10.3-7.fc7) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1679 Lines: 36 On Sat, 2007-11-17 at 09:12 +1100, James Morris wrote: > On Fri, 16 Nov 2007, Eric Paris wrote: > > > When this protection was originally concieved it intentionally was > > offing something even without an more 'full featured' LSM. That was the > > whole reason I had to drop the secondary stacking hook inside the > > selinux code. > > > > While I now understand the question, I think that this is the behavior > > most people would want. I'll revert the security enhancement for > > non-LSM systems if others agree with James, but I think adding another > > small bit of protection against kernel flaws for everyone who wants > > security is a win. (and remember, in kernel we still default this to > > off so noone is going to 'accidentally' see and security checks in the > > dummy hooks) > > If it's off by default and generally useful across LSMs, why not just put > it in the base kernel code? It was placed in CONFIG_SECURITY so that users can (If their given LSM supports it) selectively allow this stuff. Some LSMs are fine grained enough to allow applications like dosemu and X to use low pages without globally disabling. I can't think of any reasonable way to move all of this into base kernel code while still allowing overrides. I'd love to hear suggestions on how to move all of this out of the security code and into the base kernel while not neglecting those few users who need this functionality. -Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/