Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Tue, 24 Oct 2023 14:26:24 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] regulator: fixed: add support for under-voltage
 IRQ
Message-ID: <471281bf-4126-496b-93ef-0807f4910ce7@sirena.org.uk>
References: <20231024130842.2483208-1-o.rempel@pengutronix.de>
 <20231024130842.2483208-3-o.rempel@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="uF8HXoNA/AGKb/YU"
Content-Disposition: inline
In-Reply-To: <20231024130842.2483208-3-o.rempel@pengutronix.de>
Precedence: bulk


--uF8HXoNA/AGKb/YU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 24, 2023 at 03:08:42PM +0200, Oleksij Rempel wrote:

> Add interrupt support for under-voltage notification. This functionality
> can be used on systems capable to detect under-voltage state and having
> enough capacity to let the SoC do some emergency preparation.
>=20
> This change enforce default policy to shutdown system as soon as
> interrupt is triggered.

=2E..

> +static irqreturn_t reg_fixed_under_voltage_irq_handler(int irq, void *da=
ta)
> +{
> +	hw_protection_shutdown("Critical voltage drop reached",
> +			       FV_DEF_EMERG_SHUTDWN_TMO);
> +
> +	return IRQ_HANDLED;
> +}

We need a bit more policy here - the regulator could be critical to
system function but it could also be well isolated and just affecting
whatever device it's directly supplying in a way that the system can
tolerate and might even want to (eg, for something like a SD card or USB
port where end users are plugging in external hardware).

--uF8HXoNA/AGKb/YU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmU3xf8ACgkQJNaLcl1U
h9DtuAf+MSSbDFj6UK22EAUJGxqPboAwLoDDRg3zGxLEvO2ohr9XMV5N/KqVlsJI
FOq474QBednEQeLQKZEvlgP6b/xy+hSbJSl0KNwDm+ViHqiKZSJsIkktGbEqdXfS
hTalmmsiXjAF4ur04dgSRhd3i7bvIjktWH7RviF8zpYuBQvAhWcd9oO8H7L7y5Fw
v2XKE3AYSJRqE0tM2WhufObe6coA5c0ihRmHv69iyncrM6UqsEasb0vpI+hrir8x
ofqKsU8SUb5KvBfYMaqEXbp+mItuLZ25tUkQObZnAy+CLzONB4fPKroVccLpNc08
YvLpMrUBpXoCv6Oax7PPak5qYXdipw==
=TupP
-----END PGP SIGNATURE-----

--uF8HXoNA/AGKb/YU--