Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1921528rda; Tue, 24 Oct 2023 07:19:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGkAMPzqMWGov3OXqp5K3E5ZOIMQQIyxP9FcXowMT/vykngNazKrEN6ddwzcPIGFn+vZ1jd X-Received: by 2002:a17:90b:3546:b0:27d:5568:e867 with SMTP id lt6-20020a17090b354600b0027d5568e867mr16737434pjb.9.1698157168870; Tue, 24 Oct 2023 07:19:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698157168; cv=none; d=google.com; s=arc-20160816; b=JsS6+7UsVq+S5AizlAvS0F94TVEQWgj9q9jYKQAQFgynBjy4Hv9rjb+7pEcpRlTcv3 8M4Sr6ooidH62UnJPSOo+oHoUGABIz1c5xIctBHwOscGpAfWeSbW8YONiO0yJCjV0hjA q238kQVuYr+69CkaM41pZOL7CpYjqBgQzcr1I128k9xqLc88FZNOT4NWXSrAIYuhyygR uM3DnJKMKGuNJajj0brXwKsZ4va/EcVXsw6vwajOji07f9kf5gNanMXfN74tDA/p/gNR K7nNVMah/cLjSHmSkcJCgtFnaq/3fxTkKMbeOCg5bQtXTFiWdoNPodmzidWtfibk3M4A y4kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AqIOY3MydOW0E4HOkt35Fwk6DE+KKlC+N1Rk35Tgk3g=; fh=Ax2ycY/AXwsjSMImgd7U9CUEmKQiUbxnJ2KK0m0XZr8=; b=sB8oUkw8WZA5JKw5In2hYnU5N6xb6ZJ0cH4RW3mKtxFfNzc9MRnUukyRNNNmRo3hUq L9r4qim8XjRiCmrdjchAYi8kQqYh3LBZFELFczltJiBt6n5iTdRtcOZrBgODMtH9J2+Q 6iLMz0ng+GM9oBxWuloFjbUh40KvTxQ8DY47t0a15e3QzEBYaHsfxfe9WYyXIPG/nZvl GE0uJSjKZjK9KGlwGjMtWihkXx3oRLSl9Q3SO2ihJBpxgmEm+lzRh6WQsTSwYxo/YO4m wApKyQPyrGwvf33R2naADGSOFD+VvPczuoqqumBFF6WyWVedElc7UBJQBwCj8vgzqner yXWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=NsAEZaU0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id ik14-20020a170902ab0e00b001c746bca061si8410116plb.74.2023.10.24.07.19.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 07:19:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=NsAEZaU0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 492A48061354; Tue, 24 Oct 2023 07:19:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343620AbjJXOTB (ORCPT + 99 others); Tue, 24 Oct 2023 10:19:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234567AbjJXOTA (ORCPT ); Tue, 24 Oct 2023 10:19:00 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A11D10A; Tue, 24 Oct 2023 07:18:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=AqIOY3MydOW0E4HOkt35Fwk6DE+KKlC+N1Rk35Tgk3g=; b=NsAEZaU08KEjPSnJiMF2LI23mg XBEBYzoNHMBCjM7E07r7O2n/niFFR17ntkiAbXgx9bqjOLdZztLH/G/8Yzm5NZPN+PVNdHvp39akk kQ0WtrR3Ufkmpms7q3EXrBeY3bWUfWVunLolttcmV34ip3EkAIjLWaJ0epvP8b3646zY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qvIF8-00051D-M4; Tue, 24 Oct 2023 16:18:50 +0200 Date: Tue, 24 Oct 2023 16:18:50 +0200 From: Andrew Lunn To: Elad Nachman Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, pali@kernel.org, mrkiko.rs@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: dts: cn913x: add device trees for COM Express boards Message-ID: <55685b4c-843a-4430-b153-a0eef2e93265@lunn.ch> References: <20231024131935.2567969-1-enachman@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231024131935.2567969-1-enachman@marvell.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 24 Oct 2023 07:19:08 -0700 (PDT) > +&cp0_mdio { > + status = "okay"; > + pinctrl-0 = <&cp0_ge_mdio_pins>; > + phy0: ethernet-phy@0 { > + marvell,reg-init = <3 16 0 0x1a4a>; What does this do? I guess it is something to do with LEDs. Polarity? > +&cp0_mdio { > + status = "okay"; > + pinctrl-0 = <&cp0_ge_mdio_pins>; > + phy0: ethernet-phy@0 { > + marvell,reg-init = <3 16 0 0x1a4a>; I'm temped to NACK this, and get you to work on the LED code in the Marvell PHY driver and phylib to support what you need. This API is horrible and should not be used any more. Andrew