Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Tue, 24 Oct 2023 23:19:26 +0900 (JST)
Message-Id: <20231024.231926.1671064705010862132.syoshida@redhat.com>
To:     kuba@kernel.org
Cc:     jmaloy@redhat.com, ying.xue@windriver.com, netdev@vger.kernel.org,
        tipc-discussion@lists.sourceforge.net,
        linux-kernel@vger.kernel.org,
        syzbot+5138ca807af9d2b42574@syzkaller.appspotmail.com
Subject: Re: [PATCH net v2] tipc: Fix uninit-value access in
 tipc_nl_node_reset_link_stats()
From:   Shigeru Yoshida <syoshida@redhat.com>
In-Reply-To: <20231023155314.50b13861@kernel.org>
References: <20231020163415.2445440-1-syoshida@redhat.com>
        <20231023155314.50b13861@kernel.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 23 Oct 2023 15:53:14 -0700, Jakub Kicinski wrote:
> On Sat, 21 Oct 2023 01:34:15 +0900 Shigeru Yoshida wrote:
>> Link names must be null-terminated strings. If a link name which is not
>> null-terminated is passed through netlink, strstr() and similar functions
>> can cause buffer overrun. This causes the above issue.
> 
> If strings need to be null-terminated you should switch the policy here
> https://elixir.bootlin.com/linux/v6.6-rc6/source/net/tipc/netlink.c#L91
> from NLA_STRING to NLA_NUL_STRING, no?

Thank you so much for the feedback. As I'm not so familiar with
Netlink, I'll study NLA_NUL_STRING a bit more and make an updated
patch.

Thanks,
Shigeru

> -- 
> pw-bot: cr
>