Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
MIME-Version: 1.0
References: <20231019-feature_ptp_netnext-v6-0-71affc27b0e5@bootlin.com>
 <20231019-feature_ptp_netnext-v6-7-71affc27b0e5@bootlin.com>
 <CAF=yD-+O6QxuYJzijMes7J_DHHd7yYCz8sBLFERM1U6pYN0Gkg@mail.gmail.com> <20231024154037.2f61fe5b@kmaincent-XPS-13-7390>
In-Reply-To: <20231024154037.2f61fe5b@kmaincent-XPS-13-7390>
From:   Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date:   Tue, 24 Oct 2023 10:21:15 -0400
Message-ID: <CAF=yD-LCNGcCMqpAbV1HfyVdjH7Gj-_tTwsS=08Y5CC6bqBd=w@mail.gmail.com>
Subject: Re: [PATCH net-next v6 07/16] net_tstamp: Add TIMESTAMPING SOFTWARE
 and HARDWARE mask
To:     =?UTF-8?Q?K=C3=B6ry_Maincent?= <kory.maincent@bootlin.com>
Cc:     Florian Fainelli <florian.fainelli@broadcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Radu Pirea <radu-nicolae.pirea@oss.nxp.com>,
        Jay Vosburgh <j.vosburgh@gmail.com>,
        Andy Gospodarek <andy@greyhouse.net>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Claudiu Beznea <claudiu.beznea@tuxon.dev>,
        Jonathan Corbet <corbet@lwn.net>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        UNGLinuxDriver@microchip.com, Simon Horman <horms@kernel.org>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org,
        Maxime Chevallier <maxime.chevallier@bootlin.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Oct 24, 2023 at 9:40=E2=80=AFAM K=C3=B6ry Maincent <kory.maincent@b=
ootlin.com> wrote:
>
> On Thu, 19 Oct 2023 10:48:04 -0400
> Willem de Bruijn <willemdebruijn.kernel@gmail.com> wrote:
>
> > On Thu, Oct 19, 2023 at 10:29=E2=80=AFAM Kory Maincent
> > <kory.maincent@bootlin.com> wrote:
> > >
> > > Timestamping software or hardware flags are often used as a group,
> > > therefore adding these masks will easier future use.
> >
> > This assumes that device support for timestamping is often symmetric:
> > a device supports both rx and tx, or neither.
> >
> > All devices support software receive timestamping, as that timestamp
> > is taken in the core network stack. But to support transmit timestamps
> > drivers have to call sbk_tstamp_tx in their ndo_start_xmit.
>
> Yes, and in that software only case they often call ethtool_op_get_ts_inf=
o to
> fill the timestamp info.
>
> There is several drivers that support hardware and software timestamp, th=
ese
> mask could be useful for these. In case of asymmetric support we can stil=
l use
> the SOF_TIMESTAMPING_RX/TX_SOFTWARE flags.
>
> I forgot to specify, in the commit message but this patch is mainly to ea=
se
> the next patch of this series to deal with software/hardware time stampin=
g.
> Maybe you prefer to have this squash into next patch as had suggested Flo=
rian
> in last version.

Thanks. I did not see such use in net/ or in my experience of using
setsockopt SO_TIMESTAMPING.

But I had not considered net device get_ts_info. It would be useful there.

Slight preference from me to keep this a separate patch, as it applies
not only to the use case in your follow-on patch.