Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1954224rda; Tue, 24 Oct 2023 08:08:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEJc70Njdcjfrf3ts21RMUEtOS4HlqwNIC/8XeItagLI/yPCdHdzn9ENCl7/+gEGxt7ixsc X-Received: by 2002:a05:6359:610b:b0:168:e04f:d4a1 with SMTP id rz11-20020a056359610b00b00168e04fd4a1mr5028978rwb.29.1698160134359; Tue, 24 Oct 2023 08:08:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698160134; cv=none; d=google.com; s=arc-20160816; b=wDNxQaA2ojImcz6Czmr3n2cfb8U2K1kmKtycX42eyqtO5CoDfg9ApIijyl14uxQEf3 2gcofYknGYkHa6QimIRNhNRSonrk38KaPl5KoZlMPZLgg69YELq2C7H1m0KtQPNNFKHr gbuEkINIn3LkO6ayckb7fR3GyNgj01SzP5XFZubQw3F0yPIDC/7MehGArlzr3plPh+qW FCbtCE6a9863A3PcXtSGa43gXtokmC+vaKS7aGJJcfaZqsZau4lGVsohIo2VDosZfcLD fe4UDyZACL0a+XfTEu4yekJy3AoBjZCXdrZpGcmon1oTZ+zTMdE4Xn1SiO4VCQ50hxc9 ijoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=AN6NTJXQ2pnokdJ55KzUK3vWFKSJONMYwiEEr9XTwTo=; fh=MnPd/ja+X++w0ZhXvbKvwvUDecoKs32NOCXAbuqMPZs=; b=WOP5nsh0b3UUcffzEICkyS9MtzZ4ayNxR82LGEX5W/28e/ea9H0x9iAc8R/+0rN4s3 E6XWfedyyLF8kY7xk+RWFGB0OuP9802/ijOAeWYL9griNRdD83DWBJhNPprSAX5l3+3f VVYvhlnFL0PPYIaYZ0a+QM9OFcoMKZl08bpJYCR64NeW22Wd40a0IolOA46ntpdWsze6 /CsyQcoxFjhk7mi5qMphj78iBreSSCOLZn/rH8RLpYZH33KXRatrxhNxS4L8EemNPsKF B904Z+1axHSS991c/vZsUi+pfKWH1H+xEHwjankUI9v07BUXQWMkQsM8HtyELp1Xcfws G0kQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=1WUcBoE5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id i67-20020a639d46000000b005b8ececd69esi1173956pgd.670.2023.10.24.08.08.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 08:08:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=1WUcBoE5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id E6D06802458B; Tue, 24 Oct 2023 08:08:45 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230059AbjJXPIi (ORCPT + 99 others); Tue, 24 Oct 2023 11:08:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231518AbjJXPIh (ORCPT ); Tue, 24 Oct 2023 11:08:37 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA2B5EA for ; Tue, 24 Oct 2023 08:08:34 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-53f98cbcd76so12320a12.1 for ; Tue, 24 Oct 2023 08:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698160113; x=1698764913; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AN6NTJXQ2pnokdJ55KzUK3vWFKSJONMYwiEEr9XTwTo=; b=1WUcBoE5jAg/WuQLxIaaSUMuDWqFijh5KSJJ45vJIyqtDyB07oQ/4NtAU18VhC/p83 VpOiWXHcOqWWZqo0OuppQNa5PzD+0DxKl5sZHRHHtFTXiNAFfIu9dCMzqNjmoTSS/SWn o3IAEuEF6QXneU6odsbyEkZIq9ALN3c8QVdjWhVZzECxYgVfiLvVjQ2JFfDA47kT/mxW awtvQNEFcpkNg6OQ1Ughwjvyr5dzB2/IyjQbv7I+ctoSiB9NOIPBGacqMZoupGFsFUWd Sklc6tS2O+idM8PPE1gBb7n793FDCfWiaGuSsOvXkMk+n1smRJAUlg5S4aq7hnxt8Y/M NpgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698160113; x=1698764913; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AN6NTJXQ2pnokdJ55KzUK3vWFKSJONMYwiEEr9XTwTo=; b=fHYqayWu4cqTtNSfQyeubYLd4CPKrwe00ig5t5LtgbxmF5/wCllyDLZxUeBpsJTIkb r2VlLmXqADXLqorZv0ZwJkJhiKRgAipHB8PRGRzxkKrvpnr0QXsiBl2F8XBtbAwWDNB2 tGyR8eJW3ghiRDSs6qGTvt/M0iqwc7jfpMtBXsMDLorjSJVnFkc2u3H+FaYJ0TA3IQ+j mqaxlN/lTi8LeAPhc3Sx/HDT4bflKbb3a7PDJaKXejZzGmOu7N/Kjgp9Lj1FjocmmAkN Xa2JyA7hJrwhZJqQ86G39oHOWNnhFsj7WK57zoPoAClnNiYHyErKmLuqj5YR95/HJc3R KUQA== X-Gm-Message-State: AOJu0YwvMvvtN53izD2hLUU98cLeMRm8oCijz/XUfCG0AwEIseM+9nuw xqGtZp8NWQaCm2iL/yu54+JdP5mrJWcbuKomZTe/CA== X-Received: by 2002:a05:6402:241b:b0:540:9fd2:f831 with SMTP id t27-20020a056402241b00b005409fd2f831mr126967eda.3.1698160112944; Tue, 24 Oct 2023 08:08:32 -0700 (PDT) MIME-Version: 1.0 References: <0e1d4599f858e2becff5c4fe0b5f843236bc3fe8.1698156966.git.yan@cloudflare.com> In-Reply-To: <0e1d4599f858e2becff5c4fe0b5f843236bc3fe8.1698156966.git.yan@cloudflare.com> From: Eric Dumazet Date: Tue, 24 Oct 2023 17:08:18 +0200 Message-ID: Subject: Re: [PATCH v5 net-next 2/3] ipv6: refactor ip6_finish_output for GSO handling To: Yan Zhai Cc: netdev@vger.kernel.org, "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Aya Levin , Tariq Toukan , linux-kernel@vger.kernel.org, kernel-team@cloudflare.com, Florian Westphal , Willem de Bruijn , Alexander H Duyck Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 24 Oct 2023 08:08:46 -0700 (PDT) On Tue, Oct 24, 2023 at 4:26=E2=80=AFPM Yan Zhai wrote= : > > Separate GSO and non-GSO packets handling to make the logic cleaner. For > GSO packets, frag_max_size check can be omitted because it is only > useful for packets defragmented by netfilter hooks. Both local output > and GRO logic won't produce GSO packets when defragment is needed. This > also mirrors what IPv4 side code is doing. > > Suggested-by: Florian Westphal > Signed-off-by: Yan Zhai > Reviewed-by: Willem de Bruijn Reviewed-by: Eric Dumazet