Message-ID: <474320C4.2040600@oracle.com>
Date: Tue, 20 Nov 2007 10:00:36 -0800
From: Zach Brown <zach.brown@oracle.com>
User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031)
MIME-Version: 1.0
To: Ulrich Drepper <drepper@redhat.com>
CC: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mingo@elte.hu,
       tglx@linutronix.de, torvalds@linux-foundation.org
Subject: Re: [PATCHv4 4/6] Allow setting FD_CLOEXEC flag for new sockets
References: <200711200653.lAK6rE31025888@devserv.devel.redhat.com>
In-Reply-To: <200711200653.lAK6rE31025888@devserv.devel.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 595
Lines: 20


> +union indirect_params {
> +  struct {
> +    int flags;
> +  } file_flags;
> +};

Have you given thought to having to perform compat translation on this?
  Today it's only copied directly from the user pointer into the union
in the task_struct.

I'd love if we could only use fixed-width fields in the interface to
avoid the compat nonsense.

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/