Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Tue, 24 Oct 2023 08:24:21 -0700
From:   Tony Luck <tony.luck@intel.com>
To:     Jeshua Smith <jeshuas@nvidia.com>
Cc:     keescook@chromium.org, gpiccoli@igalia.com, rafael@kernel.org,
        lenb@kernel.org, james.morse@arm.com, bp@alien8.de,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org, linux-tegra@vger.kernel.org,
        treding@nvidia.com, jonathanh@nvidia.com
Subject: Re: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices
Message-ID: <ZTfhpRRA4bga0qSI@agluck-desk3>
References: <20230712223448.145079-1-jeshuas@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230712223448.145079-1-jeshuas@nvidia.com>
Precedence: bulk

On Wed, Jul 12, 2023 at 10:34:48PM +0000, Jeshua Smith wrote:
> Slow devices such as flash may not meet the default 1ms timeout value,
> so use the ERST max execution time value that they provide as the
> timeout if it is larger.
> 
> Signed-off-by: Jeshua Smith <jeshuas@nvidia.com>

> +/* ERST Exec max timings */
> +#define ERST_EXEC_TIMING_MAX_MASK      0xFFFFFFFF00000000
> +#define ERST_EXEC_TIMING_MAX_SHIFT     32

I've recently become a fan of <linux/bitfield.h> I think this would
be easier on the eyes as:

#define ERST_EXEC_TIMING_MAX	GENMASK_ULL(63, 32)

> +static inline u64 erst_get_timeout(void)
> +{
> +	u64 timeout = FIRMWARE_TIMEOUT;
> +
> +	if (erst_erange.attr & ERST_RANGE_SLOW) {
> +		timeout = ((erst_erange.timings & ERST_EXEC_TIMING_MAX_MASK) >>
> +			ERST_EXEC_TIMING_MAX_SHIFT) * NSEC_PER_MSEC;

then this becomes:

		timeout = FIELD_GET(ERST_EXEC_TIMING_MAX, erst_erange.timings) *
			  NSEC_PER_MSEC;

> +		if (timeout < FIRMWARE_TIMEOUT)
> +			timeout = FIRMWARE_TIMEOUT;

But that's just a matter of style.  Otherwise the patch looks fine.

Reviewed-by: Tony Luck <tony.luck@intel.com>

-Tony