Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <935d6e08-3754-4c06-ab25-69bda3fd8ea1@amd.com>
Date:   Tue, 24 Oct 2023 11:30:01 -0400
User-Agent: Mozilla Thunderbird
Cc:     yazen.ghannam@amd.com, oe-kbuild-all@lists.linux.dev,
        linux-kernel@vger.kernel.org, avadhut.naik@amd.com,
        john.allen@amd.com, william.roche@oracle.com
Subject: Re: [PATCH v2 1/2] RAS: Introduce AMD Address Translation Library
To:     kernel test robot <lkp@intel.com>, bp@alien8.de,
        linux-edac@vger.kernel.org, tony.luck@intel.com
References: <20231005173526.42831-2-yazen.ghannam@amd.com>
 <202310162015.fuitGuiJ-lkp@intel.com>
Content-Language: en-US
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <202310162015.fuitGuiJ-lkp@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2l6cmRIUWFhU0JDVnJKb2IvS2h3b0NYT1hwUnhFQlZuck9MRXpzREIzUGhv?=
 =?utf-8?B?TlczSWNEQUl3NWFaekpkMk5xS3lBQVBGSVNqQUxJMHZBdDdTSW5ieFQxdmNu?=
 =?utf-8?B?VWxUT3RIL2FKaDFWU0JXUjZacDFhNUNCMXphWUo2d2o0M3A2b1A3Sk85dmZE?=
 =?utf-8?B?bUxYWnhoSjBvU21MclkwOENSQ3NiV0ZZeFlTdk5wY0RIaWZ3cUd6enFSY09Q?=
 =?utf-8?B?ZThjRG9SQTNvS3ZSUmJudVp4aUNuTlNZNzU4MzQyNFhqanJlWXpqcjZaRmFE?=
 =?utf-8?B?Tk5tZ1pvbVB0ZUxTYXVranRQd29PcW5Jd2owK2RxK2dYRmw1cXJ2MDROZkIz?=
 =?utf-8?B?WG9rQi92cTV5YXR3SUk2L2FtYXhyc2c1MUdWVVl5ZzFJWElJcjFBRzZMMnZp?=
 =?utf-8?B?UUdLUlVCdmUvMFBoN2FIQ0hZVDhaOE5RR3lKVlRDRVRWeWJabjR3ZjdBKzZL?=
 =?utf-8?B?VVhtTTR2dG5JaHN1dVNPUThrRFlxWFNCSjFoWWtUcndXTnA3UVVrdnBOcXZl?=
 =?utf-8?B?N3Y2dURrYnhRczR6eDdpb3ZneVIzcXhTSjJrL0RuQkNmNVZ1bm5rMVBUYjdy?=
 =?utf-8?B?YVFaVDdjWjhJbVBpZEhaQmZPZjhuQmFaS3I0cHZ3OEtxQU94TjdEZnRFUXpL?=
 =?utf-8?B?cUFyc2Nuc0hVMDhDenRTMVBpRW9sYVV6QUo2aUxvZ0Zua0Ztd3RQK2ozY3h6?=
 =?utf-8?B?cXNCRDh6YnJlbWRCMGNHRWo1UVZRVXAvTDQyazRsSEFlVlJiWTBZQy9yNDFs?=
 =?utf-8?B?eDhKOWZYYllodiszTmpGM3EzU2RhVklRTFF2UUFNakdXeC90S2RoUEd6R3RQ?=
 =?utf-8?B?S3Q3cjZmNVZ0QjIrMXVzTEtGNHFRN3QvbWIxWTVhVDVuQmZzNUVnQkpxaTQw?=
 =?utf-8?B?ZU1yVHQvUXNETUxrVXN5aHFnM2NVaUJPVkkxeVM4VDFzdXRLQlozb1J4MVYw?=
 =?utf-8?B?QUp6TGlyaVpsRGFJV2grWnF1dEJMdVZ6cEd4K25RakFTRGZISUJJcm1VTnR5?=
 =?utf-8?B?MDNwcGRtbDdQem1NZy9YbEJyR2lJbnkxa0o3ZEd6b2FuRXVScVdWcVFiajFn?=
 =?utf-8?B?ZGRMeGE2T0JHbVNSTTZyc0NidkxGR2NUblcvOENEQzVzN2Fqczg2NHp2YWt0?=
 =?utf-8?B?MmVBaFl6ZjJPQ2tjT3BrSlZpaFlXSGpLbWt0MllGMGpsL1M5OWZOa3N3QlRk?=
 =?utf-8?B?VlpzeUdIMGFvZ2d0bEJNUXNkcnhibFJTUllLRno5VW0vc2V0Y0ZpQm5jVk5r?=
 =?utf-8?B?VE1uU25UOTRDSHJrTjVDSllYdzZnWkRxM01yK0lLODN0U01BNE5GVGwxTFhv?=
 =?utf-8?B?cTlhL3Y2RHRncEkrMHZyYXV5Wm9PUy9mdUFPWEtMcXg0Z1pQSllCeFpnR1RZ?=
 =?utf-8?B?b3k5aEJsQ0VqUEw4eVU3WDh5TCtCNzNEK3Jtc0lBOGJ5MStnc3U1S0hldnhP?=
 =?utf-8?B?R1pBVzF2b2VlMXpudnhxRGljWE1ReVVRVkN2MklhZ2dSZktrUWl4ZFZrZmFD?=
 =?utf-8?B?K1FUbUN3Mi9EWmFYbTh3aWhIWUhvV0RBRUFiLy9mcytIZEdxSExLL2ZOSzBm?=
 =?utf-8?B?ZTJOTzlTZ0tLYkkyM1N5NWk2L2hsNVBpa2hGQ3dCUHp5UFJrMEtVQy9pRzdY?=
 =?utf-8?B?N25jUWI2eXRIVllFR1JBdjJyMjY4dGNkV05UWm5VbmJ2bEVBSjlJcU1aR0dn?=
 =?utf-8?B?NW1uUHZUd1dJWU1zZThCbVd3a0YyTlhwVEY4M2lKNWkycHAybExYUmg0bnh1?=
 =?utf-8?B?MnVUQ3lGeGZxUG9xLzFTeUVWUGs2NWVWVGVzSy9ucWh1YWxvZDJBa1hlVGRN?=
 =?utf-8?B?ZXhlUExEM1ZZNlRqVkJzSXNjcDM3NENGc0pYc3lhWUxYMnkvNlMxQWFmVHZt?=
 =?utf-8?B?MmRYODNiSVRPeUhHdkdWNnpZVGJFM2VETnBURHRURXdoUEUxSGR0TVh2K0xW?=
 =?utf-8?B?Um5HRnVRRHJvNGNWKzZzVy9OcmwySmprVCtJMC9Edm45NllUZy9hb2M3RUpw?=
 =?utf-8?B?V09qeHQ2bUxCMUtPTEZNTjFuTXI5RUJTa3RWYVRUSUxkeHAvMkpmVGprUDNo?=
 =?utf-8?B?TWwwK1hEcVFPSjBWTm1XYWNLTm1leGI1Z1Jid3hUL1ZuWXM4ckIzblBoV1FE?=
 =?utf-8?Q?ybHZnyPzuVmULHRAApqHU4Gfe?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5085d3ff-78a1-419b-f107-08dbd4a617ee
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 15:30:04.1682
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vtArCCiu0wBr5swwEUDabHAEF/MnLmJDIur1MHeaXFh4cXtRX5qVzqLmvpbDQEYFUtbx3hHvcYIf63on3ULXhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9254
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 24 Oct 2023 08:31:16 -0700 (PDT)

On 10/16/2023 8:28 AM, kernel test robot wrote:
> Hi Yazen,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on ras/edac-for-next]
> [also build test ERROR on linus/master v6.6-rc6 next-20231016]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Yazen-Ghannam/RAS-Introduce-AMD-Address-Translation-Library/20231006-014458
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git edac-for-next
> patch link:    https://lore.kernel.org/r/20231005173526.42831-2-yazen.ghannam%40amd.com
> patch subject: [PATCH v2 1/2] RAS: Introduce AMD Address Translation Library
> config: i386-buildonly-randconfig-002-20231016 (https://download.01.org/0day-ci/archive/20231016/202310162015.fuitGuiJ-lkp@intel.com/config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231016/202310162015.fuitGuiJ-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202310162015.fuitGuiJ-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>     ld: drivers/ras/amd/atl/denormalize.o: in function `denormalize_address':
>>> denormalize.c:(.text+0x84f): undefined reference to `__umoddi3'
> 

This is the code of interest:
	addr_mod = temp_addr_b % 3;

"temp_addr_b" is a u64 value.

__umoddi3() takes "unsigned long" values as input. This works on x86_64 
where "unsigned long" is 64-bits, but will fail on i386 where "unsigned 
long" is 32-bits. I *think* __umodti3() should be used which takes 
"unsigned long long" values as input. This would work on both i386 and 
x86_64, since "unsigned long long" will be 64-bits.

I was able to reproduce the issue with GCC 9 and 10, and the issue is 
not present with GCC 11 and 12.

I'm assuming a compiler/linker issue at the moment. In particular, I 
wonder if gcc and ld need to be matched. I'm using a newer ld version 
(2.38), and this works with newer gcc versions (11 and 12) but fails 
with the older versions (9 and 10).

Any thoughts?

Thanks,
Yazen