Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <15e5ce3d-bdf0-4114-9df6-50105b0e3c73@intel.com>
Date:   Wed, 25 Oct 2023 00:14:51 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 02/10] iommu: Pass in parent domain with user_data to
 domain_alloc_user op
Content-Language: en-US
To:     Joao Martins <joao.m.martins@oracle.com>
CC:     <cohuck@redhat.com>, <eric.auger@redhat.com>,
        <nicolinc@nvidia.com>, <kvm@vger.kernel.org>,
        <mjrosato@linux.ibm.com>, <chao.p.peng@linux.intel.com>,
        <yi.y.sun@linux.intel.com>, <peterx@redhat.com>,
        <jasowang@redhat.com>, <shameerali.kolothum.thodi@huawei.com>,
        <lulu@redhat.com>, <suravee.suthikulpanit@amd.com>,
        <iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>, <zhenzhong.duan@intel.com>,
        <baolu.lu@linux.intel.com>, <joro@8bytes.org>,
        <alex.williamson@redhat.com>, <kevin.tian@intel.com>,
        <jgg@nvidia.com>, <robin.murphy@arm.com>
References: <20231024150609.46884-1-yi.l.liu@intel.com>
 <20231024150609.46884-3-yi.l.liu@intel.com>
 <b6b3bfca-f140-4ff1-86c5-69a302e5bfa0@oracle.com>
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <b6b3bfca-f140-4ff1-86c5-69a302e5bfa0@oracle.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXFsN0NOeGg0aWFPQyt3MnFiN3JLcStkZTZWZDZVc0lRYXNpYXVESmQwQlBI?=
 =?utf-8?B?K0tqR3RnVTlqTWtwTndLSFV3d3BEcC9OQTJIOEthK1dKa3Z2UnQrY2VrZW5H?=
 =?utf-8?B?WkQybERTR2pkalFOaXhsY0x4cjhBUm00M3d0L0FTMmFrWVRMTGJueXFJOTk5?=
 =?utf-8?B?M21iZCszL21sL1dwM3dlOFJQYXd6NTlHUzBRcG8zZ1JRT1V6NGthMEc0Mit2?=
 =?utf-8?B?cXBGMHNRdDZ0VGtLRTNQUnNRZDdkaWtoblBwNkxlUTlBbzBERnVzSmo4UFFF?=
 =?utf-8?B?eVlpVXd1RlZEdmlkZXJ2RWpIMTYwdUxyZThrZ216SXd3c3BqNjFzcGhucVVy?=
 =?utf-8?B?c3JMTS9zd0ZNbk1BME1EbU9RODdCSmo4dDFTWUI1U3IzbERwc2F1OEJWMTdq?=
 =?utf-8?B?VEdnK0lwUGcxY3IzWnpXamFMOXFqdTFFZWNIcjZNZkk0VmhDVzhZYTFEblhE?=
 =?utf-8?B?eXFCZ2duZDVDODBsYU9ISEMwWm5QbmlUVGt2d2wycm16VkZkZmtKd1dFTXNx?=
 =?utf-8?B?YUZMV1Q0K0JQUDV3OGdRTmdkOUZtYTZjWGI5WlFycGV0Ly9nNDFEcnZhRHh3?=
 =?utf-8?B?azUvc2pYMUQ2TnJWZllEeWF2WHk5eWVLRzZxdlpiWEhRODlCTVUzWjZkV1J4?=
 =?utf-8?B?NnJRS2NDbU1MbmNPUitZd3crSEhiL242VEZEUnFtVkx6QWtITEJsRnptdzcw?=
 =?utf-8?B?c25FZUhUNjlIczVwU2prQStjc1A5ZGdoSWxzbzduY0lpRkNDSkJUV2lVMmcz?=
 =?utf-8?B?TUdvZXBUT2FKRGdVbmdpV2g2Q3lIWW1DZVhzbUk1ZU5sK2VkUEwvTFgxTFRS?=
 =?utf-8?B?UmtESHhYTUdmUFNqcGNFUjJ4bUVTSVpicGhkSjN0VklUVCtrb0hKakd3U3ds?=
 =?utf-8?B?WGNRUEJBVzQ4eEpHd2JCTmVib1AyREFoNDAzRmhyRGNocncxMittMS9hQ1h6?=
 =?utf-8?B?c0ROQUIrTFdiSUFXZzY0SXRrMGFaY05XREtvQnpVSGtIMVN5eFZoZnFCaW5T?=
 =?utf-8?B?MllpVVBjSC93VDR6R21weUs0Y1pIM0dkbGhCanF3QnQyQkRzZHpjZkc0QlZ1?=
 =?utf-8?B?TmlYZ1c0MzB4Um9ueHF4d2JuZGVoaFpRaHdvYnZvdHczL1BiVGJ2c2xYdTlO?=
 =?utf-8?B?TjdEazc0MThJUFF6UkZEbFkyRjhRMVF6T3ZKMDZ5SWl0TmpMTmtxam83NFk4?=
 =?utf-8?B?STR0QllFaCtzQzhzc25TV0FFZnplZHNRTjh5RlZ0Y0J6VlZXMUFYWmhiejU3?=
 =?utf-8?B?UHFQWWFlV2J5WWhudVFpRTkrZnowekRkaHhJb3BlS3VoZEtUY3pqNnJ2bjRi?=
 =?utf-8?B?WSt4TG9jYkZzTXBxaVM3R1JzOUxNSXJYM1IwRU5FNXdqVmJ0eEJObytWM0do?=
 =?utf-8?B?Ymh4Q2pUb3NiRFV6QWpNaitPdmovTm81ZHdwbXlIaUJzLzkvdkVHTVMxczlr?=
 =?utf-8?B?MElUcjBraEk5eXUwWnJCVksydVlqMVVOQXFBMVFBT0ZUTWxHMXN6SEFlVEVz?=
 =?utf-8?B?SE82WFlTR0UzVWRPYW1aeTB2cmc2Tm8wSStBektBdE1sOWNmaUpoVlBneVZn?=
 =?utf-8?B?dTN2Z3RJK0hMemVvZnl3bWE3Y0dPK2ZTMUZLTGM1VzhqVnFUVlEyVzZITzFU?=
 =?utf-8?B?ZWVDNzlyTlFzbDFEVm1vaXRmREZXd3lpbG9pMVJ3L1pzSXQwR3haQTZQWnVF?=
 =?utf-8?B?cU03U3RkRld6QXp3UEx4YklCa2ZDcFVxNHV6UHM5cDlvT1JRbmNWdHFzMVR1?=
 =?utf-8?B?R2FINk1USUlHVFUxWTliN2FYblJic1lFRkFWTElWamJ1WDR2SjhQdCsreElu?=
 =?utf-8?B?VFVjWmF1cTFiTTJBd09oZGdNbXVvTms3dGJ1MURqL1g3a3FSK3NWcy9WcVk3?=
 =?utf-8?B?L3Uvb0llWFRQWUM5aGpLNUprN21BdVRsRVFJR2JGRHRUT0RpUHdMZ3V5aG5u?=
 =?utf-8?B?SXRYcUZWYXowYUZMOGR1Wm9kM0hZTk1GeDB5ZE9vL1h2U3pxMWROSDJYZXdD?=
 =?utf-8?B?cWlWK091Q2FnZDMveGdSbGtHNWllTDc0ZVdFWHFmbVVMNEFlZk1ZQUs2cGJi?=
 =?utf-8?B?bjd5ZGNQV0txaWJxU1dpbjBsa1FQbWNyelFlVklIWjdsM2Njb0RuYmpNME45?=
 =?utf-8?Q?bkWaV9pgA/5Ps7AB9r6R3V+Xd?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b839724a-fe5e-4f97-26e0-08dbd4ac031d
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 16:12:25.7971
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7tAzk99LC4T003CaNG8lCZe9LXBBI3z9y6sJqBtQdC8YhXdybXQssn2DTDv8pJAThOG1VCNsvC0kgQI+og1CrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5632
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 24 Oct 2023 09:13:24 -0700 (PDT)

On 2023/10/24 23:56, Joao Martins wrote:
> On 24/10/2023 16:06, Yi Liu wrote:
>> domain_alloc_user op already accepts user flags for domain allocation, add
>> a parent domain pointer and a driver specific user data support as well.
>>
>> Add a struct iommu_user_data as a bundle of data_ptr/data_len/type from an
>> iommufd core uAPI structure. Make the user data opaque to the core, since
>> a userspace driver must match the kernel driver. In the future, if drivers
>> share some common parameter, there would be a generic parameter as well.
>>
>> Define an enum iommu_hwpt_data_type (with IOMMU_HWPT_DATA_NONE type) for
>> iommu drivers to add their own driver specific user data per hw_pagetable.
>>
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>> Co-developed-by: Nicolin Chen <nicolinc@nvidia.com>
>> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
>> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
>> ---
>>   drivers/iommu/intel/iommu.c          |  7 ++++++-
> 
> You are sadly missing AMD IOMMU

good catch.

> 
> This would fix the build and nack the op should parent or user_data be passed:
> 
> diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
> index caad10f9cee3..bc747513afcb 100644
> --- a/drivers/iommu/amd/iommu.c
> +++ b/drivers/iommu/amd/iommu.c
> @@ -2220,13 +2220,17 @@ static struct iommu_domain
> *amd_iommu_domain_alloc(unsigned int type)
>   }
> 
>   static struct iommu_domain *amd_iommu_domain_alloc_user(struct device *dev,
> -                                                       u32 flags)
> +                                       u32 flags, struct iommu_domain *parent,
> +                                       const struct iommu_user_data *user_data)
>   {
>          unsigned int type = IOMMU_DOMAIN_UNMANAGED;
> 
>          if (flags & ~IOMMU_HWPT_ALLOC_DIRTY_TRACKING)
>                  return ERR_PTR(-EOPNOTSUPP);
> 
> +       if (parent || user_data)
> +               return ERR_PTR(-EOPNOTSUPP);
> +
>          return do_iommu_domain_alloc(type, dev, flags);
>   }

yes, this should work. @Jason, one more version or just this one with the
above diff from Joao?

-- 
Regards,
Yi Liu