Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2009524rda; Tue, 24 Oct 2023 09:32:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETgDWJcACtPVf4Wcca/7G8NPMeJtRltz8LuSx4prTLU3zmzaxRtGoqni42fPpREwhJQRue X-Received: by 2002:a17:903:2289:b0:1ca:86db:1d2f with SMTP id b9-20020a170903228900b001ca86db1d2fmr15867463plh.43.1698165160329; Tue, 24 Oct 2023 09:32:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698165160; cv=none; d=google.com; s=arc-20160816; b=p+1/NaFA60+xNs9Qsc8oJ9iwj0nVyybdeuFtM9lsQRSr+8Q+RiRGYMjXxGbhc5g4ck QtGp79Ari89UAGEw1+0uMozQ9DQQjnBh2qLIA+EQ93gJJkuTcJPA33zfgkej/h5Ttpt1 9InpBFT5Jo2M/yEKtoTu3Pe4NX90hH1aIU4CZRKAyrr01kdcL8DgAvQQCDa6rT8mlOgy fvGaXfBCHnZrkhAY6GgJALWcK1Le4zGk75WLaqeufHyCkzPQtu9n+rJzABd3Ji3vTVC/ fIgen/Q2gEnbWdVttN1j3hpjdw2+oSo/pEzPQBQnE4oKe43u/6/WTxUx7ZXmkqka1Vf0 WkfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=5GzmymUe1pax62z1VC7ZEkV0i3+BeKVhxznyxpe6Bzc=; fh=DxB7CKYthfhfTeJdartxS2j87kFiWV3H0EardCrLVMM=; b=Vae0Z6D6X9aHzNnSamYCFe7AV2gvl5pH0oSZGta7o2Ip5+T8W526lZx525qNCc+bKU i/cCieit0MuLDHwoSY1qSWNAEosa4Z0xvhQPn+t3z9WpmvEGiXs/qRhbXITvAw2h9oXM 1lprbfss60OIwBmqBoei7pEAGtz8E/WfKmhkv4tyLDSatwVHsldeuYotnkKj7vWp/H4x JeDqU/Ug+4QNlF7JAQogYQ7NbL1bG4c/YdBXmRNl9ECJBp88ph8XQyr/pNRbFng5e6ff u0W66WRX02mYu06FJMs8c+e732NxvpcjJsmM9P3DoC5j4w4tNuuJubSRaCRwetDoHGLm B3cg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=ICjE6g+c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id 10-20020a170902c20a00b001ca01fd8942si8243163pll.120.2023.10.24.09.32.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 09:32:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=ICjE6g+c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id B3A9A8087512; Tue, 24 Oct 2023 09:32:37 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343904AbjJXQc2 (ORCPT + 99 others); Tue, 24 Oct 2023 12:32:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343878AbjJXQc0 (ORCPT ); Tue, 24 Oct 2023 12:32:26 -0400 Received: from mail-pl1-x64a.google.com (mail-pl1-x64a.google.com [IPv6:2607:f8b0:4864:20::64a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FEA593 for ; Tue, 24 Oct 2023 09:32:25 -0700 (PDT) Received: by mail-pl1-x64a.google.com with SMTP id d9443c01a7336-1c9c83b656fso39212395ad.1 for ; Tue, 24 Oct 2023 09:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698165144; x=1698769944; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=5GzmymUe1pax62z1VC7ZEkV0i3+BeKVhxznyxpe6Bzc=; b=ICjE6g+cydha7Wn6DtkNeViEFuDtY8z9DIibvhF5DWf1ht+ZhFaFPzj54lNUJTPP6t NlxJAeGvAtPHAcrAgeQvDysSfmMAXi/izvDYadu330sV7BO7b4xRjTUC+944dCbp20Gd aiL4E6TQZsebG/VCupYh95QQKum43s+FnGJNmjjtkRnEAWC4iMGE7UHV44VQAEktU6ya rwQ/go4kjUkws5z969DI3WIyKwrp/GtqVBLyl1qgd5spIQe2L+tqOIsd6dFUJMXjIyHi mEiVuJsWC7hr/iw5qKA3KWCc+Pg9EIODTurZ621o8Amvh6OriIrj8VZb1bzPn9FSYNkb Zrwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698165144; x=1698769944; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5GzmymUe1pax62z1VC7ZEkV0i3+BeKVhxznyxpe6Bzc=; b=I4aenZAwIT7RLbeHqyN7Sa0D46OOjS0fB3VdqbTaESC95goHGumkE546bTLhIh43XJ Ssjr+zc8ta9WKgq+K4vSkc7v414XHj0DTKH0RSPmz6M+fo9sMlopzQr6OLNMObGazF4G ufPwFtZOaW8Z59Jqvh7bKirwPdA/ZSxYZpWAqz2TTAL6+p7xiSksgqOp7e8dBS2m9ahP K3bFyLKeUCBePeDfNyHl9Am3ptbSQBVSWPDNZA6j8FWS7V6bWyjYAjnDzgNfvcG0/eUP oB7x+flHQnbN8lK4mRAIW0fU4PIgp1tGCenXJJfK4M1nizuCCJ/REyP+uJxpDqoJn4ba ZFCw== X-Gm-Message-State: AOJu0YzzFoXM67+Fnmxtw18HQ53r1DXrxN0PgjrT7uaRhqxQzQo/GB2L XN/k4SaXIOUeFsDyoN+6fsHShL50jsw= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:d04b:b0:1ca:2285:3757 with SMTP id l11-20020a170902d04b00b001ca22853757mr177379pll.2.1698165144606; Tue, 24 Oct 2023 09:32:24 -0700 (PDT) Date: Tue, 24 Oct 2023 09:32:23 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230914063325.85503-1-weijiang.yang@intel.com> <20230914063325.85503-3-weijiang.yang@intel.com> Message-ID: Subject: Re: [PATCH v6 02/25] x86/fpu/xstate: Fix guest fpstate allocation size calculation From: Sean Christopherson To: Weijiang Yang Cc: pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, dave.hansen@intel.com, peterz@infradead.org, chao.gao@intel.com, rick.p.edgecombe@intel.com, john.allen@amd.com Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 24 Oct 2023 09:32:37 -0700 (PDT) On Tue, Oct 24, 2023, Weijiang Yang wrote: > On 10/21/2023 8:39 AM, Sean Christopherson wrote: > > On Thu, Sep 14, 2023, Yang Weijiang wrote: > > > Fix guest xsave area allocation size from fpu_user_cfg.default_size to > > > fpu_kernel_cfg.default_size so that the xsave area size is consistent > > > with fpstate->size set in __fpstate_reset(). > > > > > > With the fix, guest fpstate size is sufficient for KVM supported guest > > > xfeatures. > > > > > > Signed-off-by: Yang Weijiang > > > --- > > > arch/x86/kernel/fpu/core.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/x86/kernel/fpu/core.c b/arch/x86/kernel/fpu/core.c > > > index a86d37052a64..a42d8ad26ce6 100644 > > > --- a/arch/x86/kernel/fpu/core.c > > > +++ b/arch/x86/kernel/fpu/core.c > > > @@ -220,7 +220,9 @@ bool fpu_alloc_guest_fpstate(struct fpu_guest *gfpu) > > > struct fpstate *fpstate; > > > unsigned int size; > > > - size = fpu_user_cfg.default_size + ALIGN(offsetof(struct fpstate, regs), 64); > > > + size = fpu_kernel_cfg.default_size + > > > + ALIGN(offsetof(struct fpstate, regs), 64); > > Shouldn't all the other calculations in this function also switch to fpu_kernel_cfg? > > At the very least, this looks wrong when paired with the above: > > > > gfpu->uabi_size = sizeof(struct kvm_xsave); > > if (WARN_ON_ONCE(fpu_user_cfg.default_size > gfpu->uabi_size)) > > gfpu->uabi_size = fpu_user_cfg.default_size; > > Hi, Sean, > Not sure what's your concerns. > From my understanding fpu_kernel_cfg.default_size should include all enabled > xfeatures in host (XCR0 | XSS), this is also expected for supporting all > guest enabled xfeatures. gfpu->uabi_size only includes enabled user xfeatures > which are operated via KVM uABIs(KVM_GET_XSAVE/KVM_SET_XSAVE/KVM_GET_XSAVE2), > so the two sizes are relatively independent since guest supervisor xfeatures > are saved/restored via GET/SET_MSRS interfaces. Ah, right, I keep forgetting that KVM's ABI can't use XRSTOR because it forces the compacted format. This part still looks odd to me: gfpu->xfeatures = fpu_user_cfg.default_features; gfpu->perm = fpu_user_cfg.default_features; but I'm probably just not understanding something in the other patches changes yet.