Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <16225a07-c0da-4970-b0a1-39831b1bf616@amd.com>
Date:   Tue, 24 Oct 2023 12:33:23 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] drm/client: Convert drm_client_buffer_addfb() to
 drm_mode_addfb2()
To:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Javier Martinez Canillas <javierm@redhat.com>
References: <4b84adfc686288714e69d0442d22f1259ff74903.1697379891.git.geert@linux-m68k.org>
Content-Language: en-US
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <4b84adfc686288714e69d0442d22f1259ff74903.1697379891.git.geert@linux-m68k.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SG5XZVd0bCsyVkxHNE9KeTQ3QkdJdWdLYWlUMGxISG1NOUdHV3hVNGViL1dR?=
 =?utf-8?B?WU8wMGNZcHN2c2tDdVNrbjZaalZncjFLdG1yRXZYS01HeEhFTzQxUzRvVlVO?=
 =?utf-8?B?NERDQTBmMEZwdEk1bVozZEMvc2VZVlRVenZZQ3FPOFBuZmpUZVdvTWUvelJG?=
 =?utf-8?B?bFBGNWpyTk94eGEzQllnWC92b01ray81cWlweG9VNkZkRjdZbmhsNFdNTUx4?=
 =?utf-8?B?QndZNnhISUhLSzY0Mi9uY3ZBL0dqc2xGMG5UUGtudXU3b2RxVnUza1BOMlJF?=
 =?utf-8?B?dXR6SU94NC8vckFDb2JRYjI1M3lxSXByajc0QWFWL3lCQWhIaGMrV2ZOWlBm?=
 =?utf-8?B?K3dJTVk3WlJrdWh4cHMxOXJ1NHU3NGZpZGZvVjF5MVZwYVJFeHB3aFNkd3BT?=
 =?utf-8?B?VXlSOEdLTkRRU0dwbWFiY3FaMEFWcnlmWE9RVUoxODBMU25MNlkwNXJSL0tR?=
 =?utf-8?B?cFE5amtESGdoV3pydlJvTS9qTXhhZGxMdENGeXkxdTNMeUNwRFU5Umt0ZU11?=
 =?utf-8?B?RjNVVi9ROUxDeDdNYUdkTWg2Uzl6M3h2cEczN0p2ZTEzeDFMVjk2bVFlZlFV?=
 =?utf-8?B?NzhvMFlVUVVlZ1gwSE9uQnJMWmNxb3hLc0RQaktQaHJUZFFVOURlbktGY29B?=
 =?utf-8?B?YVBHVzhXQ1lxRHhaNTM2Q2JtRTRRMXJTRWtybjQ2Y2NLa05VcEVvY0d0ZnMw?=
 =?utf-8?B?YXIrS2JJN3YyM2J1dlBQaGNNUld3eEdub2Z6L2Z4djd0M1N3L3lYaDVrVzBq?=
 =?utf-8?B?RWllYWVzSGNpRGZMWDRvcVRVVmNnZFpJclk4VUxYbUNCamJQeUZpSVpqR3RX?=
 =?utf-8?B?NGJISEtJbFA4OTUzTU5EYWpoQVpqMXJZUi9MUVBRUTlzNlV4bnZUanhQT3p4?=
 =?utf-8?B?aHBvMFVjQy9NQk5WK1lGb1UwQm5VeDVsakJlQTY5MXlHdkdLZFIraTdnR3pk?=
 =?utf-8?B?UE93L2NDbk9LUXV6ZEtjZ2c4M3ZkT09vS3VxME9nV3Q1MWsxSVVWQnRLRjZy?=
 =?utf-8?B?WGJXbm5hKzhzYWdHYTRuc05obnZ5dFlFSGNPUW5xZTludjNLZjNHTTIxVEZk?=
 =?utf-8?B?SzRRTUZjRFVUMEk2bG5uL1l3dStqblpNNVBGb0hERURzb0QvcjFKQ0FnbDVz?=
 =?utf-8?B?RkdJWVBUQllBaW91WEVQa1BvRE5aR2R0ZElJTFVQZDZRcy9TVU5NYjNreXdP?=
 =?utf-8?B?Ry9LbTdaT2hzQTBpZVFVaFFvdXlmb3g1dlNydXFkZjhPT2VpUWFFd2E2aFRr?=
 =?utf-8?B?NkloR2JpQUVFV0wyN28zc21jdmowOWRBTWgrNXpOQkxNV05hL204S3h4R3Nh?=
 =?utf-8?B?ZGpTWDVpMW5za2dlSkhuNDZvalpqdTd2LzlYUjVDcjFUZGc1Y2xSSDUySFpS?=
 =?utf-8?B?MmVGM01uK1dMUktFdWdGSnBsVmkySXNDdVU3YTEvcDR1TFQ5WVNNQ1ZkZEg3?=
 =?utf-8?B?dzZvQnBvN3pEYWJFaDRCRktVL2tqNmgyeE83YWc2REJDZ0tlMG43Nkc1UzF2?=
 =?utf-8?B?Qi90ZG5qYkh6R1lRdS8yaVdPVmJsazdiUUI5eW5CVjN6TnNRSEJGR08zVW5a?=
 =?utf-8?B?bURtVkFRK1U4NXpEZksxMWF0ODRaR0Y2VnRRS0dxNDdabWxBZjhMMXl3YjRl?=
 =?utf-8?B?YnZQeUo5UE85Rk9PeVhha0lWb3VvY0kwVWgwcCtOWnQvb2YvZldMdGpSMTRK?=
 =?utf-8?B?dnNhaTBhemZNaFdYRlh0QVBuTVdtS3dreUNDYkRKdUVNUlRvSXlZWFRTQldl?=
 =?utf-8?B?QkVmOHN0SFI0WjdlOHdLVUZicUczWDJXR1ozbkt3dHdpS05JcjZJbURvWG1R?=
 =?utf-8?B?Z1pWaDdZUlZrcHBxL001TDIyREo5VUNpaGNWRXVOeVVpRDZSeHI5R3d0REJY?=
 =?utf-8?B?U2syVEhrczFyaWN0VXJKSkl6SFluUno1bWRXKzlnRmNQeWdOWHZkSGZsYi94?=
 =?utf-8?B?SnNjTERjOFFHOTNjRm9OeWRydE05d0NjTXJNcWxabm1uRlZhRUV4bFRBa0NJ?=
 =?utf-8?B?Nzl5WTR3WjdLcWJEL2ljRE03dDZCUzJaUlBBWGt0emhZZHBZMWs2N0VNbWEw?=
 =?utf-8?B?cldZWWVVdDJvUVNIZ3lHSXJiVzRiRlJlMXp2UnpzV0lNUVF6bXdzYXNOZjJC?=
 =?utf-8?Q?KA89Iy1Ucz++cHNXS9ZLuqSWA?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8404caf7-e4c9-4c4a-7a28-08dbd4aef293
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 16:33:26.3566
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: faeXnnn+PKnb7cDypAEafTUP4I08f7duvwEw1hJn2QWZbZSKXPNRz5uYOzhvA1+7KDQs27TGEnraUj6aHKKQWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7973
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 24 Oct 2023 09:33:41 -0700 (PDT)

On 10/15/23 10:27, Geert Uytterhoeven wrote:
> Currently drm_client_buffer_addfb() uses the legacy drm_mode_addfb(),
> which uses bpp and depth to guess the wanted buffer format.
> However, drm_client_buffer_addfb() already knows the exact buffer
> format, so there is no need to convert back and forth between buffer
> format and bpp/depth, and the function can just call drm_mode_addfb2()
> directly instead.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> Tested-by: Javier Martinez Canillas <javierm@redhat.com>

Applied and pushed to drm-misc-next, thanks!

> ---
> v3:
>    - Extract from series "[PATCH v2 0/8] drm: fb-helper/ssd130x: Add
>      support for DRM_FORMAT_R1"
>      (https://lore.kernel.org/all/cover.1692888745.git.geert@linux-m68k.org),
>      as this patch has merits on its own,
> v2:
>    - Add Reviewed-by, Tested-by,
>    - s/drm_mode_create_dumb/drm_client_buffer_addfb/ in one-line summary.
> ---
>   drivers/gpu/drm/drm_client.c | 13 +++++--------
>   1 file changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
> index d4296440f297fc5a..a780832a0963fe38 100644
> --- a/drivers/gpu/drm/drm_client.c
> +++ b/drivers/gpu/drm/drm_client.c
> @@ -395,19 +395,16 @@ static int drm_client_buffer_addfb(struct drm_client_buffer *buffer,
>   				   u32 handle)
>   {
>   	struct drm_client_dev *client = buffer->client;
> -	struct drm_mode_fb_cmd fb_req = { };
> -	const struct drm_format_info *info;
> +	struct drm_mode_fb_cmd2 fb_req = { };
>   	int ret;
>   
> -	info = drm_format_info(format);
> -	fb_req.bpp = drm_format_info_bpp(info, 0);
> -	fb_req.depth = info->depth;
>   	fb_req.width = width;
>   	fb_req.height = height;
> -	fb_req.handle = handle;
> -	fb_req.pitch = buffer->pitch;
> +	fb_req.pixel_format = format;
> +	fb_req.handles[0] = handle;
> +	fb_req.pitches[0] = buffer->pitch;
>   
> -	ret = drm_mode_addfb(client->dev, &fb_req, client->file);
> +	ret = drm_mode_addfb2(client->dev, &fb_req, client->file);
>   	if (ret)
>   		return ret;
>   
-- 
Hamza