Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Tue, 24 Oct 2023 14:23:43 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Yi Liu <yi.l.liu@intel.com>
Cc:     joro@8bytes.org, alex.williamson@redhat.com, kevin.tian@intel.com,
        robin.murphy@arm.com, baolu.lu@linux.intel.com, cohuck@redhat.com,
        eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org,
        mjrosato@linux.ibm.com, chao.p.peng@linux.intel.com,
        yi.y.sun@linux.intel.com, peterx@redhat.com, jasowang@redhat.com,
        shameerali.kolothum.thodi@huawei.com, lulu@redhat.com,
        suravee.suthikulpanit@amd.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        zhenzhong.duan@intel.com, joao.m.martins@oracle.com
Subject: Re: [PATCH v6 02/10] iommu: Pass in parent domain with user_data to
 domain_alloc_user op
Message-ID: <20231024172343.GP3952@nvidia.com>
References: <20231024150609.46884-1-yi.l.liu@intel.com>
 <20231024150609.46884-3-yi.l.liu@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231024150609.46884-3-yi.l.liu@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SCAzC31R/3p/rtI8mKlTIlyzZ0M8MP6OWoxZK2i5VwYx/JW9Qv+e1k9XM1PO?=
 =?us-ascii?Q?YadtoHCVhGKrikHIMQR7ARF73w2c2CK1LYFLOzS9ltvL6i8PH0Rc6BAzvrhY?=
 =?us-ascii?Q?LrwPUEG+alGDMSKZFBvw0EVc8/jMrF9NsOOyXTe2G+41EU4fs9aCHc0hwIzX?=
 =?us-ascii?Q?mHjrXsLgCCrZdQtYFJBa6A2DvVyfPsLpWcDyJbvogroQbnv+y5GDGxr/fmpn?=
 =?us-ascii?Q?gbnIC61Ba21orq8PP2KU4v5+2HeR56uiGZwVaEhXp6InkgF+CfXSoewaoL+j?=
 =?us-ascii?Q?IXOtGcQMVNNNckEpIHwiTP5miRUnNoYMrVS4oZTjArSQGjcyMuM47Q90Dxef?=
 =?us-ascii?Q?Xm5dFLyVUQXDqyaE/n1pXxUnok+ELU0x/s3H8OlcZY59uIanbhklPm20nez3?=
 =?us-ascii?Q?vcAa5xUdkJs9V9RPJg2YX2w8Uay7qP3O89Zb+/mt8dwrYsDrvlbNjpNHvuWq?=
 =?us-ascii?Q?w1KJsfu108qG1iGCcOo/88GL+gpehL/bbYcTp53S8JR2WfISxrHs7eL+ek+R?=
 =?us-ascii?Q?fhcK0ZvlW/c5aB2LX0sW0fJsbdVp5hAokVF5eBT/MHYOM6GUPXE0WbUmbyOe?=
 =?us-ascii?Q?6TaxaNrN7fR9CLWmGP9NAwkW0DEZnhLoN/L7emXhk7ZC+DQXGJlPP4t5JQLR?=
 =?us-ascii?Q?lgQC8ZwTIAjIaQweY//a4QzH/DBFAlpd+Hd6ylalXzboH2/9xlPXi7bd0Hra?=
 =?us-ascii?Q?ncVYEiC1NQTl7MsknEg1kyTVGPJfIVUT4xDKGomwRembaTUF25PjYLSzO9J2?=
 =?us-ascii?Q?9p9cmFVCGOHeWerJmi35SJnJBifYldutXF2e+Wa0xp71hw6zxq2l09IzDbv7?=
 =?us-ascii?Q?Tr309PnlKtnu+eBmvIxnWt8NA78JkAJ5vmvk1GiaXFa8LpL9uT2RisYtFm2a?=
 =?us-ascii?Q?JQM3m3akMw/gTrk5UgIdZvInibpRXBPTih8bH8KYIzJIVs6J9/hHBZIb+B7V?=
 =?us-ascii?Q?2OXGVaUEUN+L31ic9mUMvYbYjdABBv0MkYtg4YnH7hK+U2oG2slNPBpskTEJ?=
 =?us-ascii?Q?nLxKymOEhYBf+VOQjxTWiBitLTc/dhzuebTaX6ycGAb5F3iBbEY9P8l4YPON?=
 =?us-ascii?Q?8nxJMwnsqh0s6G9tt1CcxWM0PdaVzMlRJWy4ZmXxGyTIcgPKbIz9m70d7HpP?=
 =?us-ascii?Q?8XrmHKVxubUeYkiqIQkiOBAXhs/MOf5laKpDEIBItoorrZIfJ5u5Vz2i7ihs?=
 =?us-ascii?Q?A2jLwiH1XSHBvavAja8Nrf+9yraM+VIRoWaXc+SbErTdgJLJD4M1bPyLc2zW?=
 =?us-ascii?Q?XmtCpyPN47oBmrpSakngg2eKNFKKYmmU+6t2vVtfx6rr2fHkunGXtA+LHWtx?=
 =?us-ascii?Q?ZNUWh7ZPmpzJJ+ZbrmriTFfOOWntMX2o77W8/fsZGwiHrjfXRIY/CHNuv0vG?=
 =?us-ascii?Q?RWBGXsrOSXQCMt9OBrH4YHPIhFj8QWYpMO1JpIVa90yd/uyjB1dPT/BXbaEB?=
 =?us-ascii?Q?2i+8jVW6xPZzaBtwu/7WDRQ25GoVwY8mYjBisTNzVCA+V8MW++GHW0bIoOEQ?=
 =?us-ascii?Q?oMfDR1eu3rqO4TW1WUh6rGx9oFBgMfu4x7h9lVE/6wqpLwU6+tyiLO+JIkAK?=
 =?us-ascii?Q?wooz5Ort2H53VQ/qv2KxUdKy+g+LtJYz7HPdP7sG?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77066647-f96d-48c5-d276-08dbd4b5f9cf
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 17:23:45.0549
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G3ypnoF9pgkaD/tr9k5px15cgRET6WpHXS4A8q7gjRr5AiitEYNBNEo4DZzwFwzc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4444
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 24 Oct 2023 10:24:15 -0700 (PDT)

On Tue, Oct 24, 2023 at 08:06:01AM -0700, Yi Liu wrote:
> domain_alloc_user op already accepts user flags for domain allocation, add
> a parent domain pointer and a driver specific user data support as well.
> 
> Add a struct iommu_user_data as a bundle of data_ptr/data_len/type from an
> iommufd core uAPI structure. Make the user data opaque to the core, since
> a userspace driver must match the kernel driver. In the future, if drivers
> share some common parameter, there would be a generic parameter as well.
> 
> Define an enum iommu_hwpt_data_type (with IOMMU_HWPT_DATA_NONE type) for
> iommu drivers to add their own driver specific user data per hw_pagetable.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Co-developed-by: Nicolin Chen <nicolinc@nvidia.com>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> ---
>  drivers/iommu/intel/iommu.c          |  7 ++++++-
>  drivers/iommu/iommufd/hw_pagetable.c |  3 ++-
>  drivers/iommu/iommufd/selftest.c     |  7 ++++++-
>  include/linux/iommu.h                | 27 ++++++++++++++++++++++++---
>  include/uapi/linux/iommufd.h         |  8 ++++++++
>  5 files changed, 46 insertions(+), 6 deletions(-)

This patch should be immediately before "iommufd: Add a nested HW
pagetable object"

Since it is basically preperation for that patch

> diff --git a/include/uapi/linux/iommufd.h b/include/uapi/linux/iommufd.h
> index c44eecf5d318..fccc6315a520 100644
> --- a/include/uapi/linux/iommufd.h
> +++ b/include/uapi/linux/iommufd.h
> @@ -361,6 +361,14 @@ enum iommufd_hwpt_alloc_flags {
>  	IOMMU_HWPT_ALLOC_DIRTY_TRACKING = 1 << 1,
>  };
>  
> +/**
> + * enum iommu_hwpt_data_type - IOMMU HWPT Data Type
> + * @IOMMU_HWPT_DATA_NONE: no data
> + */
> +enum iommu_hwpt_data_type {
> +	IOMMU_HWPT_DATA_NONE,
> +};
> +

And this hunk should go in "iommufd: Add a nested HW pagetable object"

With the rest of the uapi

Jason