Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Tue, 24 Oct 2023 17:45:43 +0000
To:     John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
From:   Peter Lafreniere <peter@n8pjl.ca>
Cc:     linux-sh@vger.kernel.org, jack@suse.cz,
        reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Peter Lafreniere <peter@n8pjl.ca>
Subject: Re: [PATCH 3/7] arch: sh: remove ReiserFS from defconfig
Message-ID: <4hN-jE1ySe2eSmIJ6qWQKPQtp9vdgV2x0ek_nz20azJUyv5FLi5gioHV8YnJHTHHwZKvjSkvnPBhzmFJ2gQIeNnmaRA3cJ_GyhDqz2SJJkw=@n8pjl.ca>
In-Reply-To: <ee30c656c3e3b027edcfa4bc2947cea192f5cd2d.camel@physik.fu-berlin.de>
References: <20230918175529.19011-1-peter@n8pjl.ca> <20230918175529.19011-4-peter@n8pjl.ca> <ee30c656c3e3b027edcfa4bc2947cea192f5cd2d.camel@physik.fu-berlin.de>
Feedback-ID: 53133685:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Oct 24, 2023 at 12:46, John Paul Adrian Glaubitz wrote:
> Hi Peter!
>=20
> On Mon, 2023-09-18 at 17:56 +0000, Peter Lafreniere wrote:
>=20
> > ReiserFS has been deprecated for a year and a half, yet is still built
> > as part of a defconfig kernel.
> >=20
> > According to commit eb103a51640e ("reiserfs: Deprecate reiserfs"), the
> > filesystem is slated to be removed in 2025. Remove it from the defconfi=
g
> > profiles now, as part of its deprecation process.
> >=20
> > Signed-off-by: Peter Lafreniere peter@n8pjl.ca
> > ---
> > arch/sh/configs/landisk_defconfig | 1 -
> > arch/sh/configs/titan_defconfig | 1 -
> > 2 files changed, 2 deletions(-)
> >=20
> > diff --git a/arch/sh/configs/landisk_defconfig b/arch/sh/configs/landis=
k_defconfig
> > index 541082090918..af1ab25227e3 100644
> > --- a/arch/sh/configs/landisk_defconfig
> > +++ b/arch/sh/configs/landisk_defconfig
> > @@ -94,7 +94,6 @@ CONFIG_USB_SISUSBVGA=3Dm
> > CONFIG_EXT2_FS=3Dy
> > CONFIG_EXT3_FS=3Dy
> > # CONFIG_EXT3_DEFAULTS_TO_ORDERED is not set
> > -CONFIG_REISERFS_FS=3Dy
> > CONFIG_ISO9660_FS=3Dm
> > CONFIG_MSDOS_FS=3Dy
> > CONFIG_VFAT_FS=3Dy
> > diff --git a/arch/sh/configs/titan_defconfig b/arch/sh/configs/titan_de=
fconfig
> > index 871092753591..50e378adc4c5 100644
> > --- a/arch/sh/configs/titan_defconfig
> > +++ b/arch/sh/configs/titan_defconfig
> > @@ -221,7 +221,6 @@ CONFIG_EXT2_FS=3Dy
> > CONFIG_EXT3_FS=3Dy
> > # CONFIG_EXT3_DEFAULTS_TO_ORDERED is not set
> > # CONFIG_EXT3_FS_XATTR is not set
> > -CONFIG_REISERFS_FS=3Dm
> > CONFIG_XFS_FS=3Dm
> > CONFIG_FUSE_FS=3Dm
> > CONFIG_ISO9660_FS=3Dm
>=20
>=20
> What has been the feedback so far on this? Do most maintainer remove it o=
r not?

AFAICT, it's been picked up by mips and powerpc. I thought that it got pick=
ed up by UML too,
but I can't find any signs of that actually happening.

>=20
> I don't have a strong opinion on this, but I tend to keep it in defconfig=
 until
> ReiserFS has been completely removed from the kernel.

Is convenience more important than a slim defconfig? I don't think it is in=
 this case,
but Geert (for example) thinks it is. In the end the fs will be gone for go=
od, and
none of this will really have mattered.

>=20
> Adrian

Cheers,
Peter