Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
References: <20230712223448.145079-1-jeshuas@nvidia.com> <ZTfhpRRA4bga0qSI@agluck-desk3>
In-Reply-To: <ZTfhpRRA4bga0qSI@agluck-desk3>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Tue, 24 Oct 2023 20:51:57 +0200
Message-ID: <CAJZ5v0j2mbKOqDaL_31fL9ftTZRhUiURx3nubLmLUo3-R_w3gw@mail.gmail.com>
Subject: Re: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices
To:     Tony Luck <tony.luck@intel.com>, Jeshua Smith <jeshuas@nvidia.com>
Cc:     keescook@chromium.org, gpiccoli@igalia.com, rafael@kernel.org,
        lenb@kernel.org, james.morse@arm.com, bp@alien8.de,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org, linux-tegra@vger.kernel.org,
        treding@nvidia.com, jonathanh@nvidia.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Tue, Oct 24, 2023 at 5:27 PM Tony Luck <tony.luck@intel.com> wrote:
>
> On Wed, Jul 12, 2023 at 10:34:48PM +0000, Jeshua Smith wrote:
> > Slow devices such as flash may not meet the default 1ms timeout value,
> > so use the ERST max execution time value that they provide as the
> > timeout if it is larger.
> >
> > Signed-off-by: Jeshua Smith <jeshuas@nvidia.com>
>
> > +/* ERST Exec max timings */
> > +#define ERST_EXEC_TIMING_MAX_MASK      0xFFFFFFFF00000000
> > +#define ERST_EXEC_TIMING_MAX_SHIFT     32
>
> I've recently become a fan of <linux/bitfield.h> I think this would
> be easier on the eyes as:
>
> #define ERST_EXEC_TIMING_MAX    GENMASK_ULL(63, 32)
>
> > +static inline u64 erst_get_timeout(void)
> > +{
> > +     u64 timeout = FIRMWARE_TIMEOUT;
> > +
> > +     if (erst_erange.attr & ERST_RANGE_SLOW) {
> > +             timeout = ((erst_erange.timings & ERST_EXEC_TIMING_MAX_MASK) >>
> > +                     ERST_EXEC_TIMING_MAX_SHIFT) * NSEC_PER_MSEC;
>
> then this becomes:
>
>                 timeout = FIELD_GET(ERST_EXEC_TIMING_MAX, erst_erange.timings) *
>                           NSEC_PER_MSEC;
>
> > +             if (timeout < FIRMWARE_TIMEOUT)
> > +                     timeout = FIRMWARE_TIMEOUT;
>
> But that's just a matter of style.  Otherwise the patch looks fine.
>
> Reviewed-by: Tony Luck <tony.luck@intel.com>

Applied as 6.7 material, thanks!