Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2096873rda; Tue, 24 Oct 2023 12:10:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHh3rf5A7YQxfFsbV7KPceI2BPNMWs4KI3Bki445jkgK60IvWnJgUYUPnteTUpjTyTXYCEB X-Received: by 2002:a05:6a20:7f9c:b0:173:f8c9:94ef with SMTP id d28-20020a056a207f9c00b00173f8c994efmr4989222pzj.41.1698174636000; Tue, 24 Oct 2023 12:10:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698174635; cv=none; d=google.com; s=arc-20160816; b=g8thKwFRsDAg/dzbis1dXAUxrxNttcsWC+GRo+IplqrVkXYxvXiPEdlE87QJyLabek WgxJiW1H/5phVbeubX2UojYYlLKAbgvOCbRbiiSpjaCrK/jy67uzz2NEMXKJ5PpUuQxR uFK2Du6Ir9IT90rZlTzXxZT+rdr2914AZYyWp5SlIQD2GqEzs4YTG9yV0wMAx7F7sFnV YZe2/GsdtNKnwkJ010oDX2Jc4ZMR47ev/PImmPcgF07Ngkm7lJ6ftlWJyEZoWaJBIZoC BnBRGqheuw2TanGrYWlsimHUEP8mjAf+chsfj1MinoB6rt9jOtsoOjCzV7a6iOIaLaID DZeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CcYN0ghF9X6sw5kIsRrOufVya1UPw6CAWtwUBGA08zQ=; fh=GOsa8F24+MtjXStpkMMOXboEdQI7NAG5aXV0YSmfysM=; b=OHWWg4zTo8+jK48pM2bwNv9jQQz3yY6FLfAuAuuOayWmuKc+TR2Wn+kPfjDf2rGUNZ PiCjz70aYi8Ooif4ouUi/+z2Lhctye6V4J3L3Kphe77kFT1SX1ybqk/Bc1lHC7uUm86S 6ehYc5EIio9kO2esr1ooBgTZu3kJY/fqHQCugntuEruPBQxu/kp2CAw4bPRKWEJ73Vz7 ky2ICS7pTZEw4fqLJWjUQ144XFzsGeoruotYJjaPQVJ4vKDUu9oE9CF1B5UK9N5ehhSk 3GXdl34pRFRBw9Fc9EGo/jOw9v1KhtXhoqX3LkaCDKgypH02L0nOC30bMTUW5KmAMRTl 3O1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=UYvc3HSA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id l190-20020a6388c7000000b005b861446521si8550360pgd.281.2023.10.24.12.10.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 12:10:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=UYvc3HSA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 9700C80216A3; Tue, 24 Oct 2023 12:10:32 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344235AbjJXTK0 (ORCPT + 99 others); Tue, 24 Oct 2023 15:10:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343884AbjJXTKX (ORCPT ); Tue, 24 Oct 2023 15:10:23 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91AE710C3; Tue, 24 Oct 2023 12:10:21 -0700 (PDT) Received: from arisu.hitronhub.home (unknown [23.233.251.139]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: detlev) by madras.collabora.co.uk (Postfix) with ESMTPSA id B43936607333; Tue, 24 Oct 2023 20:10:19 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698174620; bh=QzXZQ5qW45emjNZOoZBacDZXLZ1f0TmfU80OiA4TC/E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UYvc3HSAZvat0g51dUgwMnhIxMzTeig7f+ZRkCB+EbDN/SJLW34szjzL56d22Gp/J szJIoheeTE8w2mXrAj2lyu7Gs5PPUpJ/03vc3Zb5qfghWf7C9NeHSOtjksAVyrKQrR NV9V9dOUrSoRItv3hi/Xs8gKC1PDCuxI1ZlfRe8m9oZoyMgTDod5PB3QabOGuTv0U1 0miFeOdpiydJDk33YtmXLbzJPbaYNsoPanqP+2dzbzWOifdDbBHaQwN/y6ulr62xOi C0WGxZ4/TeZhRYumDIDXRoZNN6W/srooulskWly3Qq3MJ7Jmcx6GThxBXn8m+3ab6o pSFaRocKP16Og== From: Detlev Casanova To: linux-kernel@vger.kernel.org Cc: linux-media@vger.kernel.org, Daniel Almeida , Mauro Carvalho Chehab , Detlev Casanova Subject: [PATCH v2 1/5] media: visl: Fix params permissions/defaults mismatch Date: Tue, 24 Oct 2023 15:09:46 -0400 Message-ID: <20231024191027.305622-2-detlev.casanova@collabora.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231024191027.305622-1-detlev.casanova@collabora.com> References: <20231024191027.305622-1-detlev.casanova@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 24 Oct 2023 12:10:32 -0700 (PDT) `false` was used as the keep_bitstream_buffers parameter permissions. This looks more like a default value for the parameter, so change it to 0 to avoid confusion. Reviewed-by: Daniel Almeida Signed-off-by: Detlev Casanova --- drivers/media/test-drivers/visl/visl-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/test-drivers/visl/visl-core.c b/drivers/media/test-drivers/visl/visl-core.c index 9970dc739ca5..df6515530fbf 100644 --- a/drivers/media/test-drivers/visl/visl-core.c +++ b/drivers/media/test-drivers/visl/visl-core.c @@ -74,7 +74,7 @@ MODULE_PARM_DESC(visl_dprintk_nframes, " the number of frames to trace with dprintk"); bool keep_bitstream_buffers; -module_param(keep_bitstream_buffers, bool, false); +module_param(keep_bitstream_buffers, bool, 0); MODULE_PARM_DESC(keep_bitstream_buffers, " keep bitstream buffers in debugfs after streaming is stopped"); -- 2.41.0