Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2101177rda; Tue, 24 Oct 2023 12:18:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF7DW6Fjm/O6mhHG3GwlGTkJCStPZWT7H5AfSWCVwuHywsNy1nnwrNvf47XQ0AI2cdwL9Zy X-Received: by 2002:a17:902:dac5:b0:1ca:117b:455b with SMTP id q5-20020a170902dac500b001ca117b455bmr14174814plx.46.1698175097726; Tue, 24 Oct 2023 12:18:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698175097; cv=none; d=google.com; s=arc-20160816; b=Lgpe09gQHDKn3zo0V76IHPN4OZdd7EHB81ei03anakgCBipCYTmyHfR2rLbHh0a9c7 AsfA1+VIfvxmoQT7FiMCJC3eyHoGyWY4ifjGTucrgFezc65J9kWWZy1EhtUPwnVuEkuZ p6gvxxZPefJQPBIEzuXEjWl1Ss5t5V1CdBZFZ4Fkm/Zqmf0Qrg8UjkJzACbE+U0ODcF1 SZtr5AHtTW+7087pN28w1Uw8HYzGg21YoP4E4zSf9BpXb15eRNeyDvzxj09FJd47kYvv qQvgjJFsAviVlXV3Qmdk5zlA2vXXB/g8ZHZh1SwaMDkMQXOYvjVnMr+Xo105qA4mvKnW Gn8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=f0gSlcazosuId5o39zqMt/BAF2zN8rgfhFC/S3R/4ms=; fh=joAbCF6BHnuBGmcA+3jsnaZfLyEaPwE2vHyfU7t1woc=; b=Y+8eynf9h1Y4hWELJDKr9+Fa9/O1NVy9n5iE/BHKQmLQSqOzS0U38g6i4F1JubYnKl 8JQez6eNgIoLyt8w18Ozg/wRPx6nkp0GLDrgQmeJezGBW3ibwEy1WRoT39c77tFY6SEu oXQMXC/piv+sN/wMbtX5ylHP3vDdz8P207TgmDtHBQzjKBnp8bzfh1psX5ZIsDfGXjVF EcckQs24pKsgw3zPKumvaP4zyNPzeXv3wt+aLVaXSfdWglLJlStuOttYfNkHkQ9oq5on W8BXew95xEZ4yUMngEpW4YZosEDTWkuryKVVqb/I9OpsO7kIn4CcXXk6Q4JayOPYov1C AXSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jfL0deDb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id c5-20020a170902c1c500b001b9c3498526si8754447plc.433.2023.10.24.12.18.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 12:18:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jfL0deDb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id D8D1A8051AB6; Tue, 24 Oct 2023 12:18:15 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344252AbjJXTSK (ORCPT + 99 others); Tue, 24 Oct 2023 15:18:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344021AbjJXTSI (ORCPT ); Tue, 24 Oct 2023 15:18:08 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60FD6109; Tue, 24 Oct 2023 12:18:07 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8486C433C7; Tue, 24 Oct 2023 19:18:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698175087; bh=02/KBKaqOhmo7sOtLmLAqh48v9xojz8EBNv27xQczDE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jfL0deDbHCTASTwvVJtZBMDhQANaLR5aZwQZSZoUEihfydVA5yplYU+Oo4mx9S994 zaLf8hToZCK4JEMlsOZlq23xcoGZqlzHv++c2jpO6KTUvROV9PxK5G9ElS2+wqirEZ i6Ln7xFeGyMgc9gpYAPfojvOaYHb7zdVH8+2j7+NEsjREre0k1nj8MWS5Na9Yk2Lj1 PKpiWr/CcqmFmSUaFmvOGwlhDNX+4Xxy/o111+daFm1MtEA9K/8atAEow8Vn8LqfXZ fdoBttptHYI5fBGpHYra/YrYK8hnfWmwP7cEpQpSkccLhdsNYyEWXmRLqdm5EIeyHz iqvQ60J86to5g== Date: Tue, 24 Oct 2023 21:18:01 +0200 From: Andi Shyti To: Chris Packham Cc: gregory.clement@bootlin.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] i2c: mv64xxx: add an optional reset-gpios property Message-ID: <20231024191801.kofb6cbczswp7xxn@zenone.zhora.eu> References: <20231018210805.1569987-1-chris.packham@alliedtelesis.co.nz> <20231018210805.1569987-3-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231018210805.1569987-3-chris.packham@alliedtelesis.co.nz> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 24 Oct 2023 12:18:16 -0700 (PDT) Hi Chris, as you are working on the v4... ... > + if (drv_data->reset_gpio) { > + usleep_range(reset_duration, reset_duration + 10); I'm not against this, but it's not optimal unless we know more or less what to expect from reset_duration. Do we have a rough idea of what reset_duration is? If we don't then you could consider using a generic "fsleep(reset_duration);" Would it work? Rest looks good. Andi