Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2118188rda; Tue, 24 Oct 2023 12:54:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9HV6SiOIRkEbma1quIAZ+r3257SyBysvHgv/bVwQAPleVAesbrzB/Xt+Kpfk8IEgc5edW X-Received: by 2002:a17:90b:4f8e:b0:25e:a8ab:9157 with SMTP id qe14-20020a17090b4f8e00b0025ea8ab9157mr11972491pjb.22.1698177290704; Tue, 24 Oct 2023 12:54:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698177290; cv=none; d=google.com; s=arc-20160816; b=MSll8CiQSt7dTn9/+PB7nCrF67ueb068oqpfm8z86Hc4yrUN6OSMSb+LpVnDfRZbhD 8k4wHUuPVctA5H/hJ1hHvOayz3/5bgJ9NaA0lBl6gnbzIQqWxUvYT9KQVZGbvjc+ItCu VrRIE5swJEnXJ5Y2z8KFkyYGmAg09meqjCPhnpAdlnQGUid025+GhzFEl3zQocP1CIH1 4KUUeq9c233HtEkZY8zkBEYT2TSDIN7AXGJuBnWKznBH7t2AfRjpYFtOoG3QwzA2D/GX 6FLY9EKN21fAycrsHe4hVKQWTUGyYz7675B53Zo/3kxQj0Of19uRzZhHHU+aUtTbrGBQ gOow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=VEV71pdNQSE5ZyW3Dwi8nSDGsP5MXw9kdoM65aHjPOI=; fh=5eXwgjgMNr67VuwvxnL6w6qwBU7d90ubCzIpTTDQO0o=; b=0c0IsCiw/h8131D62Q+pFMQsMkeVpVymswItoTbx1H+RO7/DeqbyzaV8g31oe3ci3y GaQCuPQFjcaxMo3moG8u4F0GBKQb8kyxFcY2ZAXggMeV+B9od4iw38jck4E/vQsd5FL7 Im+fORIM1bMu5ut9pxCL81Vy64rd82Z8F6zMzAjylCSlSrOJdsAxt+MuTWgWFTi1ayxx gaq8wzBSQAgh/kbpzfRVuOaAD6vxvrqpVPRZ8g22ns/IsH/3Mnz3QDVw0BljGVpQHjiH TjL5vPrWlW4vi/rdND7qnO8Q7hQUtQv2aZ9bJO1vrmWkwV9m45TyE7R84uIA7Nsrka8q feDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id 12-20020a17090a1a0c00b0027d1b1eb03esi8938807pjk.94.2023.10.24.12.54.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 12:54:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id C539C802120F; Tue, 24 Oct 2023 12:54:46 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344317AbjJXTyl convert rfc822-to-8bit (ORCPT + 99 others); Tue, 24 Oct 2023 15:54:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344218AbjJXTyk (ORCPT ); Tue, 24 Oct 2023 15:54:40 -0400 Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 152B79F; Tue, 24 Oct 2023 12:54:39 -0700 (PDT) Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-1e99a55a9c0so749663fac.1; Tue, 24 Oct 2023 12:54:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698177278; x=1698782078; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6P7wT8dPYf9bvLIbftJ6d8ATBxM0oX1gXkP2jSioPM4=; b=FZ9AXa0ikSTVZrd1vbh6BdeMFPTneSOX6f7AYnKtYtzA68bU7NoWmXyJWHPYHmq2b9 QPwwtGJjuU0TDo1/zfg3gZ0UTBDjJ+qcAJ76H3lshagZB2GezVoE6JZTudIO3AFeYX2E 6TsrfZRP2QuxqpNwOnF353KrBuyhiB5zVw757wN6BdpkPGpppXO1YMZ7zYlnggYKnsDD NTleHFlu/vROB6xcGPl0bJqIyqDkQDqCcXDMkHsBpvCjDFNjYRs3PXPyhx0Vil76Tm5E iwoHK7L0cU24myTV3XmcKllFb5Yt5XV7cSP38r/A8jaYsY833xCHTKSTXlkpgNczdAvj LcmQ== X-Gm-Message-State: AOJu0YygDCZG3yPXeJ5wwCv2OebSbzmRGGEH21th9FepZ8cSNideotmn JkqDf+SgmEjejWZZJ6ZhAwpO17vz+Glntjvpeog= X-Received: by 2002:a05:6870:fb86:b0:1e9:e605:27a1 with SMTP id kv6-20020a056870fb8600b001e9e60527a1mr14651916oab.2.1698177278384; Tue, 24 Oct 2023 12:54:38 -0700 (PDT) MIME-Version: 1.0 References: <20231024091336.1.Ie25ddf26b761bf185b7152c6a9884977f0ce73f9@changeid> In-Reply-To: <20231024091336.1.Ie25ddf26b761bf185b7152c6a9884977f0ce73f9@changeid> From: "Rafael J. Wysocki" Date: Tue, 24 Oct 2023 21:54:27 +0200 Message-ID: Subject: Re: [PATCH] ACPI: EC: Add quirk for HP 250 G7 Notebook PC To: Jonathan Denose Cc: LKML , linux-acpi@vger.kernel.org, Jonathan Denose , Len Brown , "Rafael J. Wysocki" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 24 Oct 2023 12:54:47 -0700 (PDT) On Tue, Oct 24, 2023 at 4:14 PM Jonathan Denose wrote: > > Added GPE quirk entry for HP 250 G7 Notebook PC. This change > allows the lid switch to be identified as the lid switch and not > a keyboard button. With the lid switch properly identified, the > device triggers suspend correctly on lid close. > > Signed-off-by: Jonathan Denose > --- > > drivers/acpi/ec.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c > index c95d0edb0be9e..a59c11df73754 100644 > --- a/drivers/acpi/ec.c > +++ b/drivers/acpi/ec.c > @@ -1924,6 +1924,16 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = { > DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion Gaming Laptop 15-dk1xxx"), > }, > }, > + { > + /* > + * HP 250 G7 Notebook PC > + */ > + .callback = ec_honor_dsdt_gpe, > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "HP"), > + DMI_MATCH(DMI_PRODUCT_NAME, "HP 250 G7 Notebook PC"), > + }, > + }, > { > /* > * Samsung hardware > -- Applied as 6.7 material, thanks!