Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2156765rda; Tue, 24 Oct 2023 14:19:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFPWerX5dAe+5wm+5SKZ9e1UdGerApIII/rs3qh6QYu7g6SYDRlMBlCbkhBi21HvDdgap3y X-Received: by 2002:a05:6a20:938e:b0:17a:eddb:ac6a with SMTP id x14-20020a056a20938e00b0017aeddbac6amr4260365pzh.6.1698182357630; Tue, 24 Oct 2023 14:19:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698182357; cv=none; d=google.com; s=arc-20160816; b=TKL2JlmeMQAJ9wzodQm491nvJoHlFe6TD5m5y+0z/WgPzUfThhG1htKXMKsp5W2tCj wY9QkTwJDQf5BAat3qVS2/plz7cEKI+J8eCNGybt+rpuwZjSEZ27AD4CxI51FAYySt70 ppc8WGb/irz1yQfScAO7B0sC9Edhv9NxQlXYfHKgqyMihyf+0KUyZmzwF+RP1VlD6nrM TPt751tVgwfOcajZREgSbGQCZfkBLDR7avsuoyOr1vAbWDKSWhEMUI2ECXjDL7HuY7Ri WkjDY6ki2eQz5H3W/pcVxj6S54efJKPS86xWqvQ7Q7s7c4imwwh6x6tzaTPyRAkBbGgT 67VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nN6qLLiV1hMbAd2ABROBC8TqYl495gWbFutxERKWZ5Q=; fh=ECm0sWxuqPMPJrOvbl8BCdoHgHcK7uYeFF2VkdZd0Co=; b=u1pjVVQkfRGcVl7gwBWVHE+ZDCV6Xu92B0DyxkdZoQTyC88njpqxXdT7sJmj1m45A+ jGIODBCPz1eZdlpXKE/0urZutkAgOZLisWsvEDAJZxGbkf8ujt9p+fkE7N1OENzbUUHf 6K9yIGHbwPc6Ju1St+QIhPZilamOpMA18ZjJWzSejhDRInu2YuPoha3Qcv+9lAEnVVRO aywTIZ50CmVeqm0gO0s6MK9QVTNR7/XBzdSWblxQ9CT1E+qaPU/k2267QzfXk0vgJB6b FMm2MlTj7l64WKDSSIUEPLFBPXzs+Gwx3S1qLrZ3WFwOvDxLD869e/jO+k5++uXNs9dm DI2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mT4s4Uka; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id ca37-20020a056a0206a500b0057771e49c25si9653260pgb.693.2023.10.24.14.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 14:19:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mT4s4Uka; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 2CE7C8028A71; Tue, 24 Oct 2023 14:19:16 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344357AbjJXVTM (ORCPT + 99 others); Tue, 24 Oct 2023 17:19:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234946AbjJXVTJ (ORCPT ); Tue, 24 Oct 2023 17:19:09 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB27310D4 for ; Tue, 24 Oct 2023 14:19:07 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-6934202b8bdso4795354b3a.1 for ; Tue, 24 Oct 2023 14:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1698182347; x=1698787147; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nN6qLLiV1hMbAd2ABROBC8TqYl495gWbFutxERKWZ5Q=; b=mT4s4Ukao4U0XP3DnWwD9hL0lnywK/bw3sgWt6Obl8bftn20XFbV51NPQ+SRr1/l04 jSRw0NG8tauKCbkmDjytC0I/+WH8qg+78JLFCuvgMOCa06cvD3AYP2dJTvj0wBrbiJyz uOuayNPuk3DEGn2h5EBgIlKxpoG3I6F+3NZi4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698182347; x=1698787147; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nN6qLLiV1hMbAd2ABROBC8TqYl495gWbFutxERKWZ5Q=; b=N4WlU/4DC7yms3EzKgdswFarXm0L0lL+Gc4IW06rsI5F9/invjOqdvho/xZOJmpg6r qtRv4oHp6w9uijTItT9n0KYo8gI4RtwnOjqkC8cY5lwTluaCh+/2bZXZSTAhjVdC/EGP QOFtPxSVdw5rSDa2yI9WVIL1UoBkT9+Z0XiZUDUb2He3LADIYFMzL2uA0BZ2yhb7yezo 1vwqg6IyBg0hWoMlNaXEI+Kn4Rys1TpIED+R0TRMRd5NHkx02ozJeRuJK/vOr5TprXxo Jt10ec72gkNPEf602QMUpt57hJyurTkISgHAcpnWT+4CHOmE50uywe/JBgVzmrvq4tfk Azmw== X-Gm-Message-State: AOJu0YyOOT/wby6zAbqVeHgR9WLTI2q7Wn2GvQdx/XUFBQVWeWtNclxh /o04Q/H7I9TxhHK/FEdkl/+e/w== X-Received: by 2002:a05:6a21:7983:b0:170:3e5b:bccd with SMTP id bh3-20020a056a21798300b001703e5bbccdmr3039533pzc.30.1698182347115; Tue, 24 Oct 2023 14:19:07 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id h29-20020a056a00001d00b0068fbaea118esm6013685pfk.45.2023.10.24.14.19.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 14:19:04 -0700 (PDT) From: Kees Cook To: Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Justin Stitt Cc: Kees Cook , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] dm crypt: replace open-coded kmemdup_nul Date: Tue, 24 Oct 2023 14:18:50 -0700 Message-Id: <169818232968.2100071.5806064081646325604.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230925-strncpy-drivers-md-dm-crypt-c-v1-1-eef875e4f9b2@google.com> References: <20230925-strncpy-drivers-md-dm-crypt-c-v1-1-eef875e4f9b2@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 24 Oct 2023 14:19:16 -0700 (PDT) On Mon, 25 Sep 2023 06:35:54 +0000, Justin Stitt wrote: > kzalloc() followed by strncpy() on an expected NUL-terminated string is > just kmemdup_nul(). Let's simplify this code (while also dropping a > deprecated strncpy() call [1]). > > Applied to for-next/hardening, thanks! [1/1] dm crypt: replace open-coded kmemdup_nul https://git.kernel.org/kees/c/17348b0a6a6d Take care, -- Kees Cook