Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2163223rda; Tue, 24 Oct 2023 14:34:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhPfQHPTulFdJ5Dh9srgpj/sOrUzhFfJPkUC3Cove8Da07AEWQYmRqmWTDJGW9AOTeMwZW X-Received: by 2002:a17:902:eecc:b0:1c5:ba50:2b28 with SMTP id h12-20020a170902eecc00b001c5ba502b28mr12349461plb.25.1698183265965; Tue, 24 Oct 2023 14:34:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698183265; cv=none; d=google.com; s=arc-20160816; b=fvnYQdggU9X1RjWA4MDkx+hPWtHg+YuuuAOBuWETOGO3fvxGD5s64c54DYedJiE+fO MUe41CRP7URG1wLN34ybUnn1Vo4OXkvSHK+Vb1+Rj/Axbve6oiumE4L66fKC33NA3UA8 rb3Mrinn+gbc0qjb13LVe3IL+R/5BwlcFe5JbF1tSN4XoCnprq+EBQlXRxJ+fNxkQqL2 dar3oJQqrr7/wgsKYGXwne2Rf4+1yqSsz3b7xvy9TOYEUPA+Sd8cANNtY7mwFG4lqnSM oa5auHc06J54rWsif1SFD65h1do+2dSwDn+SUmFOQjuKbBBaoG++QWxN+fIMQ2mjXaxk HKdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ydoeA8bMPTFfL7KIyd2iImmXpydvV8NCmR/UYsYbpxw=; fh=rQTv48+EhBSHy8SjsLxZyJg9LV2ugBHlmCvD6eXlRlc=; b=v+f7rlLjfnU76fVoTGkTXeZnNBQwZv2Gde4z63WwHCI8sDdPA2RNbvzHhxYXiM9zaw Fl88/ZtWyfxC3gedvfIgFyHncfKQlmHHxX67rMSl2fMPFNa2+JGF9FuFASfI0q6ZkB5J rtrQj1Tamv+G6d6FEYIpk5pZQDJFAAY1yYDBPDiStZwszkGKt7QUapObP7nmm8LnykAM ciHNs0ylJYDkQ6nLjXFJeiFDabStPO3uGVl5jcZPpatBKJ4PVcrNap77YEpaW2qNh6Ut JDPXNCi0BrivuwtHoy9UZBQd8J64yVhWkXQEiClVmWn6AKdYI3TfvtXODiut577v9pgA RxZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id l6-20020a170902eb0600b001bbd70bdffbsi8389851plb.440.2023.10.24.14.34.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 14:34:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id A646080BD3B4; Tue, 24 Oct 2023 14:34:23 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344155AbjJXVeI (ORCPT + 99 others); Tue, 24 Oct 2023 17:34:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344360AbjJXVeD (ORCPT ); Tue, 24 Oct 2023 17:34:03 -0400 Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C84D9D for ; Tue, 24 Oct 2023 14:33:15 -0700 (PDT) Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-5822a990ea6so1986986eaf.1 for ; Tue, 24 Oct 2023 14:33:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698183194; x=1698787994; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ydoeA8bMPTFfL7KIyd2iImmXpydvV8NCmR/UYsYbpxw=; b=j/vQ1TRlyyAN3ie6yDV2ON86JkY3J4V/omrKYHJDvlMSmkkQYxK/dOcztYBugGEQbI jg0B21YFSFjJKJ1dW7g16CzC6LtTETAiKkcmQwwUvLnlVqdpgOx7PjFrh7mqWUmCBWse qi7poXyzmRgu1/+OqYuMuEkolNzljg3ttsjEa6qpCLrFUZqrHNs+g+bz83vfFTGgd6xs tcJPl1DmKDahVFD212Y6XGLeg39W7cy0QGUz2D16YzOICkY6ON+O9OscsztUWOpg9N+O dpH47GEnCbhhgwX4+vx0m+54+cFmNspI0jo8FMpWcwnwX6zU+95hZ8G7CFdHdRIV3Tb/ QQZw== X-Gm-Message-State: AOJu0YwRrnMVW6ZgQvPewqBSF24gpRwacfsc/MaGnpVxeLt+iAf6Cpol f0eV/guyI2uh+/tgbxsyG3PB X-Received: by 2002:a05:6358:72a3:b0:168:e707:2e56 with SMTP id w35-20020a05635872a300b00168e7072e56mr4769109rwf.16.1698183194698; Tue, 24 Oct 2023 14:33:14 -0700 (PDT) Received: from localhost (pool-68-160-141-91.bstnma.fios.verizon.net. [68.160.141.91]) by smtp.gmail.com with ESMTPSA id e20-20020ad442b4000000b0065d1380dd17sm3840065qvr.61.2023.10.24.14.33.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 14:33:14 -0700 (PDT) Date: Tue, 24 Oct 2023 17:33:12 -0400 From: Mike Snitzer To: Kees Cook Cc: Alasdair Kergon , dm-devel@lists.linux.dev, Justin Stitt , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: dm crypt: replace open-coded kmemdup_nul Message-ID: References: <20230925-strncpy-drivers-md-dm-crypt-c-v1-1-eef875e4f9b2@google.com> <169818232968.2100071.5806064081646325604.b4-ty@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <169818232968.2100071.5806064081646325604.b4-ty@chromium.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 24 Oct 2023 14:34:23 -0700 (PDT) On Tue, Oct 24 2023 at 5:18P -0400, Kees Cook wrote: > On Mon, 25 Sep 2023 06:35:54 +0000, Justin Stitt wrote: > > kzalloc() followed by strncpy() on an expected NUL-terminated string is > > just kmemdup_nul(). Let's simplify this code (while also dropping a > > deprecated strncpy() call [1]). > > > > > > Applied to for-next/hardening, thanks! > > [1/1] dm crypt: replace open-coded kmemdup_nul > https://git.kernel.org/kees/c/17348b0a6a6d > > Take care, > > -- > Kees Cook > Hey, I had picked up this patch and the 3 others in my local tree yesterday, was going to push shortly... do you still want them to go through your hardening tree? Mike