Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Wed, 25 Oct 2023 08:23:45 +0800
From:   Tzung-Bi Shih <tzungbi@kernel.org>
To:     Lalith Rajendran <lalithkraj@chromium.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Benson Leung <bleung@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        Raul E Rangel <rrangel@chromium.org>,
        Tim Van Patten <timvp@chromium.org>,
        chrome-platform@lists.linux.dev
Subject: Re: [PATCH v3] platform/chrome: cros_ec_lpc: Separate host command
 and irq disable
Message-ID: <ZThgEdJuxTmucKIe@google.com>
References: <20231024105820.v3.1.Icccaed152371dbab868295a6c83d257e8409cf2d@changeid>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231024105820.v3.1.Icccaed152371dbab868295a6c83d257e8409cf2d@changeid>
Precedence: bulk

On Tue, Oct 24, 2023 at 10:58:21AM -0500, Lalith Rajendran wrote:
> +/**
> + * cros_ec_suspend_prepare() - Handle a suspend prepare operation for the ChromeOS EC device.
> + * @ec_dev: Device to suspend.
> + *
> + * This can be called by drivers to handle a suspend prepare stage of suspend.
> + *
> + * Return: 0 on success or negative error code.

Please update accordingly to reflect the fact.

> +/**
> + * cros_ec_suspend_late() - Handle a suspend late operation for the ChromeOS EC device.
> + * @ec_dev: Device to suspend.
> + *
> + * This can be called by drivers to handle a suspend late stage of suspend.
> + *
> + * Return: 0 on success or negative error code.

Ditto.

> + */
> +int cros_ec_suspend_late(struct cros_ec_device *ec_dev)
> +{
> +	cros_ec_disable_irq(ec_dev);
> +	return 0;
> +}
> +EXPORT_SYMBOL(cros_ec_suspend_late);
>  
> +/**
> + * cros_ec_suspend() - Handle a suspend operation for the ChromeOS EC device.
> + * @ec_dev: Device to suspend.
> + *
> + * This can be called by drivers to handle a suspend event.
> + *
> + * Return: 0 on success or negative error code.

Ditto.

> +/**
> + * cros_ec_resume_early() - Handle a resume early operation for the ChromeOS EC device.
> + * @ec_dev: Device to resume.
> + *
> + * This can be called by drivers to handle a resume early stage of resume.
> + *
> + * Return: 0 on success or negative error code.

Ditto.

> + */
> +int cros_ec_resume_early(struct cros_ec_device *ec_dev)
> +{
> +	cros_ec_enable_irq(ec_dev);
> +	return 0;
> +}
> +EXPORT_SYMBOL(cros_ec_resume_early);
>  
> +/**
> + * cros_ec_resume() - Handle a resume operation for the ChromeOS EC device.
> + * @ec_dev: Device to resume.
> + *
> + * This can be called by drivers to handle a resume event.
> + *
> + * Return: 0 on success or negative error code.

Ditto.