Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2242745rda; Tue, 24 Oct 2023 17:51:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF3bPADJfAW9cRLY/gldSZ3aorPbz/ERRl+NKWryv7SLeN/Vg2faDpEcE+rK/50RB8AMV9k X-Received: by 2002:a25:23cc:0:b0:d9d:1b00:252a with SMTP id j195-20020a2523cc000000b00d9d1b00252amr10358172ybj.2.1698195082436; Tue, 24 Oct 2023 17:51:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698195082; cv=none; d=google.com; s=arc-20160816; b=YKf/rZS+iN6njBnuMVXAXUihhvPbsVaj9AOHdPl22X90St4S3tGm8A+KK9EaZjD6bV 8bRHK+Xf4NKxFbmMPBgaEiGQrp1v2+FdE6mJFumEOGTlLHiL/i0qVJJFUu9HuqfIYkZy GJ9ClmhJ57USgtb+C64U2Fzpy3n9K/a0V3BFtPjmcAIGJjdCt6e7VqGDOJRmV7iv2V8+ GwUd1OPJM3tVku701bM9689+ZoCo+xf2z8dGHsuCuKYzu15lgpyOhpbWtIGM7NhKXtWH W5/y6kkYo3HP4xFfqIhNUX9FkJzCJPOOQq4wzggIQ3x66sXjx0AO0xrLQ+Zle5iXMuIg Xr4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=45eCgoBDJWM1cLlzIrUFrDR5YahR8JmJM/HT9lRcsUI=; fh=iF01Hw7P+q1evSmjKqRuMn0LjJD9G8/tB43u7SGIzFA=; b=bmX9zQCTnGFsIJGUevRY0s5G6jUsk2Wnu0cJ8nNv1uWpLUtnsTaYkQuqb+pB1ES5hg 4E8e9bzdE2jEBGchRSf3fNdZQyMZwjlR2LCdxVuZhDb7VyeuvfnPGhQg7Hl0SwqpBod4 mQp3RL8PRIc5obh1mIyiReluTtuKjuGnZZZBVuqm59iTgUgPXUhkv8E7lkEecqJ9/uLK 8PyT/TxWhkLesqohjbQLdKTj8GQ+Uvd8SiDRJw437Xil40CKyx5NwKdEbqxtnLcT4Dlt fvklVcwADLsR7S+LTtby3iV3YT74k4iS2lsNmvvFuoMglyt6YiNghk1aYogixKdDMdUS Itow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@foxmail.com header.s=s201512 header.b=n4mqCO0z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id 22-20020a250216000000b00d86688bbb7csi9753177ybc.14.2023.10.24.17.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 17:51:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@foxmail.com header.s=s201512 header.b=n4mqCO0z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id D247B8077A60; Tue, 24 Oct 2023 17:50:29 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229798AbjJYAuY (ORCPT + 99 others); Tue, 24 Oct 2023 20:50:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjJYAuX (ORCPT ); Tue, 24 Oct 2023 20:50:23 -0400 Received: from out203-205-221-233.mail.qq.com (out203-205-221-233.mail.qq.com [203.205.221.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F7E4E5 for ; Tue, 24 Oct 2023 17:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1698195018; bh=45eCgoBDJWM1cLlzIrUFrDR5YahR8JmJM/HT9lRcsUI=; h=Date:Subject:To:References:From:In-Reply-To; b=n4mqCO0zvtrdC/Y95bAB/w3+Q6wRLkWD0AUslFreFg0XIriLX9Iktj+BPWWXHK6uj ie367ZTU0jyU263L7znY0Wwy+wHGkTcQWXX2Acfbs6ECjNCVPyamIl3OWo0fW6rWZp 1zOCbUksU7Eo3+nmBrfunXqOEc59eKiE9eJW23Z8= Received: from [10.56.52.5] ([39.156.73.12]) by newxmesmtplogicsvrsza12-0.qq.com (NewEsmtp) with SMTP id C90A145C; Wed, 25 Oct 2023 08:50:16 +0800 X-QQ-mid: xmsmtpt1698195016tczu6fp14 Message-ID: X-QQ-XMAILINFO: MmCmH9jyqHC2rX88bCSOHJrV8cQgBr8qe3/ubY+JnhXD9J1IZH7glBrlM5cK7r SPdU5Ey3lx8a5AXXFrJ4Y78SGqvxm3PRliWLCn+V/tx5RC+aqqcBr45KdLiwtkimZ1LvPnOqYc3c xgNkrUP9486LsqsRV6sy2wV6+NgYxxq34M/kwvhkzPWw4wMGJLXahB0/bcQHBwVj/pQaik2d0qnW tQIml7/Z+MGYzoFYtH9yC26tsJdZR99OwNthITXY9IApnfCsB7h0zVhHp2TbtX+e8u9ndjbms4Pn VgbY1ESJlx5P2c/p/iBsFEyiGDlVqxB4uRFjCxwOPIZGpy5pMsukZs/YAHSw49YT6mNJXFIMbyl+ Aa5ytd5btJoQE7QJAN+G2fIRpBt//GlnekpVNs88OP370AZ9Z5iDzAnkGRgEaubIUCnM2iwYU1JH eedw4akOOvlIxL2KDqeaiXEE7+HcSne+7Etd0f/gM/fxqVRu7auwfTTlzjX/1KuyjMZw4qKh2UP2 ExSyhXQ26tyZHulgEY7xPB3TH/KBlDBF52bRs+jOyeH0wLUzOpMpMitCiFZ4GHiTI+bAVOUWfw2/ emS60F3w1DEW7DPRnS/srRApww+Uyr5tn1GK5QNHuoCNCOFP4Xj942Z+02V56NEeYOGlqDOZcM4k /HwSh0ueR1x2DyfRdHoz2vMGTDmzVqs5is4H9TkQBadLRc0h2+f6MjOrnfMqmq+36tLGiSyQI25Y svTSj0CIjAn76zezViXlbU/lU6g8Tfg9RJKddKH0C7z65UJDKOHz+Mwe9pzAVes9TOyPcze/MmLt junLsg5cb7sLxn1RFH4H1OePOlICrgf6t9KBst5JRhFMn0oMyvhphftHxeIOB3EesxKCYu8+JAd2 F67Rij7XwX/QoaI2II/MhJXzO7nk/bXY9zuhZN8CqSMSB2m9FGDYKMCj47oKaOJY5Xqcz0J7/F80 gWUfH+SQQ5aLxAQDYndCGORjcfWNKvhSeaPeIs3gynMs7OtzDq7ft2Xe7C/G+N X-QQ-XMRINFO: NI4Ajvh11aEj8Xl/2s1/T8w= X-OQ-MSGID: Date: Wed, 25 Oct 2023 08:50:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] stop_machine: pass curstate to ack_state() Content-Language: en-US To: open list , Rong Tao References: From: Rong Tao In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FORGED_MUA_MOZILLA,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 24 Oct 2023 17:50:30 -0700 (PDT) On 10/25/23 8:43 AM, Rong Tao wrote: > The multi_cpu_stop() state machine uses multi_stop_data::state to hold > the current state, and this is read and written atomically except in > ack_state(), which performs a non-atomic read. > > As ack_state() only performs this non-atomic read when there is a single > writer, this is benign, but it makes reasoning about the state machine a > little harder. > > Remove the non-atomic read and pass the (atomically read) curstate in > instead. This makes it clear that we do not expect any racy writes, and > avoids a redundant load. I'd prefer if we make this comment: stop_machine: pass curstate to ack_state() > > Acked-by: Mark Rutland > Signed-off-by: Rong Tao > --- >  kernel/stop_machine.c | 7 ++++--- >  1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/kernel/stop_machine.c b/kernel/stop_machine.c > index cedb17ba158a..268c2e581698 100644 > --- a/kernel/stop_machine.c > +++ b/kernel/stop_machine.c > @@ -188,10 +188,11 @@ static void set_state(struct multi_stop_data > *msdata, >  } > >  /* Last one to ack a state moves to the next state. */ > -static void ack_state(struct multi_stop_data *msdata) > +static void ack_state(struct multi_stop_data *msdata, > +              enum multi_stop_state curstate) >  { >      if (atomic_dec_and_test(&msdata->thread_ack)) > -        set_state(msdata, msdata->state + 1); > +        set_state(msdata, curstate + 1); >  } > >  notrace void __weak stop_machine_yield(const struct cpumask *cpumask) > @@ -242,7 +243,7 @@ static int multi_cpu_stop(void *data) >              default: >                  break; >              } > -            ack_state(msdata); > +            ack_state(msdata, curstate); >          } else if (curstate > MULTI_STOP_PREPARE) { >              /* >               * At this stage all other CPUs we depend on must spin