Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
To:     Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
Cc:     alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org,
        jejb@linux.ibm.com, martin.petersen@oracle.com,
        stanley.chu@mediatek.com, mani@kernel.org, quic_cang@quicinc.com,
        quic_asutoshd@quicinc.com, peter.wang@mediatek.com,
        beanhuo@micron.com, quic_nguyenb@quicinc.com,
        Arthur.Simchaev@wdc.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ufs/core: ufshcd: Conversion to bool not necessary
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1sf5zctew.fsf@ca-mkp.ca.oracle.com>
References: <20231024183401.48888-1-bragathemanick0908@gmail.com>
Date:   Tue, 24 Oct 2023 22:44:47 -0400
In-Reply-To: <20231024183401.48888-1-bragathemanick0908@gmail.com>
        (Bragatheswaran Manickavel's message of "Wed, 25 Oct 2023 00:04:01
        +0530")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bQH7styru118wkOT4FScgFt65cRU2Fkt/anyJZ3NCnXOWHGsIvpUySfh8VX9?=
 =?us-ascii?Q?5XwvwJChC0Snwrcgaipq089gH9jxzVn4tDVOxI2ShlLFSvPyjAGsj+SQNJsG?=
 =?us-ascii?Q?4cvn09PXyjZ4ouzRg6xuPSpyTj0rZsgQBBXb6UcBkw4bbyoR5TsTJz1kJNWE?=
 =?us-ascii?Q?lF0fHx9Ce0GNwLTx22+kfj3IYcGmt7iR8n71r99zzikBweTYfrJq9FT2wvc4?=
 =?us-ascii?Q?ZEhPUEAmaIKMNsRB1t0NYiIeXkRY8mlxOVg925tZobPqOQcM5RaulqYWYv8s?=
 =?us-ascii?Q?bBoFSRCpdNggYqtbYc32pj5qnIaTDdw/aIwlC4PDk66atD+9KxB+npd/juWS?=
 =?us-ascii?Q?9LAPFHZzUu80bVjPc6lrTjoZ4p7n2sHlXdStCKkxH9/W2QwNed6WZf0Af1iG?=
 =?us-ascii?Q?h2bVA7ndX8QRLO+ji02eUC0Hi5aiFLgqi0wuYIIDMYcdTg5Bn1OBwzRPelxY?=
 =?us-ascii?Q?H02TlCmE0cwSmsG5cRIYwx08BUucEmAeMpo9f7ulUKglhzqSQ0EZflov+09Y?=
 =?us-ascii?Q?XRKlzFgS/y+wMDLRV5oNHtqpMLALaTQO3DQa1/xgVC59fFshRkZd+uZSDP4V?=
 =?us-ascii?Q?/evIDa2nR68Ix93j400eJeTAUxZTKEQ2MFTURH7SNraGYqERVik25ka/+gFd?=
 =?us-ascii?Q?yAnn8iZkvuFI2jc5ssfZEsWX8tjjhaGxPSwPshXWKuDDu5rBaTm4Q7yyBM+3?=
 =?us-ascii?Q?NnbhaKOfrWkKLBhLxoIdomwzAKD7sqXi6RTN6wzZxLqx4veqsfnUWbVGbiDO?=
 =?us-ascii?Q?WJnoYjd2kpwrO7Wp50/hZIb75LEPYi224EG9uhTu+9IkH/x3JNtWaN9TWP5c?=
 =?us-ascii?Q?oNh8SQ3Rn8pH4PPMgrDTFTiNl/K+VWV6r66xqz2BaGdXvdwKn2LNQrf9LUz+?=
 =?us-ascii?Q?6BRRSQrQkKpfxz361j30STMlH4lOkeVkkZIUHnse7JCyVOTW+OhSYgvpszeA?=
 =?us-ascii?Q?S7T/c3TTGgkWUtPgDF/L+wIhnzef1pEmo7uKXj3q+VeMKi/g6fTekx6QsfoL?=
 =?us-ascii?Q?dTQIpXrmcsuRZY5mmOVZeHA1cgs5Khs+ED4Alv5iFD0JZq9E3ft3yUtmsS1s?=
 =?us-ascii?Q?a2X0UdLM8+D9Ir8RM986j6GuKMaHAK2+1MarUlQW/QuxDRpOivuJO8vnWTAc?=
 =?us-ascii?Q?wOoeI28CEi6M6/9ppbgN1WsCKbi8yVJMOesCBZkBDdkp8dDaHNyGtrWnCH4M?=
 =?us-ascii?Q?lgjsCsy6zot73XkUfhiKFJHfa/+2ee1LhmQqpsI/eym4A4j9dTd2R+OKWVwb?=
 =?us-ascii?Q?rV90WRmh8x3WgrCdcV/u4A9dhYpDfy8PY3b5nokXfBwnO9b1sAo0DYnljs2o?=
 =?us-ascii?Q?3YsCglLmLIVINCEpva0tO4MXNL5uAwgm4wB69s1awYsLX0VHlLXQiiqXMOL7?=
 =?us-ascii?Q?7QpffOD56cT8mTY1ih/e6zCPQVgcv9c65Ik46bM19NRlNsyLzI5jsIMXqzZa?=
 =?us-ascii?Q?udLrj9z+TlW5Y/j8+WGmMO0Zds7HARaYbSO42g+mC8U5X4Eq56arV4dG+T8b?=
 =?us-ascii?Q?+gK8EaUbgKnF3je/2kSgDExr3OATY6uGVqyXy9R5sHO5M/TyOIU9OB/eAl7T?=
 =?us-ascii?Q?h6dHLUnK3WX09kj+6qfqhIgO6Yj6sQ69arws9+nLFXhqQgya5cqLRyvoxMTt?=
 =?us-ascii?Q?LQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?Inb6Z5ND1ByaVG2lEhxPu4cHV5wjJXhrYG4gvlWXFVk1y7K7XWkKsKsappNS?=
 =?us-ascii?Q?x8yQoLN+EPI8fruBKMw/HCdCLZ8LXqCBNDBaDfcNzmX1KTkQVvD/PGK1kOBk?=
 =?us-ascii?Q?g5grD6racNQc7urVdS3or4hp4Z1Y/BQ1A4Sc9KeYkKpw8HQR7YSsLij5NJ33?=
 =?us-ascii?Q?9+IyN/kqivQydZqkyG2WOMLMm+kkqZClV701Z9RZVV/LjUWu9kN2y6dIfvaT?=
 =?us-ascii?Q?W/Mxvt55aA+ej9AnIfsuF5Vp4iK60bhT7snTRVqyrZrEg09QNfY0ewtn788w?=
 =?us-ascii?Q?LZuiinEFUgNdNBlz16jtvghsqpeRNtpqNI/uOOjel3RyT+SIb8hhq3PFlYx6?=
 =?us-ascii?Q?pFGT64AsOsiuZyFhLMi7qAZxIpG5iw2aFBkZQRkHEw/o8Cl7Cqt0jpVFMKqR?=
 =?us-ascii?Q?D+em803vkNqRlZKscS7Igd/GuRI/Tw4ePhn/yfqtQJtMN9SRGX6ea9pbJs6N?=
 =?us-ascii?Q?8kn8hDRG6OdTfqg1QKXhbchrbRbmhMgP2N/k4KM1+bqKcR7rWxGNNR9vnWB1?=
 =?us-ascii?Q?/rZme1DifHXehEwNvjkAiu805+iFwuUFXbAVo6NIGS7vavkfW1jzH0SqwwX2?=
 =?us-ascii?Q?TeWCT2N7NfYnzuFYURCm35R+m/scH+p7HN1BsbAApNeV9RIGRzLtlkGsVNbE?=
 =?us-ascii?Q?oPH77FyrXc4kYH2zvi57aWySaTAxXR6YcWq2CduN6lox8ycBey39FkjhT8K0?=
 =?us-ascii?Q?ophW/XM/YYm+MQ6qr+09uh4VWBuTmsFkMWeVG31fuZC+uqx9SNmHYZLSQwUJ?=
 =?us-ascii?Q?ZqiqXqLYr6FzIeGeh6KG6sp4Tyvu7V/7OrTPxNUUJyqT0yhgq//wtNuJqowV?=
 =?us-ascii?Q?1+nMIdj+NRHPadk2HYtavokhaYukO+lRHozcrkiC6VhGXNS7u1Xm1CYmgE4e?=
 =?us-ascii?Q?lcv/JHwwbF1vz60NiOncjy4C8TEMwkmM5sX9gTY06th5ZJF7SejZwB/fs6+h?=
 =?us-ascii?Q?tNQRH2hlUhYz9UnqQD5PdxxPx7lkYSsRMLNi5C8zjJ72iEAiheefRgPznlag?=
 =?us-ascii?Q?E0DxxgslvwN5qPbamgzim7yvaw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73e508c3-e6cd-4612-75eb-08dbd5045c6f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 02:44:51.2051
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IDIw4LCyweji0xB44Dn3quVIEIY1jjOQyzswyknJXMoqgTD7gAOCVYJq3xAUHm/6zvV7iH1u2vIntU6BPeowdfrQ7/sIrqq5iWVv4shnCHQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR10MB7924
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-25_01,2023-10-24_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=466
 bulkscore=0 mlxscore=0 spamscore=0 malwarescore=0 suspectscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2310170001 definitions=main-2310250022
X-Proofpoint-GUID: ag3W-moFXPzztfux5J8FlT0CC2orFeh6
X-Proofpoint-ORIG-GUID: ag3W-moFXPzztfux5J8FlT0CC2orFeh6
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 24 Oct 2023 19:45:23 -0700 (PDT)


Bragatheswaran,

> A logical evaluation already results in bool. There is no need for
> using a ternary operator based evaluation and bool conversion of the
> outcome.

Applied to 6.7/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering