Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
To:     Daniel Mentz <danielmentz@google.com>
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Tomas Winkler <tomas.winkler@intel.com>,
        Avri Altman <avri.altman@wdc.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        Mars Cheng <marscheng@google.com>,
        Bart Van Assche <bvanassche@acm.org>,
        Yen-lin Lai <yenlinlai@google.com>
Subject: Re: [PATCH] scsi: ufs: Leave space for '\0' in utf8 desc string
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1msw7ctbi.fsf@ca-mkp.ca.oracle.com>
References: <20231017182026.2141163-1-danielmentz@google.com>
Date:   Tue, 24 Oct 2023 22:46:47 -0400
In-Reply-To: <20231017182026.2141163-1-danielmentz@google.com> (Daniel Mentz's
        message of "Tue, 17 Oct 2023 11:20:26 -0700")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KUHimVItSbQQZLGs3J8MqCqMMcgOevWEiNRIVJLEXdTuEJ9HVEHNWvXos+3N?=
 =?us-ascii?Q?451sYv4jndqUkReRKSi2D805kzxEUwmRjnwaE4Dy/wKwaDGXAhVhq24vM8EG?=
 =?us-ascii?Q?3iQauoxWyPg8zvxaWwmdXfY+22tYdwO0E/vPIKVsbZR932DrvGFHthmlXMXs?=
 =?us-ascii?Q?AtVuUQoeZ8mN9ZUQSTcJc5U+Wo/XL7p3bF5H54TmidNFiwJZDZZgzYoIZ1xE?=
 =?us-ascii?Q?lhU8l+9LKG/i1SUAbbuwRgVXw8fHdzbKv1M26d4UtsA0i//4+m0MQi+GE0Jv?=
 =?us-ascii?Q?vVQux4ImLRvGQ4FoTB/1/Nv+nogZ6pN9oZHzpPdFm5G4kcf9obzmV/+U5Jwf?=
 =?us-ascii?Q?vQnEh3zCmjgNB0QTCgqPTFZmIDn3u5YkGKoewCE6pbGpjOCPAKnb/DaMigJx?=
 =?us-ascii?Q?r5UM8MIKOerEaxyD7RX+ftTeMHoChnRKUbQhrYkCIei5UKWkF8upU150Cbn2?=
 =?us-ascii?Q?44m3EwJ52GKzfl7HPT2xVZ6+kfuAPhkmkF3u+DFplorcv5oZwnUNLyHsEWDL?=
 =?us-ascii?Q?gWe7WZ5RWxl1IkaEyrJARm9dTuq/vAkvZ76LTUmx0WRUGYSrgcAvkFRyDas0?=
 =?us-ascii?Q?GMGgd57VhE49osPxAAI/rDe8+vo9uYmfJVJMya19MHbbAuLRmTQfka62/BXQ?=
 =?us-ascii?Q?zYUAG4MRl69qh5azIfdtNKxdvjbbknKmVUlupSSX/PYxZw2AG00rUAoKLbk2?=
 =?us-ascii?Q?hzH3tbmxiySMEx+q4fkSwOIW2EdMr9yFZGK+Rg+3lXIN0hZqcKY7R3AmPyLz?=
 =?us-ascii?Q?MLAp/U7/H2fMLdsgWkYGz/pft3UTCPAnO+M2tS4w2+ADv7s7ixHhHbuEKa1l?=
 =?us-ascii?Q?O2QMLS/vVsmrZ+KOP9uJvoQC1iKFiGFHzq93GYHCmZrWhsf5v9Av6LirLJFh?=
 =?us-ascii?Q?MCxWzDW5yUIJ0WjpOnif4EJc544DPG5waAGq8TwLfyLKiL42qgIEgCMHXZJC?=
 =?us-ascii?Q?IGujpN1PqHvqSentKXhIBhpYZ+H/MdfPfznU28rJ0ooaudzu3GvDfrA286rK?=
 =?us-ascii?Q?ML+MBbumuhKv5+/do4gsSqI/RZL7DWKWJ7bhFOqVLxdmtY099Epy5/mp9T+f?=
 =?us-ascii?Q?OgL+tjuzzEwG2hNd7HdfEHk2L0AGaSjAP0q8Z4P8F2jO7mb5gZmj38YgL4s4?=
 =?us-ascii?Q?B5xyWNHOmo7r34QRFwnJ47DklgUYV/6xZLJtSahqC0A8fAUaIRtQNV12QrDz?=
 =?us-ascii?Q?JgHkCoi1S77MzQdYJgrinMmOu6K4HqUympesySCpl/oGOZfVRnR94N5ZdSKl?=
 =?us-ascii?Q?B33BdYBYSjv61Znx1qZCAHsOLAFu/IskGfqEdvtMCs1LCBrRknL8+zrhOjLj?=
 =?us-ascii?Q?BbaojjfxtjylIfG2/9pm3KtYNH9mQDUk7XkKsOuK+C02TagtWCfDpgYdjaoJ?=
 =?us-ascii?Q?hgganFDVVWQqhchCx5aJ5+TjjEv1zjFFXU8gykMvaOaO+tusmu2pRY6hMq4c?=
 =?us-ascii?Q?h3mIJEGwUuiX1tcd2/3wbSZknAoJhpu3ZaoK22O80K1DUza8vG6n/m2h4Q+C?=
 =?us-ascii?Q?hlMMJXQ+t5oTR6yk7iKYlUjkr0Z/pt+9RhcZDZ9ATtzxKf045+HPpqhPlZae?=
 =?us-ascii?Q?O5ffDFqbh/yiH6OSteFdUlla371bleccolOnwGyGtHnW9kTmqdtiF8pQ4HRf?=
 =?us-ascii?Q?Sw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: QApFsEyOZc7Z0VFcrO2olarkcRjjZ3GjZnsfCVYHDOhAxidmJdZicv/R8jISQMXc3SIHB275qFMVvSEBHLec5S8oeU1DFWNoWFkuiUzNX76PwcaiJFhjJCfG8QCL17BjTV2t/5ZJcXYy/7j6FoCG9Ot4LFcX4m4x3Q5L9dmtw5vMAFXP7BgiN91LLLa3DZp8MutEiQq0kcOOmyvcnHfmdNDUA8SBJPeR+s+XRGbBYqggHSzDdqaWeZDFn2LZHVunvZ57IaEEef0JkPZFd5x8+Ls+BRZ++yXSdUHDL5/XbSL6VXrEOeTRA+A2IOi8q/6jes2k2H4KMtzYtmWE6NLu8IewSmF+i6rDPl/iZpnvWluI0i2Pil6dMRRf6So546bjJA6FrNq9T5Rqbj6U3YDENJDjoNPlw0C80WiDa52KX+GsD3eJL6SOhzO5MAYN73XpSCm3ZOSFo92eLIKCjVXYyJBSnV+0Rl44F7V1sbN4jNt5ZRTo8IqobE+GVak3MYNux5kNJtsKMc+AWhG0J+YOA+Z934VX+GbzXhnzF6zUot4Uh0Mh2vdZ7IYOuQLV7XmQewV9Y+54pcxB+xQIM4MEkHVShKoAdmJFI+LqaKYY6Z9L41pNWzseAeK9IdPyXeXp5vuGBlMRF1ZXJpJglm3NG06RRlkGpRjnhF3FJidep9TJ+OCZiXbAIyHqismM0QPyrUH4OOwPeLAT8DR21rfWYDGhZ7ZBhN+VZnjFnXOVfIqDp2KqMiU6ouSBK+EI/Hr6sCc6ngo8YDsKF/5yQlIs2OYMUsw1vw7bWF2U1/dWqlXeThuSJlS5Mq0eo9v01pUlTbmZ3rbwd59hUPfsFGnaIJhgxN9/H8yO4otYw4slPMs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e0c9b37-4902-41f0-c391-08dbd504a2bd
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 02:46:49.0900
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YLqdukAjmJEy+XDm1SDt4QVTwDNnqAO+0fpWRU/gCrw+eJvwmON+jXoKxVRfQI+YJ97Thz3ASY5HCA2JPMX3n1aBiWDCr/XP4d1Asar6mWQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR10MB7924
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-25_01,2023-10-24_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=861
 adultscore=0 bulkscore=0 suspectscore=0 mlxscore=0 phishscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2310170001 definitions=main-2310250022
X-Proofpoint-GUID: QCkA3xUdhLWZX4URy5X9GnwjmKt-zWJG
X-Proofpoint-ORIG-GUID: QCkA3xUdhLWZX4URy5X9GnwjmKt-zWJG
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 24 Oct 2023 19:47:06 -0700 (PDT)


Daniel,

> utf16s_to_utf8s does not NULL terminate the output string. For us to be
> able to add a NULL character when utf16s_to_utf8s returns, we need to
> make sure that there is space for such NULL character at the end of the
> output buffer. We can achieve this by passing an output buffer size to
> utf16s_to_utf8s that is one character less than what we allocated.

Applied to 6.7/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering