Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Wed, 25 Oct 2023 06:25:48 +0200
From:   Michael Walle <michael@walle.cc>
To:     AceLan Kao <acelan.kao@canonical.com>,
        Tudor Ambarus <tudor.ambarus@linaro.org>,
        Pratyush Yadav <pratyush@kernel.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v3=5D_mtd=3A_spi-nor=3A_Improve_?= =?US-ASCII?Q?reporting_for_software_reset_failures?=
User-Agent: K-9 Mail for Android
In-Reply-To: <20231025030501.490355-1-acelan.kao@canonical.com>
References: <20231025030501.490355-1-acelan.kao@canonical.com>
Message-ID: <6B9232E3-7159-4D97-9B40-EE77E2F6EA5B@walle.cc>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

>When the software reset command isn't supported, we now report it
>as an informational message(dev_info) instead of a warning(dev_warn)=2E
>This adjustment helps avoid unnecessary alarm and confusion regarding
>software reset capabilities=2E
>
>v2=2E only lower the priority for the not supported failure
>v3=2E replace ENOTSUPP with EOPNOTSUPP and check the first command only
>
>Signed-off-by: Chia-Lin Kao (AceLan) <acelan=2Ekao@canonical=2Ecom>
>---
> drivers/mtd/spi-nor/core=2Ec | 5 ++++-
> drivers/spi/spi-mem=2Ec      | 2 +-
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/mtd/spi-nor/core=2Ec b/drivers/mtd/spi-nor/core=2Ec
>index 1b0c6770c14e=2E=2E42e52af76289 100644
>--- a/drivers/mtd/spi-nor/core=2Ec
>+++ b/drivers/mtd/spi-nor/core=2Ec
>@@ -3252,7 +3252,10 @@ static void spi_nor_soft_reset(struct spi_nor *nor=
)
>=20
> 	ret =3D spi_mem_exec_op(nor->spimem, &op);
> 	if (ret) {
>-		dev_warn(nor->dev, "Software reset failed: %d\n", ret);
>+		if (ret =3D=3D -EOPNOTSUPP)
>+			dev_info(nor->dev, "Software reset enable command doesn't support: %d=
\n", ret);

As mentioned in the previous version, this doesn't add any useful informat=
ion=2E Please just drop it=2E That is, just guard the current dev_warn() wi=
th "if ret! =3D - EOPNOTSUPP"=2E

>+		else
>+			dev_warn(nor->dev, "Software reset failed: %d\n", ret);
> 		return;
> 	}
>=20
>diff --git a/drivers/spi/spi-mem=2Ec b/drivers/spi/spi-mem=2Ec
>index edd7430d4c05=2E=2E93b77ac0b798 100644
>--- a/drivers/spi/spi-mem=2Ec
>+++ b/drivers/spi/spi-mem=2Ec
>@@ -323,7 +323,7 @@ int spi_mem_exec_op(struct spi_mem *mem, const struct=
 spi_mem_op *op)
> 		return ret;
>=20
> 	if (!spi_mem_internal_supports_op(mem, op))
>-		return -ENOTSUPP;
>+		return -EOPNOTSUPP;

This should be an own patch and you'll have to fix current users of it=2E =
For example, there is at least one in spi-nor core=2E Probably more=2E=20

-michael

>=20
> 	if (ctlr->mem_ops && ctlr->mem_ops->exec_op && !spi_get_csgpiod(mem->sp=
i, 0)) {
> 		ret =3D spi_mem_access_start(mem);