Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2327526rda; Tue, 24 Oct 2023 22:05:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGo8D7FoI/Ie0Wv3s9m8Rl38BnrUrOps6s1fdqx/PxWUiT61LBo84v8GxZPyVbzLOOR8bie X-Received: by 2002:a25:cac7:0:b0:d9a:4fa0:dca9 with SMTP id a190-20020a25cac7000000b00d9a4fa0dca9mr14768022ybg.25.1698210324110; Tue, 24 Oct 2023 22:05:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698210324; cv=none; d=google.com; s=arc-20160816; b=NSQVfLe0VnH5PkpMeIXRmO4d+b3SBN6L4IFD05c7/LaH/bO5IaCujXkFaIF+rmfg5E drD4Z5eTGqrXtM14l+c5rN2l3wuNPHRYz6p0XKZIlu+M6tZuHV4FRBlVb+ZcAGFtKsSh d+DH0ka9PKluIVVKSsouif4bywwA2yc832/R1rVR6hl+evogyqf9hT187FEjaK4jwNQX RpbnymLF+0soX07+JE045uisUmq8V20BZDiL83yn0FYpecSUMCddcCTqHP0RgiYsVHZu Nj0/1pNtHhdDoh34tI5ybrS+1lmBURE6DicvBWxZMA/eo4rk0eCy3XzDUIk/nsnF6MqQ PTpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HRYMc5hT97v2ke9ARcjx9Vm2PZHWdHhGHgkktIQNL8M=; fh=Z21sdrxzgcUFLXsgM94anVuXVDBhMf/so7vHEsei/i0=; b=HWZXyDl74benZjnrJUNqGoOyvZovg8N2iGsg9CUl1g/Je1ZAUr1mEUXocVyuIs7luN vW/X7VwYxYHE5rzdT3J6iZIILKS5/Q1pkuCCPKaPhepnakWEPelEWIETU0dxPXitTu0I tdeTWutePRJivR6OKH+rZpXVB3EAg6W7DRsJjxB4y8MjNy3PYd474RbSVhEDcgn1fPq4 kIi/ISXZf3/5rDRYLdFiigUcrdvMaqAQFUBn6Q6liQlTPAED3Jnm0XnSaVi1bIQEhGDc wt0HgzMBkHYucQEZVuUVciyY/34IviFdNY6wuUVCup4INyEukjnhLRn7su13fjNJVIv/ U90A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iKVqebev; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id b3-20020a25cb03000000b00da042137c59si3211503ybg.333.2023.10.24.22.05.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 22:05:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iKVqebev; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 9AEF4802138A; Tue, 24 Oct 2023 22:05:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230006AbjJYFFQ (ORCPT + 99 others); Wed, 25 Oct 2023 01:05:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjJYFFO (ORCPT ); Wed, 25 Oct 2023 01:05:14 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32AF0E5 for ; Tue, 24 Oct 2023 22:05:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698210313; x=1729746313; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=htZwSr1yPfU4DAE0T3T5Cf6TY9qanaVYs1o0tVaq0Wc=; b=iKVqebevCLwqzVkj9dwmHNNAX8lgMEYXSRQC7kPMkswlQwlHOchgWA+U kjSeIm+bPLbsF8x4LNmZ/ZhdtsBtoouukuQeRdziLJPskJbVriozi5p4p vIpc77wih0/JuOmvQCMs1maaWvXLe3GQb4alOWO5m4io2YGXRCcsVosR6 wUcb8u/UPRyEzeUMPdDW/4hWTBiFIKgDU0xJuf835m/q0f3d5DahQ7Oit 16g7YklgLUQLr3fWpdApfb6DcT99wzE8YHOUxDaGtZq7EUYKlRdmTKKkr Qc78BUL0mN5MAMVp/tiE+z05lpH4QCuMFSXn4J6wBHr45bD1m1eYGSaWU g==; X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="367451383" X-IronPort-AV: E=Sophos;i="6.03,249,1694761200"; d="scan'208";a="367451383" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 22:05:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="882324731" X-IronPort-AV: E=Sophos;i="6.03,249,1694761200"; d="scan'208";a="882324731" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga004.jf.intel.com with ESMTP; 24 Oct 2023 22:05:10 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 0ADD5125; Wed, 25 Oct 2023 08:05:08 +0300 (EEST) Date: Wed, 25 Oct 2023 08:05:08 +0300 From: Mika Westerberg To: AceLan Kao Cc: Tudor Ambarus , Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mtd: spi-nor: Improve reporting for software reset failures Message-ID: <20231025050508.GH3208943@black.fi.intel.com> References: <20231025030501.490355-1-acelan.kao@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231025030501.490355-1-acelan.kao@canonical.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 24 Oct 2023 22:05:21 -0700 (PDT) Hi, On Wed, Oct 25, 2023 at 11:05:01AM +0800, AceLan Kao wrote: > From: "Chia-Lin Kao (AceLan)" > > When the software reset command isn't supported, we now report it > as an informational message(dev_info) instead of a warning(dev_warn). > This adjustment helps avoid unnecessary alarm and confusion regarding > software reset capabilities. > > v2. only lower the priority for the not supported failure > v3. replace ENOTSUPP with EOPNOTSUPP and check the first command only In addition to Michael's comments, please put this version information below the '---' line.