Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <f8d3a930-491c-e79f-47b4-618757b6bebf@axentia.se>
Date:   Wed, 25 Oct 2023 07:45:12 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v4] mux: mmio: use reg property when parent device is not
 a syscon
Content-Language: sv-SE
To:     Andrew Davis <afd@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Nishanth Menon <nm@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231023162659.81397-1-afd@ti.com>
From:   Peter Rosin <peda@axentia.se>
In-Reply-To: <20231023162659.81397-1-afd@ti.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1h1MW9SY0I3UjhWRno4OHdkWTE4Y3RhTkcxcGpvOUpkVjNPbW91dnhyM0pO?=
 =?utf-8?B?T2tGdDcrMG1ycWpCcW5oWnhCdW5CUVRYS2hpK0lObVh6SzUxKzdzdTZEQzhZ?=
 =?utf-8?B?NWhjL2ZIYmhERGUzbDRMdDBDaExwSCt1LzU2RXEzRjNITHhRWXpoWWoxbU1i?=
 =?utf-8?B?ZTJLam9sTVFpQzdOZkw2cU1tVUZqZzJuaWxCcTMxVi94RFdWNjF6cWVuQzdK?=
 =?utf-8?B?bTNQYkJQbk44bUF6czlVeEw2UzFSRmRMWnh6R1diV2dVbVFQcm0rY2pmZWVB?=
 =?utf-8?B?aVU3RHhoVlQxeHdEOWREcnZGOEZjMXoxamVWV0g5RjNXN0duQ2dlREU5L0Fh?=
 =?utf-8?B?MXJ0aERIU2F4S1o5OFpxMEZpLy9zbnlqVzVwZi8vRWNjSGZHT0FnK2U4enBp?=
 =?utf-8?B?Z2tnTDZtN3Nsbm92MnBzL3pseFdMM0FOaEMrL2N3bkEvb3VNMjVsb3N2a1lN?=
 =?utf-8?B?ZThyN2R5VXhsS0h5MTdRdzdZYWtqbFRrS1IrOEcwaDQ1a2Jmd2hURVl1d1E2?=
 =?utf-8?B?dldxZ1RWakx5OW1IKzA4U0F2S2paY0RqRElXczRqWmk2Z2RZQjlyQWRtMHJM?=
 =?utf-8?B?azhOUWRzWE9ya3dJLzJHNHZZS1E3dzFSZUxYbTFENkRXY3ZJbDBtWXI2enow?=
 =?utf-8?B?MUIzS0I1aGZIWnJTUWZpMEUvRjBNTzBLN24vQUV3ZE1TcVFuTm0rcDlZampW?=
 =?utf-8?B?blZJYXRzOENKUWJ2S0c4azd5YXArUW1lb2x0OW80dHFadytSamNhVkptc1Jy?=
 =?utf-8?B?MUZpeUxhSzV6MG9aMDVHdjJpTmNTdFFSNEZaTmRmenBJd2Z3d2ZvOHRVd0tF?=
 =?utf-8?B?Wk5RUnlrRFNwZHVvemxHcVRGeEEyUVY1cE1XeitTVU5OcGRoa05xOUFWR2lq?=
 =?utf-8?B?RUgwRisrTDNUM3pLWE50bWRSdVl6NTc0V3c0NXJqLzE1dUVuWjdZYWI2M3ZG?=
 =?utf-8?B?QmZFM2YxZUQzVVAwcXdFWXhIOTM1SkdXdCtUa0M0QTZKMTF0aXNIU2lxOEZp?=
 =?utf-8?B?T0ZKRUQrMStVYjJHODdpWEFmM245M3VRRTBiOFVmQTFpNFRoZmF0OFZxcVFy?=
 =?utf-8?B?aEQ1TEZ3YWt4NFZpSWZYODFZVDhpdnZ4V2VLZndCRUdxZm9ST05nYjhNWmZC?=
 =?utf-8?B?bEdKWHArdFQ2SkpTTDhycnFwNmNGSEd5bGd5TXNJRTZJZlhTVUZOYTkrNDBZ?=
 =?utf-8?B?WGdSNm1rMFFtVFE4UmtjYVVQcTk2aFdhNCtNM2JWSmg0VkUrd216cFhmY3Fw?=
 =?utf-8?B?WFJmRWdDaGxqUEF3TC9wZklIOEt4RzIzUldHTGFMcjRIVlhQSWxqQmV0V0JL?=
 =?utf-8?B?M1NzS2NNSWxDWTc5Ri9rU3BGa2dqaTFERjUxL0RiSmNLckJDL29Ha0tYTit2?=
 =?utf-8?B?V2tYaU5SSisxb1pLQjNtZG1LZE5VSjZ0UXIrdFZmQ2dacEQxYnU3UHJvdTh1?=
 =?utf-8?B?NVN3akU0YUx1U043K3VJRXg3QnZKRDFYd25aSDMyYXdCUUg4U2VzeERPSjg0?=
 =?utf-8?B?ejU5ZEZRWURRV0VxTXVWYURhKzJEN1YyaTlBOFllc0lsc00xcVhvVGZaajBy?=
 =?utf-8?B?Ymlvc0QwWGJhbTRQQU9CaGd0QzBRUnZwT2xkYlhRWHFBRnRCUFNia0dxUTdY?=
 =?utf-8?B?N0gzdTgrSnhQSWQxOVdVNVByL1VTaTE2blN2ajRYZW81cGFDTkJEVWRrdmVV?=
 =?utf-8?B?eklreUZndWVhM0FvNWZ6Mnp5NTlNM0N5bFBnekdrbzFoMkdIb0tFK2sxWmJk?=
 =?utf-8?B?cER6U2M5Nk5WWEtIU1JwdVpucE5xQkZJalhzK0taaWFaTWVxNkRLcmNyaFUz?=
 =?utf-8?B?cloxNG9HM1BOUjhEQTR2N2xDcmNmRDNIaWh5bk5xRlJsTzFFWTUyeGhDWEdR?=
 =?utf-8?B?S0dmdk9tUmtvdzdnZXRQWlVJb3J3KzFVTmJuMC9OL0tTM1RHSndvWXJCa2Jk?=
 =?utf-8?B?WGs4UWx2cDUwNm9XaUdaeEZKMk0yZlJ2TGlqM0JWblNZZGxPQkNPQnhQaVhC?=
 =?utf-8?B?Ujg3UWRSZVJMWUJMY3A0a1QwQ3FuazgyZWtUeEJ2S3NKdGlXMVkvTHdkOTA3?=
 =?utf-8?B?TmgxeEp1dVM0U1dVcUhwK1BxT256aDRBdkZzTjdCVks3OWVnK0lKcEhETDhZ?=
 =?utf-8?Q?HRf6pOKcPW1X8G1+TqK4v/JgD?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: 0294a174-0f2a-4efc-6479-08dbd51d8f69
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 05:45:14.5804
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2dI1KKDjpF/rr91yKqvngLEqYq+vY+AH6uwDeIlS0kNjZSEcnVeQTdRVaHwJk9pG
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR02MB9953
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 24 Oct 2023 22:45:30 -0700 (PDT)

Hi!

2023-10-23 at 18:26, Andrew Davis wrote:
> The DT binding for the reg-mux compatible states it can be used when the
> "parent device of mux controller is not syscon device". It also allows
> for a reg property. When the reg property is provided, use that to
> identify the address space for this mux. If not provided fallback to
> using the parent device as a regmap provider.
> 
> While here use dev_err_probe() in the error path to prevent printing
> a message on probe defer which now can happen in extra ways.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
> Reviewed-by: Nishanth Menon <nm@ti.com>
> ---
> 
> Changes from v3:
>  - Check for probe defer
> 
> Changes from v2:
>  - Rebased on v6.6-rc1
> 
> Changes from v1:
>  - Flip logic as suggested in v1[0]
> 
> [0] https://lore.kernel.org/lkml/1c27d9d4-b1cc-c158-90f7-f7e47e02c424@ti.com/T/
> 
>  drivers/mux/mmio.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mux/mmio.c b/drivers/mux/mmio.c
> index fd1d121a584ba..07c99588ff999 100644
> --- a/drivers/mux/mmio.c
> +++ b/drivers/mux/mmio.c
> @@ -44,14 +44,17 @@ static int mux_mmio_probe(struct platform_device *pdev)
>  	int ret;
>  	int i;
>  
> -	if (of_device_is_compatible(np, "mmio-mux"))
> +	if (of_device_is_compatible(np, "mmio-mux")) {
>  		regmap = syscon_node_to_regmap(np->parent);
> -	else
> -		regmap = dev_get_regmap(dev->parent, NULL) ?: ERR_PTR(-ENODEV);
> +	} else {
> +		regmap = device_node_to_regmap(np);
> +		/* Fallback to checking the parent node on any error other than probe defer */
> +		if (IS_ERR(regmap) && regmap != ERR_PTR(-EPROBE_DEFER))
> +			regmap = dev_get_regmap(dev->parent, NULL) ?: ERR_PTR(-ENODEV);

I'm not too fond of overly long lines, and the coding style document
agrees with me. Also, please end comments with a period.

		/* Fallback to checking the parent node on "real" errors. */
		if (IS_ERR(regmap) && regmap != ERR_PTR(-EPROBE_DEFER)) {
			regmap = dev_get_regmap(dev->parent, NULL);
			if (!regmap)
				regmap = ERR_PTR(-ENODEV);
		}

> +	}
>  	if (IS_ERR(regmap)) {
>  		ret = PTR_ERR(regmap);
> -		dev_err(dev, "failed to get regmap: %d\n", ret);
> -		return ret;
> +		return dev_err_probe(dev, ret, "failed to get regmap\n");
>  	}

Now that you use dev_err_probe(), please drop the pointless ret
assignment:

 	if (IS_ERR(regmap))
		return dev_err_probe(dev, PTR_ERR(regmap),
				     "failed to get regmap\n");

With those changes, you can add "Acked-by: Peter Rosin <peda@axentia.se>",
so that Greg can pick it up.

Cheers,
Peter

>  
>  	ret = of_property_count_u32_elems(np, "mux-reg-masks");