Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <a97fb789-ce3f-44bc-ab0c-797d18cd2cc3@nvidia.com>
Date:   Wed, 25 Oct 2023 11:54:54 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: drivers/memory/tegra/tegra186.c:74:49: warning: '%u' directive
 output may be truncated writing between 1 and 10 bytes into a region of size
 6
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        kernel test robot <lkp@intel.com>
Cc:     oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
        Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        Thierry Reding <treding@nvidia.com>
References: <202310182004.0XOYolzI-lkp@intel.com>
 <1046b929-8eb6-43bc-9660-a5a1a43916d8@kernel.org>
Content-Language: en-US
From:   Ashish Mhetre <amhetre@nvidia.com>
In-Reply-To: <1046b929-8eb6-43bc-9660-a5a1a43916d8@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?em5vTjh0akYydm1RRm83enpxRkkzNmZRZ3hoRDdUV2Q4Z2llbk40T3hHUDNq?=
 =?utf-8?B?d1lMeEU5alVhN3Z5Z3MzOStuMWVpSUxUQXRLMzFORjZYUnBCYk1OVzh5eW55?=
 =?utf-8?B?Wkl0VWc2UFBqWDRlMTd0N3FVa2V5Mmd6azlQTyt5aEUxL1RlR3RUaWx0MHFl?=
 =?utf-8?B?dXNkQ2VLM0tlVFhka1lYN0lXYzJvU01jNk9nM1FaclpVMExlMFJtdTZUS3ln?=
 =?utf-8?B?MFBudmJjQ3hJUVc3eGFLTXVoOWlPRHRKdlF4SHE1YTlzRnNuT3JCU251SkxH?=
 =?utf-8?B?OTVZV05SNUVjL2pMaXcyOThMOTBMSFR1ZFdTSHZCbWNrYXR0T2JlbXBzckM1?=
 =?utf-8?B?RjhYLzEvUjJ4T3pvOFpkaHFNN0crWHZEcFd2RmJ6eURXcjRVQ1gzNUU1eDNj?=
 =?utf-8?B?RnFrZVcxMjYxN3NtWFdPcUVid0Z1VVVvRXBHNVMwcUVZeXE2VU1FR0c0WEdM?=
 =?utf-8?B?ZEtMOU1FMnZOalhDMEsrZHVMNFdwMGppZFpWOUxqdjl6Q0hHZ1hTSWFjOGlX?=
 =?utf-8?B?Zy9wOU1INTBmY3J6YjVLZHFxSXExSFZhRzRvZDh4UklPbVNiOG1BSldpbDRM?=
 =?utf-8?B?dElIU0k1bTdYN2hKTHdBelloTlFkZzczYTJ1RlZDNFdndFltbTB4REtEZlYy?=
 =?utf-8?B?Y0RzWFlxYXBxMEpzWDlkVGRqckVFS0ZpSEFNS3M1SkJURWpLYzUzSFdHMjU3?=
 =?utf-8?B?bnZCVzQzWWFsU21WYzZHekhBamxtaVlxZzhXWlBOS25oNlZNT3QxVjNydk5h?=
 =?utf-8?B?NU9GaDRTUUN4ZUVWL0UxQU41RDFwY055RE9Nb1hQT2FRdlEydm9SR3crSWRU?=
 =?utf-8?B?QjBpdk82VHlsTlJZUitGbzhqUmpvckRodk0vdXNmT3JsTUhzVG5RNXA1WGFy?=
 =?utf-8?B?RnpKemphaDlSaEtlNGpmQ09pZW05VjlwNE5YdEMrS21GTGpacHVwWEdVOGtq?=
 =?utf-8?B?Zk1jcDMrK09JNFZKRnVoZHF2ZDRaanpDbkkrcFRFbE5IMkphR3JiTzA5L3JL?=
 =?utf-8?B?Ri9JVXFPcnAycDZHN1AyOWxtRlprRG1WVXgzRDdhVnVIbS9XMzZBZnRYaUU2?=
 =?utf-8?B?STM3QmFoM0ZZYjEzU25zbnYrT2w2bmlaYkVHdHZrajJEeWNWaGIrN1FoeHdp?=
 =?utf-8?B?VGhoM0JheTZsUXA0UHZ6enBvOVVBdXBtYjZiQ0hHNlh1Tlp6N3M0dWRiR0pq?=
 =?utf-8?B?SWVRQmRUbnFudmJQK0gzOFdlVVVmVUhqNzJLTjN2VG1hUGtBcjBZL0IzZDI1?=
 =?utf-8?B?MzFBWmVNalAxMkFEYVhNUzl5SzRqVnd2ZHlMb0JIeFpNekRkZGhuOGl2bVFM?=
 =?utf-8?B?d28zcWVrb1k4VXJUb1Y4RCtZTm9YRlJtS2V3VmRoK1RTQjZyMTczT2xiWXJ6?=
 =?utf-8?B?WEhEY2VOaFAwSEQzd0pwbHhZSnp6ejMveFNRc0lVRzJMZmM4WGl1bnFMNzZF?=
 =?utf-8?B?RlhMNGR3Z0QyRkZ5Q3V4M1lSUEJ0MmZVYjNVZVM0bVNrNWhIaFhHL1VuVS83?=
 =?utf-8?B?bTc2UWxDd1U2RU9QQVZCUmVNd3NiUS9vcTRUQnF4SHJRYklmWlJJdUxuMXpO?=
 =?utf-8?B?STZ5SVZXOG43L0ZVanQwUlNVVnFCVW05N1FNc2tNY3BObG56MWdwc1BvWlNk?=
 =?utf-8?B?TDNtb0lmM2JQQ3hNTXpjdDFOL3RXMi9yS3AweWIvTlQwQkJJRjRLK05HQ29w?=
 =?utf-8?B?Ry8rNUhDSlROZkNjOGtnYjV0WWRrM3o3WGJ6UldzZjBESXgvNE91VFJqZHBB?=
 =?utf-8?B?SXRkTFlnbEJoSVNiQ2F3WVNLVEJpbHYrUGlUdGlLZDVCejlBUmhWVWNjckRk?=
 =?utf-8?B?UmRVL1dkYzdzYk92RnJqcWpLT0ZhYXJYYTlxNWhqb1M1MlhxRUhCV2ZWdG9x?=
 =?utf-8?B?RldDWEt1Yitid3RpYmZRc0N6SGhnNzNQL3llSVhUK21qdDJpVHRvaGQ3NUVR?=
 =?utf-8?B?dEVyOVY3SFVvaXFDVUN4VHhyNksxQTRsTkQzYXFrTElFQlV6OUQ4MEYyeVhO?=
 =?utf-8?B?OW9mNmNZNmFRT3g0UkpFOHZKa3FMZ25Sdk5LdmNBV3JObXhpcnQ0U1BtWEJr?=
 =?utf-8?B?Q1FON3NwT3hCRVI1aUR1ZXpIT1l0azJ1L0czcVRlVnBpNE4yeVBoS3A1M2p0?=
 =?utf-8?Q?PWbMc7d3von3s9Dszk1zr3P0T?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0663280f-0ef1-486c-4b80-08dbd5231cb1
X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7432.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 06:24:58.8240
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5zv7aBe8gUtm/PnQOAvIyUa/G7JKEIHTJ5vplhbNcYHJE0LvxGrJBSzFKORkjSlCTzIK7IU8TqMlddCt9EDumg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6484
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 24 Oct 2023 23:25:22 -0700 (PDT)


On 10/19/2023 7:06 PM, Krzysztof Kozlowski wrote:
> External email: Use caution opening links or attachments
>
>
> On 18/10/2023 14:32, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head:   06dc10eae55b5ceabfef287a7e5f16ceea204aa0
>> commit: a7cffa11fa9232eabf0c4f441dc53002978ab526 memory: tegra: Add memory controller channels support
>> date:   1 year, 5 months ago
>> config: arm64-randconfig-r036-20230512 (https://download.01.org/0day-ci/archive/20231018/202310182004.0XOYolzI-lkp@intel.com/config)
>> compiler: aarch64-linux-gcc (GCC) 11.3.0
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231018/202310182004.0XOYolzI-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202310182004.0XOYolzI-lkp@intel.com/
>>
>> All warnings (new ones prefixed by >>):
> Ashish,
>
> Are you planning to respond to this?
>
> Best regards,
> Krzysztof

Hi Krzysztof,

The value of mc->soc->num_channels is not more that 16. The number of
characters written in 'name' variable won't be more than 4 which is less
than buffer size of 8 bytes. So, can we ignore this warning?
If not, then I can fix this with a patch to check the return value of
snprintf and compare that with size of buffer 'name'. Something like:

-               snprintf(name, sizeof(name), "ch%u", i);
+               int n = snprintf(name, sizeof(name), "ch%u", i);
+
+               if (n < 0) {
+                       dev_err(&pdev->dev, "snprintf failed\n");
+                       return -EFAULT;
+               }
+               if ((size_t)n > sizeof(name)) {
+                       dev_err(&pdev->dev, "snprintf output is 
truncated\n");
+                       return -EFAULT;
+               }

Thanks,

Ashish Mhetre