Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <d97b7d9c-e5e4-8352-d805-e7ebcbad80e3@nvidia.com>
Date:   Wed, 25 Oct 2023 09:26:29 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v2 iproute2-next 2/3] rdma: Add an option to set
 privileged QKEY parameter
Content-Language: en-US
To:     David Ahern <dsahern@gmail.com>, jgg@ziepe.ca, leon@kernel.org,
        stephen@networkplumber.org
Cc:     netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
        linuxarm@huawei.com, linux-kernel@vger.kernel.org,
        huangjunxian6@hisilicon.com, michaelgur@nvidia.com
References: <20231023112217.3439-1-phaddad@nvidia.com>
 <20231023112217.3439-3-phaddad@nvidia.com>
 <6a1632a4-28fd-4fdd-b9ff-34dd2f0bba88@gmail.com>
From:   Patrisious Haddad <phaddad@nvidia.com>
In-Reply-To: <6a1632a4-28fd-4fdd-b9ff-34dd2f0bba88@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkJDaWdYRDkwRmZQRXdxT205eGs1Zjh6TEpHOXl2Qm94V0xvNXd3cnp5bnFu?=
 =?utf-8?B?aTEvUERTWWgvU1lFd2lGaHl0eG40NE8xNHdrRnJkSlRza29SY3B3eVl3aW9U?=
 =?utf-8?B?ck10YVZjNGN0UUtOcHlCS0swY1o0dm8wdW1kdVlvY3JYMHpJS3I1Smhud2FY?=
 =?utf-8?B?SVN0VEVYOS9mTFhPUlM3VUNDZ05UY2FTNno0QTdnNVZ2MlhDWTVHc29JVC9F?=
 =?utf-8?B?aDdFcHBndGgyUytZRmRBQTJBQnBoQ0d2K25kMDF0Y1ZnWnoyYnQwaDh2VlVs?=
 =?utf-8?B?WXVHUGhaZ25wcWViOE1KUVBzL3N6Zk9CWDZGUEUySlh1d0NWTXZBTXYvanB1?=
 =?utf-8?B?Uy8rSzVGbG9KUWhpemc2QlJFUVc2Tm5ZN0I4SllyeXE3cEo4TnNxY0JqQXhH?=
 =?utf-8?B?ZVdCZVcrVUFZbWtneFE1alpCVFZmM2I0eUloeEZNeWJCNnFUaEJOakdPanZm?=
 =?utf-8?B?TDdZV0c2RUloWTJIMUpSLzlaaU5WVmpFK2VTOExON0E2RHhmeEp5eVlXOGFD?=
 =?utf-8?B?czh3OU11L2MxYUF4aGFnYU1TYzRvOGtuaGcyWU1SdGpLMjM0c0lsSWJaVnhR?=
 =?utf-8?B?UTdwaURzaGQrc1BNNHlxRHhRUmZSQUpYcE5BVW5rS05HbzZFVUVKY0VOSGEv?=
 =?utf-8?B?WlFURGE3eDc5Q0dEd0tWQkxBOE0rdjUvRzRqbEprYlNNK1cyNS85QU5qRndK?=
 =?utf-8?B?VEpJQ2laSTZISTNaajhabGY2UjFwSk1MNk5GK01OYlZ1UnBLTXEwUFR2dlNu?=
 =?utf-8?B?cWVRQW5jTUVRd0x5a0VwOElIVURBc01TYmd4RHdmQWE2cXlkU2Z5OTI1SW5V?=
 =?utf-8?B?QkZNS2U3NURCZktoZzhiV0tBcmhBbDFseUkwTEl6ZnlFWklVSmpBT3pnc09T?=
 =?utf-8?B?RnNvMmRTZ2ZyUVF0R2hFWlE5UmZwWkNORXJVdmdRMTFYM2QwQzRWODR2OG5j?=
 =?utf-8?B?cU5XcGR1UVJUdi9WTUdGV05lTWxkTjVlRFRNWWhNdFFNSFV4SitVRm9FRExI?=
 =?utf-8?B?alRLVFJwSEkwKzk4RnRZbTh6cWd5aWRxc0JXTW5Ic2docDQ2TnZVMGNYQWZT?=
 =?utf-8?B?QVVSaGpQaVJVTWdrc3h1SyttOWZ5ZVpDbWxGclVSZzlxTUpCWi9mYTRPQUJQ?=
 =?utf-8?B?V2ZXQnpqS1hCL2ZmeXV0RkV3c0FXSDNvMXAwSUdsZ1Q4WjdXL2NPZThSalBz?=
 =?utf-8?B?QWYwZWh3UFpuMXVkWmRiNFRyWEs4b0YxU0JtcU5vd3UyZktSOUJoWXBBZm1F?=
 =?utf-8?B?dlRtR2xOTHVwK3gwUXJhY1JQb09aZ2dzY0QzSGZTaEhndFhxeHNQcklOOWU0?=
 =?utf-8?B?eTg2REFkK2hCVTEySnZHSjBFSTNLOXRBNUlRNzhEcm9PeDF3RmtWY1hRRkFT?=
 =?utf-8?B?NGh2U1R0S3Q2QXFEbWpBYW0wTUpoRlZSYkpMOWRwS29JME9vRk40NGtNWEg4?=
 =?utf-8?B?NHYyd01HbFNjZ1EyeXJBaDZ6VjJmWkV4a3ZOSU1laDBHQjhRVVRnZElpRFpO?=
 =?utf-8?B?aVZLaEIzTDFhMlFhUFRCVWFyM1pGU00vNlB1eHlEak8xNlB2Wk1oeEVxN25r?=
 =?utf-8?B?K3E3Z01Ua3c5L29tenMzVkVDbnYvY2FkbmxSNlJPUE1YeFJHSFBGaWxVVEtv?=
 =?utf-8?B?RFo4R09FYjhZUDB2U05vck1KcUIycFdYQ2hXZVY5c0Y2SnNXVHRydGxkU21Z?=
 =?utf-8?B?d2s3T2R5S1Q0am1KYWtMNCt4bEx5eU5KZ1JUSFc0ZldtVUtlckc0bFFUbFhX?=
 =?utf-8?B?N0JYbFFkR2VWNENCSk80aVJGZ3dHU21NTkZ0d3UwYVZjZ3Zrd0hMY3hPdHY5?=
 =?utf-8?B?bUttbDBPcDBJOEhuYmtVK0lFMlVUeGxwMlhPRzAwRGU1UHJNVGlUMnRUZjR6?=
 =?utf-8?B?ZUhwQ2tSZ3cyQkFPdlFuMFpkc1ljMFVEY2ZnaFRzV3N2Y0ZLL2dVNlYvcUVB?=
 =?utf-8?B?Nm5SYXc2VWtJMVZRS3dmdCtGMU9lZGh5YlN5U1h2bmR2dmhRSHdtamVKSkFp?=
 =?utf-8?B?MWZvTkw4NWVRQ3NkQmpJNFE5dkJTQWxmRk5TMUlHUGplcUYvYlhtRzhZTlNa?=
 =?utf-8?B?YmRSN2JubWhmWnloeFhHSUdOZUxaNXZPcmxrTXlGbXMzVFZ1WTRXQWxkZGk4?=
 =?utf-8?Q?t0+cz3GnGRAdqHsQbqfXtXAGJ?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d271c0a1-efcf-489b-f1e1-08dbd523569f
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6660.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 06:26:36.0012
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AupmIhkDPcnvimQe+EVnqrYM5mgoNWD8OwaBwUW5JFJ75bDh7zRu48VhtiHwrMsTQh3r89MUGXbNUDMReRngQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4050
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 24 Oct 2023 23:26:58 -0700 (PDT)


On 10/24/2023 8:02 PM, David Ahern wrote:
> External email: Use caution opening links or attachments
>
>
> On 10/23/23 5:22 AM, Patrisious Haddad wrote:
>> diff --git a/rdma/sys.c b/rdma/sys.c
>> index fd785b25..db34cb41 100644
>> --- a/rdma/sys.c
>> +++ b/rdma/sys.c
>> @@ -40,6 +40,17 @@ static int sys_show_parse_cb(const struct nlmsghdr *nlh, void *data)
>>                                   mode_str);
>>        }
>>
>> +     if (tb[RDMA_NLDEV_SYS_ATTR_PRIVILEGED_QKEY_MODE]) {
>> +             uint8_t pqkey_mode;
>> +
>> +             pqkey_mode =
>> +                     mnl_attr_get_u8(tb[RDMA_NLDEV_SYS_ATTR_PRIVILEGED_QKEY_MODE]);
> just make it mode so it fits on one line.
will do.
>
> 40 characters for an attribute name .... I will never understand this
> fascination with writing a sentence for an attribute name.
me neither, just following the naming convention in 
rdma/include/uapi/rdma/rdma_netlink.h sadly ...
>
>> +
>> +             print_color_on_off(PRINT_ANY, COLOR_NONE, "privileged-qkey",
>> +                                "privileged-qkey %s ", pqkey_mode);
>> +
>> +     }
>> +
>>        if (tb[RDMA_NLDEV_SYS_ATTR_COPY_ON_FORK])
>>                cof = mnl_attr_get_u8(tb[RDMA_NLDEV_SYS_ATTR_COPY_ON_FORK]);
>>
> keep Petr's reviewed-by tag on the respin.
will do, just making sure I understand "the respin" , you mean when I 
re-send it ?