Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
From:   "Wang, Xiao W" <xiao.w.wang@intel.com>
To:     Charlie Jenkins <charlie@rivosinc.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Conor Dooley <conor@kernel.org>,
        Samuel Holland <samuel.holland@sifive.com>,
        David Laight <David.Laight@aculab.com>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
CC:     Paul Walmsley <paul.walmsley@sifive.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Arnd Bergmann <arnd@arndb.de>
Subject: RE: [PATCH v7 2/4] riscv: Checksum header
Thread-Topic: [PATCH v7 2/4] riscv: Checksum header
Thread-Index: AQHZ6yms6aorkSEK5k6453Q63ctFM7BaOtGA
Date:   Wed, 25 Oct 2023 06:50:05 +0000
Message-ID: <DM8PR11MB575134C301E7E17E72281CFAB8DEA@DM8PR11MB5751.namprd11.prod.outlook.com>
References: <20230919-optimize_checksum-v7-0-06c7d0ddd5d6@rivosinc.com>
 <20230919-optimize_checksum-v7-2-06c7d0ddd5d6@rivosinc.com>
In-Reply-To: <20230919-optimize_checksum-v7-2-06c7d0ddd5d6@rivosinc.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?1yzIe1PoURBJ1OeXU2VzBkhO/55jBQguVqE9CJtyYThvd6m9J11CaLU/?=
 =?Windows-1252?Q?hrwJuYRE2O4v5yEoTedU2XVyX03gGO2BrzCcj34uVaLYQXc+OdGnlePq?=
 =?Windows-1252?Q?w3t8WNJls+QoWNuszYY3KIS0/lMd7eqwW/9f3sH4opzbvnGFOUkBpRkr?=
 =?Windows-1252?Q?jriacQaxcYB9GzUwsUhgBp3l02k31vci6Aij8ZNXH2iGFOlbJM5VIY1R?=
 =?Windows-1252?Q?NLfrQ5FOFPjqBfCqREbLv/kcZkv5JUXMiE293wddVdrtTJo2O3y7MZrz?=
 =?Windows-1252?Q?BmqGaj+IEWk4skGYZnHBsFBQhi1yXc6a7FMs+k5KDjwIr9wa9jpULiE5?=
 =?Windows-1252?Q?/ufBs9WVVHwqXepsGX0RYMdVC3vvtzMH4qVyEbbnQYkzBfoOx7lrnt4j?=
 =?Windows-1252?Q?Jx/SfkiROAoS1er5AADdlyzgvHYrY+MYOmVAJsbyWiUFx8Dt9JH/YaSU?=
 =?Windows-1252?Q?aA3cjPEaRN5rozBIQbbe5QvV35qPpcXPRZl6sQATQFele3laqsEQZC3w?=
 =?Windows-1252?Q?2LOno0L4nlgHvD4bubLucNfLXl/6Z0HZEW1oNP8AaEZfgUdaYMeTnRBQ?=
 =?Windows-1252?Q?vpAPsnPRvJp0SlczO93X4xTWcbLeyXerWwpBff3xMVYn/y39IwexJcQv?=
 =?Windows-1252?Q?sjnL37Kt7ELWOp4l1yMFVfJFBjknCj1tI2Tl8YmlTxyXzShT98YOaBep?=
 =?Windows-1252?Q?IRZjIV9J1s65VIhqjT5Fj+SZiet3PTo5+YrzL9v7CmsDRWh50K6q2DrQ?=
 =?Windows-1252?Q?7/qoZKL4XqHhpAlY7VB9LmPcs5dzs244SIIcHFKcfauqAMBfih7G+iIJ?=
 =?Windows-1252?Q?23BPQboqNrMTP7s5FaGZyBg5+dFgg6pX8RFuaHzsB/LM9szmbwjWa4LN?=
 =?Windows-1252?Q?lf8lVqKE9+kuNkHr60bYGWZ8KDUbZxWDTwOvXFIt6JFf7hkEiuYu76Ll?=
 =?Windows-1252?Q?pbml8xVXOn1yBBGR4zHLGdtQNWy/hoaTmr+rSR/Ty6r84oE5VbBNnZGh?=
 =?Windows-1252?Q?eiKlLVGWmR9ESPEdwHlVkPax/sKiidaT5TrU+ZX9jwJ82P+dH4R37aeJ?=
 =?Windows-1252?Q?XzCOq2qdh3wjK2eY0no9nVXCx2dvMM/lKFumGGkPxucWu0q/LFj6TalS?=
 =?Windows-1252?Q?ccXI0BQxAs6GcM890aXiInmzjF0R8xZIf3skyCg8ZZ/XWS1S7uUaxnJ1?=
 =?Windows-1252?Q?UjNr5bpKp2IBpZrAk5mQf9lLpnkpEK1+00JwBiquUf2MfnPAITYVhjXD?=
 =?Windows-1252?Q?uob5NMR5zRLkjPhFsrH+xhlYowBStL++eDlCEnDx8khdlCJVxRaWJpjr?=
 =?Windows-1252?Q?PcRefCiwOVjotZ9KAMo8mn4GgiP+K+2EntA7kCXbLvnnI6RqEaxasA+M?=
 =?Windows-1252?Q?tBNrq2uwBOiJ7s0r0t+KvZJ5A7e55CA84KXljFPcDiDoDElM4DRyH5Cc?=
 =?Windows-1252?Q?7v7sQ+cLc5EoMplvBiOqHgUdpd2Mou1xffJUcxALi83v884nUpTBwgGj?=
 =?Windows-1252?Q?RoDVU1p+NwG3hIN3arcDO3Tl7813xqRMU9wV72/PkQOvwmqf651QHxER?=
 =?Windows-1252?Q?ajEvfQpk35e5u964LrZ4zV1Qtalj5pFWsFo9hXcNpkpwGs3Vcp04Q6dg?=
 =?Windows-1252?Q?GUCWYuWzIueDxSre8Da6IN3HrV9P7qnZJdoNzl0h5MUDK3/ecCtt4AZA?=
 =?Windows-1252?Q?ftso72W150xZNyr2aLp8z3iZwe5ersbU?=
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5751.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 81a6e41c-cb3e-49bd-fdc3-08dbd5269ee2
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2023 06:50:05.3721
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EbwYgF6V8G69WdsD1uOEFWdI9vzvcEctAbMcc4Ska6q5MivlmR5wuiklUr3DTxW8Vgr1qU9wPsj8WpAL9DPeSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7772
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 24 Oct 2023 23:50:30 -0700 (PDT)

Hi Charlie,

> -----Original Message-----
> From: linux-riscv <linux-riscv-bounces@lists.infradead.org> On Behalf Of
> Charlie Jenkins
> Sent: Wednesday, September 20, 2023 2:45 AM
> To: Charlie Jenkins <charlie@rivosinc.com>; Palmer Dabbelt
> <palmer@dabbelt.com>; Conor Dooley <conor@kernel.org>; Samuel Holland
> <samuel.holland@sifive.com>; David Laight <David.Laight@aculab.com>;
> linux-riscv@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
> arch@vger.kernel.org
> Cc: Paul Walmsley <paul.walmsley@sifive.com>; Albert Ou
> <aou@eecs.berkeley.edu>; Arnd Bergmann <arnd@arndb.de>
> Subject: [PATCH v7 2/4] riscv: Checksum header
>=20
> Provide checksum algorithms that have been designed to leverage riscv
> instructions such as rotate. In 64-bit, can take advantage of the larger
> register to avoid some overflow checking.
>=20
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> ---
>  arch/riscv/include/asm/checksum.h | 79
> +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 79 insertions(+)
>=20
> diff --git a/arch/riscv/include/asm/checksum.h
> b/arch/riscv/include/asm/checksum.h
> new file mode 100644
> index 000000000000..dc0dd89f2a13
> --- /dev/null
> +++ b/arch/riscv/include/asm/checksum.h
> @@ -0,0 +1,79 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * IP checksum routines
> + *
> + * Copyright (C) 2023 Rivos Inc.
> + */
> +#ifndef __ASM_RISCV_CHECKSUM_H
> +#define __ASM_RISCV_CHECKSUM_H
> +
> +#include <linux/in6.h>
> +#include <linux/uaccess.h>
> +
> +#define ip_fast_csum ip_fast_csum
> +
> +#include <asm-generic/checksum.h>
> +
> +/*
> + * Quickly compute an IP checksum with the assumption that IPv4 headers
> will
> + * always be in multiples of 32-bits, and have an ihl of at least 5.
> + * @ihl is the number of 32 bit segments and must be greater than or equ=
al
> to 5.
> + * @iph is assumed to be word aligned.

Not sure if the assumption is always true. It looks the implementation in "=
lib/checksum.c" doesn't take this assumption.
The ip header can comes after a 14-Byte ether header, which may start from =
a word-aligned or DMA friendly address.

> + */
> +static inline __sum16 ip_fast_csum(const void *iph, unsigned int ihl)
> +{
> +	unsigned long csum =3D 0;
> +	int pos =3D 0;
> +
> +	do {
> +		csum +=3D ((const unsigned int *)iph)[pos];
> +		if (IS_ENABLED(CONFIG_32BIT))
> +			csum +=3D csum < ((const unsigned int *)iph)[pos];
> +	} while (++pos < ihl);
> +
> +	/*
> +	 * ZBB only saves three instructions on 32-bit and five on 64-bit so no=
t
> +	 * worth checking if supported without Alternatives.
> +	 */
> +	if (IS_ENABLED(CONFIG_RISCV_ISA_ZBB) &&
> +	    IS_ENABLED(CONFIG_RISCV_ALTERNATIVE)) {
> +		unsigned long fold_temp;
> +
> +		asm_volatile_goto(ALTERNATIVE("j %l[no_zbb]", "nop", 0,
> +					      RISCV_ISA_EXT_ZBB, 1)
> +		    :
> +		    :
> +		    :
> +		    : no_zbb);
> +
> +		if (IS_ENABLED(CONFIG_32BIT)) {
> +			asm(".option push				\n\
> +			.option arch,+zbb				\n\
> +				not	%[fold_temp], %[csum]
> 	\n\
> +				rori	%[csum], %[csum], 16		\n\
> +				sub	%[csum], %[fold_temp], %[csum]
> 	\n\
> +			.option pop"
> +			: [csum] "+r" (csum), [fold_temp] "=3D&r" (fold_temp));
> +		} else {
> +			asm(".option push				\n\
> +			.option arch,+zbb				\n\
> +				rori	%[fold_temp], %[csum], 32	\n\
> +				add	%[csum], %[fold_temp], %[csum]
> 	\n\
> +				srli	%[csum], %[csum], 32		\n\
> +				not	%[fold_temp], %[csum]
> 	\n\
> +				roriw	%[csum], %[csum], 16		\n\
> +				subw	%[csum], %[fold_temp], %[csum]
> 	\n\
> +			.option pop"
> +			: [csum] "+r" (csum), [fold_temp] "=3D&r" (fold_temp));
> +		}
> +		return csum >> 16;
> +	}
> +no_zbb:
> +#ifndef CONFIG_32BIT
> +	csum +=3D (csum >> 32) | (csum << 32);

Just like patch 3/4 does, we can call ror64(csum, 32).

BRs,
Xiao

> +	csum >>=3D 32;
> +#endif
> +	return csum_fold((__force __wsum)csum);
> +}
> +
> +#endif // __ASM_RISCV_CHECKSUM_H
>=20
> --
> 2.42.0
>=20
>=20
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv