Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   Flavio Suligoi <f.suligoi@asem.it>
To:     Conor Dooley <conor@kernel.org>
CC:     Lee Jones <lee@kernel.org>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Jingoo Han <jingoohan1@gmail.com>,
        Helge Deller <deller@gmx.de>, Pavel Machek <pavel@ucw.cz>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/1] dt-bindings: backlight: mp3309c: remove two required
 properties
Thread-Topic: [PATCH 1/1] dt-bindings: backlight: mp3309c: remove two required
 properties
Thread-Index: AQHaA10IhwE5ZkDArkS4RoPMFlMBm7BS1g+AgARFCACAAHpeAIAA+0AQgACAlACAAQj6QA==
Date:   Wed, 25 Oct 2023 07:02:02 +0000
Message-ID: <DU2PR01MB803494D40BCC004F269080C1F9DEA@DU2PR01MB8034.eurprd01.prod.exchangelabs.com>
References: <20231020135434.2598578-1-f.suligoi@asem.it>
 <20231020135434.2598578-2-f.suligoi@asem.it>
 <20231020-moonrise-senate-86d0edb2d404@spud>
 <DU2PR01MB803498DFD93E82DD3947D72DF9D8A@DU2PR01MB8034.eurprd01.prod.exchangelabs.com>
 <20231023-anybody-silver-4548023f8f26@spud>
 <DU2PR01MB8034CF8EE4358B9446809AA2F9DFA@DU2PR01MB8034.eurprd01.prod.exchangelabs.com>
 <20231024-paddling-spongy-be82eae03228@spud>
In-Reply-To: <20231024-paddling-spongy-be82eae03228@spud>
Accept-Language: it-IT, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2TGWzRncV+BkhSyfcMj6KVXaRAdnYmnVr0QYX2HIOU+U44OGHSoqAQcx013t?=
 =?us-ascii?Q?00XGnrpBOZsuqj3gbMGIZ4oNZVtb6rSgkcYrGJsE/i5QlXB7cnUKaGQrNo9o?=
 =?us-ascii?Q?XcxX3+QiIwD4hLBRCElL1dyu/4/GIirboiqZZJ+OK+iNHGuGy9BFlru9SGP2?=
 =?us-ascii?Q?6TdAfGQMp1DGtCFeeH4gM++7JqL57MCCupL2ayv2zNX6MwuYTrUwvbitLSX5?=
 =?us-ascii?Q?vWo1E3D64pLYDfk9KDGKzlT4OnKBJo3QQlVUuJ9oXaBFR0YtaeFZZwmxYIF4?=
 =?us-ascii?Q?llU+PsdmO/5eeV5pM6d5K+N9JS0oNC3c5U4nVyiFIZxFZz7EJhfsDpuG5/Me?=
 =?us-ascii?Q?Cjxcjb6KBLNPoCIVR/A918PWYX9HQ3kawoLnCUxgooOPBxJHl5P52BtKKwuP?=
 =?us-ascii?Q?eqfZIQtaKb4xQB4tb7VoUIPgv5NQPmBtV6nJ2PnWhxnGlc3RFFe2lVSqmUAB?=
 =?us-ascii?Q?mz8UWv1Jvl3RzoRaE1jNUu+vSfmFNJRja0NSSDMu5Zu/8t+hrVBC7Pg0Gxvw?=
 =?us-ascii?Q?N2qnrJ0GIbT9BsY5hMMSS9aXt3mgVjgJIDN2xFJnGydq1f1OZEYcHDUHApQK?=
 =?us-ascii?Q?/eh6l5n5T4N/fPP3kzPVRxoLDsM3eN+9h0R+wXOwGgec+8wzyFX6Rt8Wa7pB?=
 =?us-ascii?Q?G4QI9F6A5CmvThsbtQDtc9B7kSglkPAxG6F3ML8/EqIvBitm8252zldnVx44?=
 =?us-ascii?Q?G9BeVhi3oGg8zfuqukDnCQwIZny0yKr7YNnNmZoOR4psxC37mC5hXscVLYqR?=
 =?us-ascii?Q?ksHfej1TUj1A16WiNpWOMK9aTGFXj2g0tcqTu9kQuefZb1CpjCzNLd7by6rn?=
 =?us-ascii?Q?MtrxK6DwS7cKVxO4Dk4L5ITD6+K7n3SYSk7Gq1HQjgnYfw4dFetoKZ9jsyNt?=
 =?us-ascii?Q?a2BnOBUaY/Yt5KxunMHlq+oPjdkDVM3XWtj3RUCBC9RfmwkyYGzFxrDfvSr8?=
 =?us-ascii?Q?RW8I0UAdno/RYPYEpBrxQB4etOpFWh+XAOcDjKnfH6RPs4FELPeZxGmJGl4v?=
 =?us-ascii?Q?6/CE7omduX7tiM0bG78bhmlHapMkgyy1or9swPxbX3Eo+ual+ryxwXROZ+Sp?=
 =?us-ascii?Q?ZzOMclDsFKxjWAQe3amRn4joZw8JV5SFzo+ZZckx/u0qMSTPCNIArRhG/q/C?=
 =?us-ascii?Q?55Z1tvFnbAZdx8uVBuCcYTza/faCsDlebd5DrNnUhkWelGryohrb4ldgg5d9?=
 =?us-ascii?Q?OH1CsEpzdqRJp3PNxRMPc974QaG37QOKlSgwaWn7w5XUJTF3Gzxqrl7ct7KO?=
 =?us-ascii?Q?uLuckFisXk9MORPQ04i6cZQfxp2QiypCkjj4gu79GhrAt6LAnCWIFFimkdjO?=
 =?us-ascii?Q?ac1zO5mjIb0FJ32zWPDwhWLzB+4bFv+y9zSvH2y06kraFHGZl6P+QLWWv7ou?=
 =?us-ascii?Q?Ha8/LJmi/ckwd55l1VzWuIMSa1jUlkAqQkUkU22xQSROkxb4WhdqDLPiE7Xm?=
 =?us-ascii?Q?gJsoygOZEgJrvHACR2DS5wEW6f/+5rdBCZZ0SYmv+FMOLSV8D2h8vlUDENUb?=
 =?us-ascii?Q?BRcMIPf0okVmbRtb40KhAOyiihmbsggdKBie8srqDkFlo+1ONbMEGXhUZh4z?=
 =?us-ascii?Q?raORVW73yUjlkB53lZI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: asem.it
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR01MB8034.eurprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5539598-dfee-437d-29a6-08dbd5284a40
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2023 07:02:02.3812
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d0a766c6-7992-4344-a4a2-a467a7bb1ed2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qHs2W26yRDAoDJ7OXw2jMjfPDN3ZJRPNviK3vxNuHnh2q93I2lTRbm9GSrIGgZmcPa7P03qXq8Ed5z5aZzacNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR01MB7509
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 25 Oct 2023 00:02:32 -0700 (PDT)

Hi Conor,

...

> > > > > > The two properties:
> > > > > >
> > > > > > - max-brightness
> > > > > > - default brightness
> > > > > >
> > > > > > are not really required, so they can be removed from the "requi=
red"
> > > > > > section.
> > > > >
> > > > > Why are they not required? You need to provide an explanation.
> > > >
> > > > The "max-brightness" is not more used now in the driver (I used it
> > > > in the first version of the driver).
> > >
> > > If it is not used any more, what happens when someone passes an old
> > > devicetree to the kernel, that contains max-brightness, but not any
> > > of your new properties?
> >
> > This is not a problem, because the device driver has not yet been inclu=
ded in
> any kernel.
> > My patch for the device driver is still being analyzed by the maintaine=
rs.
> > Only this dt-binding yaml file is already included in the
> > "for-backlight-next" branch of the "backlight" kernel repository.
> > At the moment, this driver is used only in a i.MX8MM board produced in
> > my company, under my full control. No other developer is using it now.
>=20
> Right. This is exactly the sort of commentary that you need to provide up
> front, to have us spent a bunch of time going back and forth to figure ou=
t :(

I'm sorry for wasting your time, I'll add this information in the next comm=
it.

>=20
> > > > The "default-brightness", if omitted in the DT, is managed by the
> > > > device driver, using a default value. This depends on the dimming
> > > > mode
> > > used:
> > >
> > > For default-brightness, has here always been support in the driver
> > > for the property being omitted, or is this newly added?
> >
> > In the first version of the driver this property was a "required
> > property", but nobody has used this driver before, so this should be no=
t a
> problem.
>=20
> > > What I would like is an explanation in the commit message as to why
> > > the revised example is more helpful than the existing (and
> > > must-remain-valid) one.
> >
> > As said before, no one may have ever used this device driver, so I
> > would leave only this new version of the example.
>=20
> Okay. Please improve the commit message explaining why it is okay to make
> these changes & send a v2.
> The alternative is that Lee drops the dt-binding patch & you submit a rev=
ised
> version of the binding alongside the next iteration of the driver.

Ok, I'll send a new commit v2, explaining the reasons for the changes.

>=20
> Cheers,
> Conor.

Thank you Conor,
Flavio.