Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2378908rda; Wed, 25 Oct 2023 00:27:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFuLjgJWXWC9AAsGcQ9Rerfz7nVjS+zqLVW6B1kNYZUWhB6YBfi925ug5Bceu5jqzcb8aO3 X-Received: by 2002:a81:834a:0:b0:59b:ce0b:7829 with SMTP id t71-20020a81834a000000b0059bce0b7829mr15086806ywf.35.1698218877618; Wed, 25 Oct 2023 00:27:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698218877; cv=none; d=google.com; s=arc-20160816; b=xbtirlyDyjpevYqgWCaXJtc55UVE2c++sZ9zd0n8n+BLeZ0qFaTPYbyeEW/TCOLio+ z2QC0ObF9uHmc6mHvH4trpWvne5Dj23qznSfThThshLiyr1TjHcx5RJsKQJfQGrQHjz9 UISe3L6SZ4Y6wPew3j8JJfKfi1SHVrAP26okfNAZfIsrE4pmFI8Kq9AsF6sEIIDykob1 c9HdJuYO1mH8AdYT6FCO6ZqE46+C4rp0A0rSkg0r4XIjnyKOW2uyKV1XJZJ9nEGgiIgJ 2YKWxpCQGa05hJFJt9sUBePMVEbkbPejYi6m++v56i75qe6OgmfNPh/g09H5jxQggMfm IwTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=5dMw+aGAhPCDB5WpPfMm9fCkC3xY7ktIn2cpwtfvNX4=; fh=GHOs9HVy/EkvoVa0c7tWcnx41doBBd5ZnqA4AGna2f8=; b=h7/XQXHj05GJkaMjHBWg4E4yz1arg+tCiGnl+1sV2YxpU7jfgrm8G34VHYkDKNAz3v gLN+pU1r6EYw4MZdF+0Y0YNiOIQjNCFgWRmZQb4DTF0oTPQJ0NzGH4+cSVxzp09+6rUv 0v2J/rPznQoWlTgKiLhVr0iZZXHdTIXUzqab7BVjMl/IjrJwInHKSZ6LbQ09922Kd0Ih 0lNVS3/7cc81pvJDXerXMUNPuGZRgP9qY1pUtRHeIL6lgDISnPmy6ghwF5zXsMuoUX9d VhnhyYOLj2nZz6S7ysVTDKGvOcZplt8goPpJOHlHRIGhK1gDMQc2ycLAmwJy0nl/d7p9 2f4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tVy7heX0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id f14-20020a81414e000000b005ac7e43756bsi5428149ywk.480.2023.10.25.00.27.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 00:27:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tVy7heX0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 23E0F80D7E4D; Wed, 25 Oct 2023 00:27:56 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232346AbjJYH1v (ORCPT + 99 others); Wed, 25 Oct 2023 03:27:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232654AbjJYH1r (ORCPT ); Wed, 25 Oct 2023 03:27:47 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0388BB for ; Wed, 25 Oct 2023 00:27:45 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 549BEC433C7; Wed, 25 Oct 2023 07:27:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698218865; bh=OHCzEzIthYtsFmRjwqYLqDLJQoNHQxGwdn/4gsYlYco=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tVy7heX01oupfPjT2/Ni5AsNmXXmvzGx3m0csV3xk8ovUfuxQ0rTb0Uq5kGXLeSio dETsK4pcTzK1jgkquXiejbDpK60fiVGDlBqp9rU4ontKu9+Mjzdsx5HbIsZdX7imG0 9+wkFzVFxbUIxnxC4m9juYPQhPPbCXl7rit0d4+j1pkNKykoBYHUFMfV6XXpFB+Wg1 I8MRoqKBprf8HWcB9hEI+cxC/4jhlj/uRdPnBIQ4oAICt8EnkxyMrblQZqgfh9o02H 4+taBrFSIhC8XzauuGFTfGtBqMiILElOJjAREgPWyqw26D7l/7JH58cSMMQFlQBx0k Igg4BItzXkLwQ== Message-ID: <01ca878e-aeb1-4fb9-adda-47eaa6f07408@kernel.org> Date: Wed, 25 Oct 2023 16:27:43 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] riscv: boot: Fix creation of loader.bin Content-Language: en-US To: Geert Uytterhoeven , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jisheng Zhang , Alexandre Ghiti , Song Shuai Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <1086025809583809538dfecaa899892218f44e7e.1698159066.git.geert+renesas@glider.be> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <1086025809583809538dfecaa899892218f44e7e.1698159066.git.geert+renesas@glider.be> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 25 Oct 2023 00:27:56 -0700 (PDT) On 10/24/23 23:53, Geert Uytterhoeven wrote: > When flashing loader.bin for K210 using kflash: > >     [ERROR] This is an ELF file and cannot be programmed to flash directly: arch/riscv/boot/loader.bin > > Before, loader.bin relied on "OBJCOPYFLAGS := -O binary" in the main > RISC-V Makefile to create a boot image with the right format. With this > removed, the image is now created in the wrong (ELF) format. > > Fix this by adding an explicit rule. > > Fixes: 505b02957e74f0c5 ("riscv: Remove duplicate objcopy flag") > Signed-off-by: Geert Uytterhoeven Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research