Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Wed, 25 Oct 2023 09:33:09 +0200
From:   Johan Hovold <johan@kernel.org>
To:     Tony Lindgren <tony@atomide.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Rob Herring <robh@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@intel.com>,
        Dhruva Gole <d-gole@ti.com>,
        Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>,
        John Ogness <john.ogness@linutronix.de>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        Maximilian Luz <luzmaximilian@gmail.com>
Subject: Re: [RFC PATCH 1/2] serial: core: Move tty and serdev to be children
 of serial core port device
Message-ID: <ZTjEtWcF4a95BWBK@hovoldconsulting.com>
References: <20231024113624.54364-1-tony@atomide.com>
 <2023102401-playtime-moonrise-6f05@gregkh>
 <20231024122955.GL34982@atomide.com>
 <2023102442-statue-kept-febc@gregkh>
 <20231025065152.GO34982@atomide.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231025065152.GO34982@atomide.com>
Precedence: bulk

On Wed, Oct 25, 2023 at 09:51:52AM +0300, Tony Lindgren wrote:
> * Greg Kroah-Hartman <gregkh@linuxfoundation.org> [231024 14:01]:

> > > > What does this change the sysfs tree to look like?

> Here's the diff of the same command before and after:
> 
> --- /tmp/before 2023-10-25 09:45:12.197283690 +0300
> +++ /tmp/after  2023-10-25 09:43:30.681797899 +0300
> @@ -1,7 +1,9 @@
>  # find /sys -name tty
>  /sys/class/tty
>  /sys/class/tty/tty
> -/sys/devices/pnp0/00:04/tty
> -/sys/devices/platform/serial8250/tty
> +/sys/devices/pnp0/00:04/00:04:0/00:04:0.0/tty
> +/sys/devices/platform/serial8250/serial8250:0/serial8250:0.3/tty
> +/sys/devices/platform/serial8250/serial8250:0/serial8250:0.1/tty
> +/sys/devices/platform/serial8250/serial8250:0/serial8250:0.2/tty
>  /sys/devices/virtual/tty
>  /sys/devices/virtual/tty/tty

Your diff is missing the actual tty devices. 'tty' is just the class
directory. 

And can you post the equivalent diff for serdev as well for completeness?

> There are multiple ports claimed by serial8250. So I think the new sysfs
> output is correct showing more ttys. If there's some reason why serial8250
> should only have one tty and this output is not correct let me know too..

There should not be more class devices, you've just moved them and thus
there are more class directories (with one device per directory).

Johan