Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <c1e638f8-594a-4b09-bfe5-924ca68956ba@intel.com>
Date:   Wed, 25 Oct 2023 17:03:04 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 8/8] iommu/vt-d: Disallow read-only mappings to nest
 parent domain
Content-Language: en-US
To:     "Tian, Kevin" <kevin.tian@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Martins, Joao" <joao.m.martins@oracle.com>
References: <20231024151412.50046-1-yi.l.liu@intel.com>
 <20231024151412.50046-9-yi.l.liu@intel.com>
 <BN9PR11MB52766B032686E89E960426D98CDEA@BN9PR11MB5276.namprd11.prod.outlook.com>
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <BN9PR11MB52766B032686E89E960426D98CDEA@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wm4va2FUcWpYMk5PRjI4VlZNSXVlK3ZiL1NPNlY2c1JIck90bmx4aWRGQkNo?=
 =?utf-8?B?U1M0SXJvYjI5OWxUbVNOa1FxRldLTTR3MUNRelhLcFVPRDNEQ0laa1NldDBW?=
 =?utf-8?B?MFJ5eHEzRHJEalBRcmEvTkVkNnBWd01Lb0hlcFh4NlBxejI2RjlDeXFQRHRl?=
 =?utf-8?B?dWl0QTdnT1ZkaDROb1Y0ckFkNW4yZkpNa2Q2ZGZWcmc5ZGVPUWkydmFxYTlS?=
 =?utf-8?B?VHF5WmN3ZFM5Q3dPcVhQaXM1T0xPUUkzdUwzcVhNUXo5TmRPaXVvSmNxcC9J?=
 =?utf-8?B?U1I4bG16VGg3Wm0wRk42QmRxdjR2aEtQNmo0bGU3anFTK3JrbWl3UndQa1hR?=
 =?utf-8?B?cnlJMUNkTXgzWkpRbmVJOW1hWURWSk1qdXhTTXFtZ2ZVQjRlRm03cDlERWd3?=
 =?utf-8?B?a2tEMzE4TjIwT3dQQmdFSnBheWJNcXJHdmxXaUxSUWtPbWU5aUVLQTFLdGlD?=
 =?utf-8?B?SXhRU0RsNlNCOGJXV0xlTmVVa2dra2xwM1RWMzNMc1h1MDRkVGdjUEJOaGdx?=
 =?utf-8?B?bUVONWdqY2F5cE04TzJ5MStHMTdxbnpIcmFiSkR1djlnM2lUblNGUEd0L1o2?=
 =?utf-8?B?dEZlNk1MZzRlQzRnTWw2eVJiL2VUTUx5Qko3SjRwUTFmVEs1Nkx4cjQxazVG?=
 =?utf-8?B?TE1reGhGNkFYOCtRNm9CZWNtMXVxNXFmWkhWNHVKVGJCelJmdDFZcndlb3BH?=
 =?utf-8?B?cWVDZTlBVVJaTjZWaDJadmZnSUNxa0RidW9XUzNRVHZJVE82YXNuTE1ZMU9S?=
 =?utf-8?B?Q29qYkw3WnJ0RkpoVU0xREJSTkhoMXowbFFqOUpoZW05R2hDTXR6bGdVd2dm?=
 =?utf-8?B?VW1SOG1Uc202eVBKVllISmRZdHlzYldTbFpLWmJGa3RHL2VDb2ZENVhKYktC?=
 =?utf-8?B?RVpCaHhnQWJyNlk4TkFPNWVzcmhQdVIzclZoZmRzbjJkUkx1emM5QmQwS0Zl?=
 =?utf-8?B?QnBxeUIySlh1SHlmUVZwSWF1RzV0RGlsM2dmakRJU3h3NC9LUEZnUnJxZU9B?=
 =?utf-8?B?NU1oOGpEQ2RUNjJVdFEzUCtwYmVoNVdxQ2kxUTByeEhBMlFnVER0MVpaanhO?=
 =?utf-8?B?YmZlVEVxVi9iR2EwcnBydG5ZeTFjNUJXblFJMDEyVUd5VUluWWZrSWI1TEJ2?=
 =?utf-8?B?ejg2UGdzeWlNZG44YjZLdk1PRlI0aTVHQjRjb2xkcXhRYmhtR0ZocCswbFlr?=
 =?utf-8?B?TlRoR2NZMThjeFdINXZvSXFMQWtSdmVRNkZiMExlUHZMQ29NSzdVbVlSM3Rv?=
 =?utf-8?B?a2xoNkgyNS81MUFaYWdRUm5RLzllby8rK2lhL09SRFkrKzZJcjEyMVlPbVpz?=
 =?utf-8?B?MUlPSVZMUVBFbllFUW1ma2tEYy8wa3dyS015anlibVU2RmpMdFYxSnF3SVc2?=
 =?utf-8?B?T1dEYUZrdVNETjl6Mmx1eVZZeDd0alp6cDNYekY3ektTc2Zlem1rUUk3Vzgz?=
 =?utf-8?B?Vlk0TmIrZTdGM3ZmTG1HTTJlT0JOTytWVUd6SGNqUGhob2llZVlyNXA4eHhT?=
 =?utf-8?B?blpXQW12SUtqNjVvZXdhOU05MFZRdmFIejRGVk5IMWN1TGhHQlU3TDZ6bzJJ?=
 =?utf-8?B?cTNMelN4ZzBOVGFIQVBUa0FTd0pUSUpKTWk3UXVxR3YzQlNvbnpGaHhzMFNG?=
 =?utf-8?B?ZnFxTEY0YXBVVHJyVGJDajVXZDZnVS9rbkVXTEVrWDdqcmZlYjhKSitCNkFt?=
 =?utf-8?B?UlBTNDlEVHI1aEFzVk1sbGVtbzY3QXFncEVlc0hLK3AyQWdSR0RwWW9qQnZr?=
 =?utf-8?B?dlZ3a05nR3liK0VwWjRCaFRYNjVMWURmcUo4S0hlajdhWGg4S1BGMjJqcHNO?=
 =?utf-8?B?VU90N1pIZ3JsWm5COVo1TWFyTHplaC9wS3BGMEpxdEdBMHcwcG8wL09GSko5?=
 =?utf-8?B?dW9GVUJ2a3VGaklOY1gzVkFZQ0pnVlBXei9IZE1JNTZyVkF1RkN1eDFBUkI2?=
 =?utf-8?B?cW5TQ05saXNub2VncDhHcnNYZXBYc0JsSHJiMVJTeW9CSmR1ZnJFRUNpcmov?=
 =?utf-8?B?WlYzcE4yREMrU3NLYXNWMWFmU3F3QWFWZEFJdnp6THdPbUhkZzM2dis1QVJt?=
 =?utf-8?B?T1ROTmFOMVNUU1oxR3d1NVVLS1lBaW84Wkdab1AyeTB5akpOU1dWYi9TWGp2?=
 =?utf-8?Q?RjS19UwZdiL6UUVYdFS2Xw/+g?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 70f25887-652a-4b0e-1ad1-08dbd538d8e6
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 09:00:33.9812
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HwLs/9eao21lbef2jELWr667H/wmophl4exI03XhE3FtKaMgAZcAUZ6B3TijsYWE4zYlWu6eTNbbGkaaReiyUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6427
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 25 Oct 2023 02:01:25 -0700 (PDT)


On 2023/10/25 15:35, Tian, Kevin wrote:
>> From: Liu, Yi L <yi.l.liu@intel.com>
>> Sent: Tuesday, October 24, 2023 11:14 PM
>>
>> +/**
>> + * enum iommu_hw_info_vtd_flags - Flags for VT-d hw_info
>> + * @IOMMU_HW_INFO_VTD_ERRATA_772415_SPR17: If set, disallow
>> nesting on domains
>> + *                                   with read-only mapping.
> 
> with how it's implemented now the description should be revised to:
> 
> "If set, disallow read-only mappings on a nested_parent domain"

sure.

-- 
Regards,
Yi Liu